Skip to contentSkip to conversation

octeontx2-af: cn10k: Identical code for different branches

bug report Gustavo A. R. Silva 2 participants 2 messages Feb 12, 2021 – Feb 14, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

In file drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c, function rvu_dbg_init() the same code is executed for both branches:

2431 if (is_rvu_otx2(rvu))
2432 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
2433 rvu, &rvu_dbg_rvu_pf_cgx_map_fops);
2434 else
2435 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
2436 rvu, &rvu_dbg_rvu_pf_cgx_map_fops);

This issue was introduced by commit 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")

What's the right solution for this?

Thanks
---
Gustavo

#1 lore raw

Hi Gustavo,

Please see inline.

________________________________________

Quoted 7 lines

From: Gustavo A. R. Silva <[email protected]>
Sent: Saturday, February 13, 2021 1:31 AM
To: Sunil Kovvuri Goutham; Linu Cherian; Geethasowjanya Akula; Jerin Jacob >Kollanukkaran; Hariprasad Kelam; Subbaraya Sundeep Bhatta; David S. Miller; Jakub >Kicinski
Cc: [email protected]; [email protected]; Gustavo A. R. Silva
Subject: [EXT] [bug report] octeontx2-af: cn10k: Identical code for different branches

External Email

----------------------------------------------------------------------
Hi,

Quoted 10 lines

In file drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c, function rvu_dbg_init() the same code is executed for both branches:

2431 if (is_rvu_otx2(rvu))
2432 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
2433 rvu, &rvu_dbg_rvu_pf_cgx_map_fops);
2434 else
2435 debugfs_create_file("rvu_pf_cgx_map", 0444, rvu->rvu_dbg.root,
2436 rvu, &rvu_dbg_rvu_pf_cgx_map_fops);

Quoted 3 lines

This issue was introduced by commit 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM >MAC support")

What's the right solution for this?

Thanks Gustavo for pointing out. below is the right cod for else conduction.

else

      debugfs_create_file("rvu_pf_rpm_map", 0444, rvu->rvu_dbg.root,
                                    rvu, &rvu_dbg_rvu_pf_cgx_map_fops);

Thanks
---
Gustavo