Skip to contentSkip to conversation

pciconfig_read.2: SYNOPSIS: Fix prototype parameter types

PATCH In review Alejandro Colomar 2 participants 2 messages Feb 15, 2021 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pciconfig_read.2: SYNOPSIS: Fix prototype parameter types

Use the glibc prototypes instead of the kernel ones.
Exception: use 'int' instead of 'enum'.

......

.../glibc$ grep_glibc_prototype pciconfig_read sysdeps/unix/sysv/linux/alpha/sys/io.h:72:
extern int pciconfig_read (unsigned long int __bus,
unsigned long int __dfn,
unsigned long int __off,
unsigned long int __len,
unsigned char *__buf) __THROW;
sysdeps/unix/sysv/linux/ia64/sys/io.h:57:
extern int pciconfig_read (unsigned long int __bus, unsigned long int __dfn,

			   unsigned long int __off, unsigned long int __len,
			   unsigned char *__buf);

.../glibc$ grep_glibc_prototype pciconfig_write sysdeps/unix/sysv/linux/alpha/sys/io.h:78:
extern int pciconfig_write (unsigned long int __bus,
unsigned long int __dfn,
unsigned long int __off,
unsigned long int __len,
unsigned char *__buf) __THROW;
sysdeps/unix/sysv/linux/ia64/sys/io.h:61:
extern int pciconfig_write (unsigned long int __bus, unsigned long int __dfn,

			    unsigned long int __off, unsigned long int __len,
			    unsigned char *__buf);

.../glibc$ grep_glibc_prototype pciconfig_iobase sysdeps/unix/sysv/linux/alpha/sys/io.h:66:
extern long pciconfig_iobase(enum __pciconfig_iobase_which __which,
unsigned long int __bus, unsigned long int __dfn)
__THROW __attribute__ ((const));
.../glibc$

---
 man2/pciconfig_read.2 | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
man2/pciconfig_read.2 +6 -4
index cec6f58e9..c379e2d3b 100644
@@ -13,11 +13,13 @@ pciconfig_read, pciconfig_write, pciconfig_iobase \- pci device information hand
 .B #include <pci.h>
 .PP
 .BI "int pciconfig_read(unsigned long " bus ", unsigned long " dfn ,
-.BI "          unsigned long " off ", unsigned long " len ", void *" buf );
+.BI "                   unsigned long " off ", unsigned long " len ,
+.BI "                   unsigned char *" buf );
 .BI "int pciconfig_write(unsigned long " bus ", unsigned long " dfn ,
-.BI "          unsigned long " off ", unsigned long " len ", void *" buf );
-.BI "int pciconfig_iobase(long " which ", unsigned long " bus ,
-.BI "          unsigned long " devfn );
+.BI "                   unsigned long " off ", unsigned long " len ,
+.BI "                   unsgined char *" buf );
+.BI "int pciconfig_iobase(int " which ", unsigned long " bus ,
+.BI "                   unsigned long " devfn );
 .fi
 .SH DESCRIPTION
 Most of the interaction with PCI devices is already handled by the
Signature · 1 line
2.30.0
#1 lore raw

Hi Alex,

Quoted 35 lines · Alejandro Colomar

Use the glibc prototypes instead of the kernel ones.
Exception: use 'int' instead of 'enum'.

......

.../glibc$ grep_glibc_prototype pciconfig_read sysdeps/unix/sysv/linux/alpha/sys/io.h:72:
extern int pciconfig_read (unsigned long int __bus,
unsigned long int __dfn,
unsigned long int __off,
unsigned long int __len,
unsigned char *__buf) __THROW;
sysdeps/unix/sysv/linux/ia64/sys/io.h:57:
extern int pciconfig_read (unsigned long int __bus, unsigned long int __dfn,

			   unsigned long int __off, unsigned long int __len,
			   unsigned char *__buf);

.../glibc$ grep_glibc_prototype pciconfig_write sysdeps/unix/sysv/linux/alpha/sys/io.h:78:
extern int pciconfig_write (unsigned long int __bus,
unsigned long int __dfn,
unsigned long int __off,
unsigned long int __len,
unsigned char *__buf) __THROW;
sysdeps/unix/sysv/linux/ia64/sys/io.h:61:
extern int pciconfig_write (unsigned long int __bus, unsigned long int __dfn,

			    unsigned long int __off, unsigned long int __len,
			    unsigned char *__buf);

.../glibc$ grep_glibc_prototype pciconfig_iobase sysdeps/unix/sysv/linux/alpha/sys/io.h:66:
extern long pciconfig_iobase(enum __pciconfig_iobase_which __which,
unsigned long int __bus, unsigned long int __dfn)
__THROW __attribute__ ((const));
.../glibc$

Quoted 1 line

Thanks! Patch applied.

Cheers,

Michael

Quoted 27 lines
---
 man2/pciconfig_read.2 | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
man2/pciconfig_read.2 +6 -4
index cec6f58e9..c379e2d3b 100644
@@ -13,11 +13,13 @@ pciconfig_read, pciconfig_write, pciconfig_iobase \- pci device information hand
 .B #include <pci.h>
 .PP
 .BI "int pciconfig_read(unsigned long " bus ", unsigned long " dfn ,
-.BI "          unsigned long " off ", unsigned long " len ", void *" buf );
+.BI "                   unsigned long " off ", unsigned long " len ,
+.BI "                   unsigned char *" buf );
 .BI "int pciconfig_write(unsigned long " bus ", unsigned long " dfn ,
-.BI "          unsigned long " off ", unsigned long " len ", void *" buf );
-.BI "int pciconfig_iobase(long " which ", unsigned long " bus ,
-.BI "          unsigned long " devfn );
+.BI "                   unsigned long " off ", unsigned long " len ,
+.BI "                   unsgined char *" buf );
+.BI "int pciconfig_iobase(int " which ", unsigned long " bus ,
+.BI "                   unsigned long " devfn );
 .fi
 .SH DESCRIPTION
 Most of the interaction with PCI devices is already handled by the
Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/