Skip to contentSkip to conversation

tkill.2: SYNOPSIS: Fix prototype parameter types

PATCH In review Alejandro Colomar 2 participants 2 messages Feb 15, 2021 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tkill.2: SYNOPSIS: Fix prototype parameter types

All but the last parameters of t[g]kill() use 'pid_t', both in the kernel and glibc. Fix them.

......

.../linux/linux$ grep_syscall tkill
kernel/signal.c:3870:
SYSCALL_DEFINE2(tkill, pid_t, pid, int, sig)
include/linux/syscalls.h:685:
asmlinkage long sys_tkill(pid_t pid, int sig);
.../linux/linux$

.../gnu/glibc$ grep_glibc_prototype tgkill sysdeps/unix/sysv/linux/bits/signal_ext.h:29:
extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal); .../gnu/glibc$

---
 man2/tkill.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
man2/tkill.2 +2 -2
index 4b4eae312..24636719d 100644
@@ -31,8 +31,8 @@
 tkill, tgkill \- send a signal to a thread
 .SH SYNOPSIS
 .nf
-.BI "int tkill(int " tid ", int " sig );
-.BI "int tgkill(int " tgid ", int " tid ", int " sig );
+.BI "int tkill(pid_t " tid ", int " sig );
+.BI "int tgkill(pid_t " tgid ", pid_t " tid ", int " sig );
 .fi
 .PP
 .IR Note :
Signature · 1 line
2.30.0
#1 lore raw

Hi Alex,

Quoted 12 lines · Alejandro Colomar

All but the last parameters of t[g]kill() use 'pid_t', both in the kernel and glibc. Fix them.

......

.../linux/linux$ grep_syscall tkill
kernel/signal.c:3870:
SYSCALL_DEFINE2(tkill, pid_t, pid, int, sig)
include/linux/syscalls.h:685:
asmlinkage long sys_tkill(pid_t pid, int sig);
.../linux/linux$

Quoted 6 lines

.../gnu/glibc$ grep_glibc_prototype tgkill sysdeps/unix/sysv/linux/bits/signal_ext.h:29:
extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal); .../gnu/glibc$

Thanks! Patch applied.

Cheers,

Michael

Quoted 20 lines
---
 man2/tkill.2 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
man2/tkill.2 +2 -2
index 4b4eae312..24636719d 100644
@@ -31,8 +31,8 @@
 tkill, tgkill \- send a signal to a thread
 .SH SYNOPSIS
 .nf
-.BI "int tkill(int " tid ", int " sig );
-.BI "int tgkill(int " tgid ", int " tid ", int " sig );
+.BI "int tkill(pid_t " tid ", int " sig );
+.BI "int tgkill(pid_t " tgid ", pid_t " tid ", int " sig );
 .fi
 .PP
 .IR Note :
Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/