Skip to contentSkip to conversation

s390x: Remove sthyi partition number check

PATCH In review Janosch Frank 4 participants 4 messages Feb 18, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390x: Remove sthyi partition number check

Turns out that partition numbers start from 0 and not from 1 so a 0 check doesn't make sense here.

---
 s390x/sthyi.c | 1 -
 1 file changed, 1 deletion(-)
s390x/sthyi.c +0 -1
index d8dfc854..db90b56f 100644
@@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
 		report(sum, "core counts");
 
 	if (par->INFPVAL1 & PART_STSI_SUC) {
-		report(par->INFPPNUM, "number");
 		report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
 		       "name");
 	}
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Janosch Frank

Turns out that partition numbers start from 0 and not from 1 so a 0 check doesn't make sense here.

---
  s390x/sthyi.c | 1 -
  1 file changed, 1 deletion(-)
s390x/sthyi.c +0 -0
index d8dfc854..db90b56f 100644

s390x/sthyi.c static void test_fcode0_par(struct sthyi_par_sctn *par) · line 133

Quoted 7 lines
s390x/sthyi.c +0 -1
@@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
  		report(sum, "core counts");
 
  	if (par->INFPVAL1 & PART_STSI_SUC) {
-		report(par->INFPPNUM, "number");
  		report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
  		       "name");
  	}
Signature · 3 lines
Thanks,

David / dhildenb
Reviewed-by on v1 1/1
#2 lore raw
In reply to Janosch Frank
Quoted 13 lines · On Thu, 18 Feb 2021 03:24:49 -0500 Janosch Frank <[email protected]> wrote:

Turns out that partition numbers start from 0 and not from 1 so a 0 check doesn't make sense here.

---
 s390x/sthyi.c | 1 -
 1 file changed, 1 deletion(-)
s390x/sthyi.c +0 -0
index d8dfc854..db90b56f 100644

s390x/sthyi.c static void test_fcode0_par(struct sthyi_par_sctn *par) · line 133

Quoted 7 lines
s390x/sthyi.c +0 -1
@@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
 		report(sum, "core counts");
 
 	if (par->INFPVAL1 & PART_STSI_SUC) {
-		report(par->INFPPNUM, "number");
 		report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
 		       "name");
 	}
Reviewed-by on v1 1/1
#3 lore raw
In reply to Janosch Frank
Quoted 4 lines · On Thu, 18 Feb 2021 03:24:49 -0500 Janosch Frank <[email protected]> wrote:

Turns out that partition numbers start from 0 and not from 1 so a 0 check doesn't make sense here.

Quoted 16 lines
---
 s390x/sthyi.c | 1 -
 1 file changed, 1 deletion(-)
s390x/sthyi.c +0 -1
index d8dfc854..db90b56f 100644
@@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn
 *par) report(sum, "core counts");
 
 	if (par->INFPVAL1 & PART_STSI_SUC) {
-		report(par->INFPPNUM, "number");
 		report(memcmp(par->INFPPNAM, null_buf,
 sizeof(par->INFPPNAM)), "name");
 	}