Skip to contentSkip to conversation

cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy

PATCH Applied Yue Hu 3 participants 4 messages Feb 18, 2021 – Feb 19, 2021

Subsystems (2)
lore
Share & tools
lore

Yue Hu

author
#0 lore raw

PATCH 1/1 cpufreq: schedutil: Remove comment to update_lock of struct sugov_policy

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq(). The comment is not helpful anymore.

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/cpufreq_schedutil.c +1 -1
index add8081..fd43d59 100644
@@ -26,7 +26,7 @@ struct sugov_policy {
 	struct sugov_tunables	*tunables;
 	struct list_head	tunables_hook;
 
-	raw_spinlock_t		update_lock;	/* For shared policies */
+	raw_spinlock_t		update_lock;
 	u64			last_freq_update_time;
 	s64			freq_update_delay_ns;
 	unsigned int		next_freq;
Signature · 1 line
1.9.1
maintainer Acked-by on v1 1/1
#1 lore raw

Always mention version number and version history in a patch. Don't resend it now anyway.

Quoted 15 lines · Yue Hu

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq(). The comment is not helpful anymore.

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/cpufreq_schedutil.c +0 -0
index add8081..fd43d59 100644

kernel/sched/cpufreq_schedutil.c struct sugov_policy { · line 32

Quoted 8 lines
kernel/sched/cpufreq_schedutil.c +1 -1
@@ -26,7 +26,7 @@ struct sugov_policy {
 	struct sugov_tunables	*tunables;
 	struct list_head	tunables_hook;
 
-	raw_spinlock_t		update_lock;	/* For shared policies */
+	raw_spinlock_t		update_lock;
 	u64			last_freq_update_time;
 	s64			freq_update_delay_ns;
 	unsigned int		next_freq;
Signature · 1 line
viresh
author
#2 lore raw
Quoted 2 lines · On Thu, 18 Feb 2021 15:09:24 +0530 Viresh Kumar <[email protected]> wrote:

Always mention version number and version history in a patch. Don't resend it now anyway.

ok, got it.

Thank you.

Quoted 29 lines · Yue Hu
Quoted 20 lines

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq(). The comment is not helpful anymore.

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/kernel/sched/cpufreq_schedutil.c index add8081..fd43d59 100644

kernel/sched/cpufreq_schedutil.c +0 -1
@@ -26,7 +26,7 @@ struct sugov_policy {
 	struct sugov_tunables	*tunables;
 	struct list_head	tunables_hook;
 
-	raw_spinlock_t		update_lock;	/* For

shared policies */

kernel/sched/cpufreq_schedutil.c struct sugov_policy { · line 32

Quoted 4 lines
kernel/sched/cpufreq_schedutil.c +1 -0
+	raw_spinlock_t		update_lock;
 	u64			last_freq_update_time;
 	s64			freq_update_delay_ns;
 	unsigned int		next_freq;  
maintainer Applied
#3 lore raw
In reply to Viresh Kumar
Quoted 23 lines · Viresh Kumar

Always mention version number and version history in a patch. Don't resend it now anyway.

Quoted 18 lines · Yue Hu

From: Yue Hu <[email protected]>

Currently, update_lock is also used in sugov_update_single_freq(). The comment is not helpful anymore.

---
 kernel/sched/cpufreq_schedutil.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/cpufreq_schedutil.c +0 -0
index add8081..fd43d59 100644
@@ -26,7 +26,7 @@ struct sugov_policy {
      struct sugov_tunables   *tunables;
      struct list_head        tunables_hook;
 
Quoted 7 lines

kernel/sched/cpufreq_schedutil.c struct sugov_policy { · line 32

Quoted 5 lines
kernel/sched/cpufreq_schedutil.c +1 -1
-     raw_spinlock_t          update_lock;    /* For shared policies */
+     raw_spinlock_t          update_lock;
      u64                     last_freq_update_time;
      s64                     freq_update_delay_ns;
      unsigned int            next_freq;

Applied as 5.12-rc material, thanks!