Skip to contentSkip to conversation

backport of dma_virt_ops related fixes to 5.10.y kernels

DISCUSSION Krishnamraju Eraparaju 2 participants 4 messages Feb 19, 2021 – Feb 24, 2021 Stable branch

lore
Share & tools
lore
#0 lore raw

Hi All,

Below commits needs to be backported to 5.10.y kernels to avoid NULL pointer deref panic(while trying to access 'numa_node' from NULL 'dma_device'), @ Line:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/nvme/host/rdma.c?h=v5.10.17#n863)

commit:22dd4c707673129ed17e803b4bf68a567b2731db
commit:8ecfca68dc4cbee1272a0161e3f2fb9387dc6930

The panic is observed at nvme host(provider/transport being SoftiWARP), while perfroming "nvme discover".

Hence, please backport the below patch series to '5.10.y' kernel.
"https://lore.kernel.org/linux-iommu/[email protected]/"

Thanks,
Krishnamraju.

maintainer
#1 lore raw
Quoted 9 lines · Krishnamraju Eraparaju

Hi All,

Below commits needs to be backported to 5.10.y kernels to avoid NULL pointer deref panic(while trying to access 'numa_node' from NULL 'dma_device'), @ Line:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/nvme/host/rdma.c?h=v5.10.17#n863)

commit:22dd4c707673129ed17e803b4bf68a567b2731db
commit:8ecfca68dc4cbee1272a0161e3f2fb9387dc6930

So just these 2 commits? In which order?

Quoted 5 lines

The panic is observed at nvme host(provider/transport being SoftiWARP), while perfroming "nvme discover".

Hence, please backport the below patch series to '5.10.y' kernel.
"https://lore.kernel.org/linux-iommu/[email protected]/"

What are the git commit ids of these patches in Linus's tree and have you tested them to ensure that they work? Why this 10 patch series and not the 2 above? Or is this a different request?

confused,

greg k-h

#2 lore raw
Quoted 16 lines · Greg KH
Quoted 9 lines · Krishnamraju Eraparaju

Hi All,

Below commits needs to be backported to 5.10.y kernels to avoid NULL pointer deref panic(while trying to access 'numa_node' from NULL 'dma_device'), @ Line:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/nvme/host/rdma.c?h=v5.10.17#n863)

commit:22dd4c707673129ed17e803b4bf68a567b2731db
commit:8ecfca68dc4cbee1272a0161e3f2fb9387dc6930

So just these 2 commits? In which order?

Quoted 3 lines

The panic is observed at nvme host(provider/transport being SoftiWARP), while perfroming "nvme discover".

Quoted 8 lines
Quoted 2 lines

Hence, please backport the below patch series to '5.10.y' kernel.
"https://lore.kernel.org/linux-iommu/[email protected]/"

What are the git commit ids of these patches in Linus's tree and have you tested them to ensure that they work? Why this 10 patch series and not the 2 above? Or is this a different request?

confused,

Hi Greg,

Sorry for the confusion, I didn't know that I can request for the backport of selected patches in a patch series.
As I don't have much background & testing feasability of other patches, I request you to backport only below two patches(same order as below):

commit#1:8ecfca68dc4cbee1272a0161e3f2fb9387dc6930
RDMA: Lift ibdev_to_node from rds to common code
author: Christoph Hellwig <[email protected]>

commit#2:22dd4c707673129ed17e803b4bf68a567b2731db
nvme-rdma: Use ibdev_to_node instead of dereferencing ->dma_device
author: Christoph Hellwig <[email protected]>

And I belive these two patches has no dependency with other patches in the series. I've tested, it's working fine.

Thanks,
Krishnamraju.

Quoted 2 lines

greg k-h

maintainer
#3 lore raw
Quoted 36 lines · Krishnamraju Eraparaju
Quoted 16 lines · Greg KH
Quoted 9 lines · Krishnamraju Eraparaju

Hi All,

Below commits needs to be backported to 5.10.y kernels to avoid NULL pointer deref panic(while trying to access 'numa_node' from NULL 'dma_device'), @ Line:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/nvme/host/rdma.c?h=v5.10.17#n863)

commit:22dd4c707673129ed17e803b4bf68a567b2731db
commit:8ecfca68dc4cbee1272a0161e3f2fb9387dc6930

So just these 2 commits? In which order?

Quoted 3 lines

The panic is observed at nvme host(provider/transport being SoftiWARP), while perfroming "nvme discover".

Quoted 8 lines
Quoted 2 lines

Hence, please backport the below patch series to '5.10.y' kernel.
"https://lore.kernel.org/linux-iommu/[email protected]/"

What are the git commit ids of these patches in Linus's tree and have you tested them to ensure that they work? Why this 10 patch series and not the 2 above? Or is this a different request?

confused,

Hi Greg,

Sorry for the confusion, I didn't know that I can request for the backport of selected patches in a patch series.
As I don't have much background & testing feasability of other patches, I request you to backport only below two patches(same order as below):

commit#1:8ecfca68dc4cbee1272a0161e3f2fb9387dc6930
RDMA: Lift ibdev_to_node from rds to common code
author: Christoph Hellwig <[email protected]>

Quoted 6 lines

commit#2:22dd4c707673129ed17e803b4bf68a567b2731db
nvme-rdma: Use ibdev_to_node instead of dereferencing ->dma_device
author: Christoph Hellwig <[email protected]>

And I belive these two patches has no dependency with other patches in the series. I've tested, it's working fine.

Now queued up, thanks.

greg k-h