Skip to contentSkip to conversation

Signed-off-by: Michael Estner <[email protected]>

PATCH Linus Walleij 1 participant 1 message Mar 1, 2021 1 message not in the archive GPIO

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Michael!

Thanks for your patch!

Make sure to send patches to the linux-gpio list and Bartosz as well.

Quoted 11 lines · Michael Estner

Delete unused else if iteration.

---
 drivers/gpio/gpiolib.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpio/gpiolib.c +0 -0
index 97eec8d8dbdc..1fe38fc99b8f 100644

drivers/gpio/gpiolib.c int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, · line 617

Quoted 6 lines
drivers/gpio/gpiolib.c +0 -3
@@ -612,9 +612,6 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
        dev_set_drvdata(&gdev->dev, gdev);
        if (gc->parent && gc->parent->driver)
                gdev->owner = gc->parent->driver->owner;
-       else if (gc->owner)
-               /* TODO: remove chip->owner */
-               gdev->owner = gc->owner;

As long as we have not resolved the TODO I think this needs to stay around.

What makes you think this is not needed anymore?

Yours,
Linus Walleij