Bluetooth: btusb: Fix incorrect type in assignment and uninitialized symbol
Subsystems (2)
PATCH 1/1 Bluetooth: btusb: Fix incorrect type in assignment and uninitialized symbol
From: "mark-yw.chen" <[email protected]>
Warnings: drivers/bluetooth/btusb.c:3775 btusb_mtk_setup() error:
uninitialized symbol 'fw_version'.
-> add initial value for fw_version.
Warnings: sparse: sparse: incorrect type in assignment (different base types)
-> add le32_to_cpu to fix incorrect type in assignment.
--- drivers/bluetooth/btusb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/bluetooth/btusb.c +4 -4
@@ -3495,7 +3495,7 @@ static int btusb_mtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwnam fw_ptr = fw->data; fw_bin_ptr = fw_ptr; globaldesc = (struct btmtk_global_desc *)(fw_ptr +MTK_FW_ROM_PATCH_HEADER_SIZE ); - section_num = globaldesc->section_num; + section_num =le32_to_cpu (globaldesc->section_num);for (i =0 ; i < section_num; i++) { first_block =1 ;
@@ -3503,8 +3503,8 @@ static int btusb_mtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwnam sectionmap = (struct btmtk_section_map *)(fw_ptr +MTK_FW_ROM_PATCH_HEADER_SIZE +MTK_FW_ROM_PATCH_GD_SIZE +MTK_FW_ROM_PATCH_SEC_MAP_SIZE * i); - section_offset = sectionmap->secoffset; - dl_size = sectionmap->bin_info_spec.dlsize; + section_offset =le32_to_cpu (sectionmap->secoffset); + dl_size =le32_to_cpu (sectionmap->bin_info_spec.dlsize);if (dl_size >0 ) { retry =20 ;
@@ -3740,7 +3740,7 @@ static int btusb_mtk_setup(struct hci_dev *hdev)int err, status;u32 dev_id;char fw_bin_name[64 ]; -u32 fw_version; +u32 fw_version =0 ;u8 param; calltime =ktime_get ();
Signature · 5 lines
2.18.0 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Marcel Holtmann
maintainerHi Mark,
Quoted 4 lines
Warnings:
drivers/bluetooth/btusb.c:3775btusb_mtk_setup()error:
uninitialized symbol 'fw_version'.
-> add initial value forfw_version.
Quoted 8 lines
Warnings: sparse: sparse: incorrect type in assignment (different base types)
-> addle32_to_cputo fix incorrect type in assignment.Signed-off-by mark-yw.chen <[email protected]>---
drivers/bluetooth/btusb.c| 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek