Skip to contentSkip to conversation

monitor: Fix handling of BT_HCI_EVT_LE_BIG_COMPLETE

PATCH In review Luiz Augusto von Dentz 3 participants 6 messages Feb 23, 2021 Bluetooth drivers

lore
Share & tools
lore

Luiz Augusto von Dentz

author maintainer
#0 lore raw

PATCH 1/2 monitor: Fix handling of BT_HCI_EVT_LE_BIG_COMPLETE

From: Luiz Augusto von Dentz <[email protected]>

This adds the missing fields for BT_HCI_EVT_LE_BIG_COMPLETE event.

---
 monitor/bt.h     | 6 ++++++
 monitor/packet.c | 6 ++++++
 2 files changed, 12 insertions(+)
monitor/bt.h +6 -0
index aca847d7c..394dd7a2d 100644
@@ -3533,6 +3533,12 @@ struct bt_hci_evt_le_big_complete {
 	uint8_t  sync_delay[3];
 	uint8_t  latency[3];
 	uint8_t  phy;
+	uint8_t  nse;
+	uint8_t  bn;
+	uint8_t  pto;
+	uint8_t  irc;
+	uint16_t max_pdu;
+	uint16_t interval;
 	uint8_t  num_bis;
 	uint16_t handle[0];
 } __attribute__ ((packed));
monitor/packet.c +6 -0
index fcd698d92..55ba16ccc 100644
@@ -10575,6 +10575,12 @@ static void le_big_complete_evt(const void *data, uint8_t size)
 	print_usec_interval("BIG Synchronization Delay", evt->sync_delay);
 	print_usec_interval("Transport Latency", evt->latency);
 	print_le_phy("PHY", evt->phy);
+	print_field("NSE: %u", evt->nse);
+	print_field("BN: %u", evt->bn);
+	print_field("PTO: %u", evt->bn);
+	print_field("IRC: %u", evt->irc);
+	print_field("Maximum PDU: %u", evt->max_pdu);
+	print_slot_125("ISO Interval", evt->interval);
 	print_list(evt->handle, size, evt->num_bis, sizeof(*evt->handle),
 						print_bis_handle);
 }
Signature · 1 line
2.29.2
author maintainer
#1 lore raw

PATCH 2/2 monitor: Fix handling of BT_HCI_EVT_LE_BIG_SYNC_ESTABILISHED

From: Luiz Augusto von Dentz <[email protected]>

This adds the missing fields for BT_HCI_EVT_LE_BIG_SYNC_ESTABILISHED event.

---
 monitor/bt.h     | 6 ++++++
 monitor/packet.c | 6 ++++++
 2 files changed, 12 insertions(+)
monitor/bt.h +6 -0
index 394dd7a2d..a77a2ee60 100644
@@ -3554,6 +3554,12 @@ struct bt_hci_evt_le_big_sync_estabilished {
 	uint8_t  status;
 	uint8_t  big_id;
 	uint8_t  latency[3];
+	uint8_t  nse;
+	uint8_t  bn;
+	uint8_t  pto;
+	uint8_t  irc;
+	uint16_t max_pdu;
+	uint16_t interval;
 	uint8_t  num_bis;
 	uint16_t handle[0];
 } __attribute__ ((packed));
monitor/packet.c +6 -0
index 55ba16ccc..c07676253 100644
@@ -10600,6 +10600,12 @@ static void le_big_sync_estabilished_evt(const void *data, uint8_t size)
 	print_status(evt->status);
 	print_field("BIG ID: 0x%2.2x", evt->big_id);
 	print_usec_interval("Transport Latency", evt->latency);
+	print_field("NSE: %u", evt->nse);
+	print_field("BN: %u", evt->bn);
+	print_field("PTO: %u", evt->bn);
+	print_field("IRC: %u", evt->irc);
+	print_field("Maximum PDU: %u", evt->max_pdu);
+	print_slot_125("ISO Interval", evt->interval);
 	print_list(evt->handle, size, evt->num_bis, sizeof(*evt->handle),
 						print_bis_handle);
 }
Signature · 1 line
2.29.2
#2 lore raw
In reply to Luiz Augusto von Dentz

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=437331

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - FAIL
Output:
configure.ac:21: installing './compile' configure.ac:33: installing './config.guess' configure.ac:33: installing './config.sub' configure.ac:5: installing './install-sh' configure.ac:5: installing './missing' Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
configure: error: Embedded Linux library >= 0.37 is required

##############################
Test: MakeCheck - SKIPPED
Output:
checkbuild not success

---
Regards,
Linux Bluetooth

#3 lore raw

Hi Luiz

On 2/23/21, 11:40 AM, "[email protected]" <[email protected]> wrote:

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=437331

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - FAIL
Output:
configure.ac:21: installing './compile' configure.ac:33: installing './config.guess' configure.ac:33: installing './config.sub' configure.ac:5: installing './install-sh' configure.ac:5: installing './missing' Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
configure: error: Embedded Linux library >= 0.37 is required

There was an issue with Docker image and it is resolved by now. Please wait for the next test result.

##############################
Test: MakeCheck - SKIPPED
Output:
checkbuild not success

---
Regards,
Linux Bluetooth

author maintainer
#4 lore raw
In reply to [email protected]

Hi,

Quoted 37 lines · On Tue, Feb 23, 2021 at 11:37 AM <[email protected]> wrote:

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=437331

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - FAIL
Output:
configure.ac:21: installing './compile' configure.ac:33: installing './config.guess' configure.ac:33: installing './config.sub' configure.ac:5: installing './install-sh' configure.ac:5: installing './missing' Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
configure: error: Embedded Linux library >= 0.37 is required

##############################
Test: MakeCheck - SKIPPED
Output:
checkbuild not success

Quoted 3 lines

---
Regards,
Linux Bluetooth

Pushed.

Signature · 1 line
Luiz Augusto von Dentz
#5 lore raw
In reply to Luiz Augusto von Dentz

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=437331

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS

---
Regards,
Linux Bluetooth