Skip to contentSkip to conversation

parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY

PATCH Superseded Sami Tolvanen 3 participants 5 messages Feb 24, 2021 PA-RISC architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY

parisc uses -fpatchable-function-entry with dynamic ftrace, which means we don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell that to the build system.

Fixes 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
---
 arch/parisc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/Kconfig +1 -0
index ecef9aff9d72..9ee806f68123 100644
@@ -60,6 +60,7 @@ config PARISC
 	select HAVE_KPROBES
 	select HAVE_KRETPROBES
 	select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE
 	select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
 	select HAVE_KPROBES_ON_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS

base-commit: 719bbd4a509f403f537adcaefd8ce17532be2e84

Signature · 1 line
2.30.0.617.g56c4b15f3c-goog
Tested-by on v1 1/1
#1 lore raw
Quoted 7 lines · Sami Tolvanen

parisc uses -fpatchable-function-entry with dynamic ftrace, which means we don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell that to the build system.

Fixes 3b15cdc15956 ("tracing: move function tracer options to Kconfig")

I've got parisc building now, and can confirm:

Guenter, does this fix it for you too?

-Kees

Quoted 21 lines
---
 arch/parisc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/Kconfig +1 -0
index ecef9aff9d72..9ee806f68123 100644
@@ -60,6 +60,7 @@ config PARISC
 	select HAVE_KPROBES
 	select HAVE_KRETPROBES
 	select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE
 	select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
 	select HAVE_KPROBES_ON_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS

base-commit: 719bbd4a509f403f537adcaefd8ce17532be2e84

Signature · 1 line
2.30.0.617.g56c4b15f3c-goog
Signature · 1 line
Kees Cook
#2 lore raw
Quoted 9 lines · Kees Cook
Quoted 7 lines · Sami Tolvanen

parisc uses -fpatchable-function-entry with dynamic ftrace, which means we don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell that to the build system.

Fixes 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
Quoted 6 lines

I've got parisc building now, and can confirm:

Guenter, does this fix it for you too?

I get this:

WARNING: unmet direct dependencies detected for FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
Depends on [n]: TRACING_SUPPORT [=y] && FTRACE [=y] && FTRACE_MCOUNT_RECORD [=n] Selected by [y]:
- PARISC [=y] && HAVE_DYNAMIC_FTRACE [=y]

when trying to build parisc:defconfig.

I think it should be

select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE

(no HAVE_)

Guenter

Quoted 26 lines

-Kees

Quoted 21 lines
---
 arch/parisc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/Kconfig +1 -0
index ecef9aff9d72..9ee806f68123 100644
@@ -60,6 +60,7 @@ config PARISC
 	select HAVE_KPROBES
 	select HAVE_KRETPROBES
 	select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE
 	select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
 	select HAVE_KPROBES_ON_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS

base-commit: 719bbd4a509f403f537adcaefd8ce17532be2e84

Signature · 1 line
2.30.0.617.g56c4b15f3c-goog
Signature · 1 line
Kees Cook
#3 lore raw
Quoted 25 lines · Guenter Roeck
Quoted 9 lines · Kees Cook
Quoted 7 lines · Sami Tolvanen

parisc uses -fpatchable-function-entry with dynamic ftrace, which means we don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell that to the build system.

Fixes 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
Quoted 6 lines

I've got parisc building now, and can confirm:

Guenter, does this fix it for you too?

I get this:

WARNING: unmet direct dependencies detected for FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
Depends on [n]: TRACING_SUPPORT [=y] && FTRACE [=y] && FTRACE_MCOUNT_RECORD [=n] Selected by [y]:
- PARISC [=y] && HAVE_DYNAMIC_FTRACE [=y]

Quoted 7 lines

when trying to build parisc:defconfig.

I think it should be

select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE

(no HAVE_)

Ah, it depends on FTRACE_MCOUNT_RECORD. Thanks for testing. I'll send v2.

Sami

#4 lore raw
In reply to Guenter Roeck
Quoted 24 lines · Guenter Roeck
Quoted 9 lines · Kees Cook
Quoted 7 lines · Sami Tolvanen

parisc uses -fpatchable-function-entry with dynamic ftrace, which means we don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell that to the build system.

Fixes 3b15cdc15956 ("tracing: move function tracer options to Kconfig")
Quoted 6 lines

I've got parisc building now, and can confirm:

Guenter, does this fix it for you too?

I get this:

WARNING: unmet direct dependencies detected for FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
Depends on [n]: TRACING_SUPPORT [=y] && FTRACE [=y] && FTRACE_MCOUNT_RECORD [=n] Selected by [y]:
- PARISC [=y] && HAVE_DYNAMIC_FTRACE [=y]

Quoted 7 lines

when trying to build parisc:defconfig.

I think it should be

select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_FTRACE

(no HAVE_)

Yeah, that works for me with both defconfig and allmodconfig. (And that more closely matches what's done for arm64.)

-Kees

Quoted 29 lines

Guenter

Quoted 26 lines

-Kees

Quoted 21 lines
---
 arch/parisc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/parisc/Kconfig +1 -0
index ecef9aff9d72..9ee806f68123 100644
@@ -60,6 +60,7 @@ config PARISC
 	select HAVE_KPROBES
 	select HAVE_KRETPROBES
 	select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1)
+	select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE
 	select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE
 	select HAVE_KPROBES_ON_FTRACE
 	select HAVE_DYNAMIC_FTRACE_WITH_REGS

base-commit: 719bbd4a509f403f537adcaefd8ce17532be2e84

Signature · 1 line
2.30.0.617.g56c4b15f3c-goog
Signature · 1 line
Kees Cook
Signature · 1 line
Kees Cook