Skip to contentSkip to conversation

rtc: tps65910: include linux/property.h

PATCH Applied Arnd Bergmann 3 participants 3 messages Feb 25, 2021 – Mar 15, 2021 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: tps65910: include linux/property.h

From: Arnd Bergmann <[email protected]>

The added device_property_present() call causes a build failure in some configurations because of the missing header:

drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]

Fixes 454ba154a62c ("rtc: tps65910: Support wakeup-source property")
---
 drivers/rtc/rtc-tps65910.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/rtc-tps65910.c +1 -0
index 288abb1abdb8..bc89c62ccb9b 100644
@@ -18,6 +18,7 @@
 #include <linux/rtc.h>
 #include <linux/bcd.h>
 #include <linux/math64.h>
+#include <linux/property.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 #include <linux/mfd/tps65910.h>
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw

25.02.2021 16:42, Arnd Bergmann пишет:

Quoted 19 lines

From: Arnd Bergmann <[email protected]>

The added device_property_present() call causes a build failure in some configurations because of the missing header:

drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]

Fixes 454ba154a62c ("rtc: tps65910: Support wakeup-source property")
---
 drivers/rtc/rtc-tps65910.c | 1 +
 1 file changed, 1 insertion(+)
drivers/rtc/rtc-tps65910.c +0 -0
index 288abb1abdb8..bc89c62ccb9b 100644

drivers/rtc/rtc-tps65910.c line 24

Quoted 7 lines
drivers/rtc/rtc-tps65910.c +1 -0
@@ -18,6 +18,7 @@
 #include <linux/rtc.h>
 #include <linux/bcd.h>
 #include <linux/math64.h>
+#include <linux/property.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>
 #include <linux/mfd/tps65910.h>
maintainer Applied
#2 lore raw
In reply to Arnd Bergmann
Quoted 4 lines · Arnd Bergmann

The added device_property_present() call causes a build failure in some configurations because of the missing header:

drivers/rtc/rtc-tps65910.c:422:7: error: implicit declaration of function 'device_property_present' [-Werror,-Wimplicit-function-declaration]

Applied, thanks!

[1/1] rtc: tps65910: include linux/property.h

      commit: 936d3685e62436a378f02b8b74759b054d4aeca1

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>