nvme: send uevent once a multipath namespace is operational again
PATCH 1/1 nvme: send uevent once a multipath namespace is operational again
In an all paths down scenario I/O will be requeued or aborted, and no further I/O will be ongoing on this namespace.
This leaves the upper layers unable to determine if the namespace becomes operational again eg. after a successful controller reset. With this patch a 'change' uevent will be sent per multipathed namespace once the underlying controller moved to LIVE and started I/O processing by calling nvme_kick_requeue_lists().
--- drivers/nvme/host/multipath.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/nvme/host/multipath.c +6 -2
@@ -97,8 +97,12 @@ void nvme_kick_requeue_lists(struct nvme_ctrl *ctrl)down_read (&ctrl->namespaces_rwsem);list_for_each_entry (ns, &ctrl->namespaces, list) { -if (ns->head->disk) -kblockd_schedule_work (&ns->head->requeue_work); +if (!ns->head->disk) +continue ; +kblockd_schedule_work (&ns->head->requeue_work); +if (ctrl->state ==NVME_CTRL_LIVE ) +kobject_uevent (&disk_to_dev (ns->head->disk)->kobj, +KOBJ_CHANGE ); }up_read (&ctrl->namespaces_rwsem); }
Signature · 7 lines
2.26.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 9 lines · Hannes Reinecke
In an all paths down scenario I/O will be requeued or aborted, and no further I/O will be ongoing on this namespace.
This leaves the upper layers unable to determine if the namespace becomes operational again eg. after a successful controller reset. With this patch a 'change' uevent will be sent per multipathed namespace once the underlying controller moved to LIVE and started I/O processing by callingnvme_kick_requeue_lists().Signed-off-by Hannes Reinecke <[email protected]>
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
maintainerQuoted 7 lines · Hannes Reinecke
In an all paths down scenario I/O will be requeued or aborted, and no further I/O will be ongoing on this namespace.
This leaves the upper layers unable to determine if the namespace becomes operational again eg. after a successful controller reset. With this patch a 'change' uevent will be sent per multipathed namespace once the underlying controller moved to LIVE and started I/O processing by callingnvme_kick_requeue_lists().
This should use disk_uevent().
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 11 lines · Christoph Hellwig
Quoted 7 lines · Hannes Reinecke
In an all paths down scenario I/O will be requeued or aborted, and no further I/O will be ongoing on this namespace.
This leaves the upper layers unable to determine if the namespace becomes operational again eg. after a successful controller reset. With this patch a 'change' uevent will be sent per multipathed namespace once the underlying controller moved to LIVE and started I/O processing by callingnvme_kick_requeue_lists().This should use
disk_uevent().
Right. Will be updating the patch.
Cheers,
Hannes
Signature · 9 lines
Dr. Hannes Reinecke Kernel Storage Architect [email protected] +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme