Skip to contentSkip to conversation

ovl: do not copy attr several times

RFC PATCH Applied Chengguang Xu 2 participants 2 messages Feb 26, 2021 – Mar 24, 2021 Overlay filesystem

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 ovl: do not copy attr several times

In ovl_xattr_set() we have already copied attr of real inode so no need to copy it again in ovl_posix_acl_xattr_set().

---
 fs/overlayfs/super.c | 3 ---
 1 file changed, 3 deletions(-)
fs/overlayfs/super.c +0 -3
index d58b8f2bf9d0..c61f42c901d1 100644
@@ -1035,9 +1035,6 @@ ovl_posix_acl_xattr_set(const struct xattr_handler *handler,
 	}
 
 	err = ovl_xattr_set(dentry, inode, handler->name, value, size, flags);
-	if (!err)
-		ovl_copyattr(ovl_inode_real(inode), inode);
-
 	return err;
 
 out_acl_release:
Signature · 1 line
2.27.0
maintainer Applied
#1 lore raw
Quoted 3 lines · Chengguang Xu

In ovl_xattr_set() we have already copied attr of real inode so no need to copy it again in ovl_posix_acl_xattr_set().

Thanks, applied.

Miklos