Skip to contentSkip to conversation

lib-stackdepot-add-support-to-configure-stack_hash_size.patch removed from -mm tree

merged [email protected] 1 participant 1 message Feb 27, 2021

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: lib: stackdepot: add support to configure STACK_HASH_SIZE
has been removed from the -mm tree. Its filename was
lib-stackdepot-add-support-to-configure-stack_hash_size.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Yogesh Lal <[email protected]>
Subject: lib: stackdepot: add support to configure STACK_HASH_SIZE

Use CONFIG_STACK_HASH_ORDER to configure STACK_HASH_SIZE.

Aim is to have configurable value for STACK_HASH_SIZE, so depend on use case one can configure it.

One example is of Page Owner, CONFIG_PAGE_OWNER works only if page_owner=on via kernel parameter on CONFIG_PAGE_OWNER configured system. Thus, unless admin enable it via command line option, the stackdepot will just waste 8M memory without any customer.

Making it configurable and use lower value helps to enable features like CONFIG_PAGE_OWNER without any significant overhead.

---

 lib/Kconfig      |    9 +++++++++
 lib/stackdepot.c |    3 +--
 2 files changed, 10 insertions(+), 2 deletions(-)
lib/Kconfig renamed from lib/Kconfig~lib-stackdepot-add-support-to-configure-stack_hash_size +9 -0
@@ -651,6 +651,15 @@ config STACKDEPOT
 	bool
 	select STACKTRACE
 
+config STACK_HASH_ORDER
+	int "stack depot hash size (12 => 4KB, 20 => 1024KB)"
+	range 12 20
+	default 20
+	depends on STACKDEPOT
+	help
+	 Select the hash size as a power of 2 for the stackdepot hash table.
+	 Choose a lower value to reduce the memory impact.
+
 config SBITMAP
 	bool
 
lib/stackdepot.c renamed from lib/stackdepot.c~lib-stackdepot-add-support-to-configure-stack_hash_size +1 -2
@@ -141,8 +141,7 @@ static struct stack_record *depot_alloc_
 	return stack;
 }
 
-#define STACK_HASH_ORDER 20
-#define STACK_HASH_SIZE (1L << STACK_HASH_ORDER)
+#define STACK_HASH_SIZE (1L << CONFIG_STACK_HASH_ORDER)
 #define STACK_HASH_MASK (STACK_HASH_SIZE - 1)
 #define STACK_HASH_SEED 0x9747b28c
 

_

Patches currently in -mm which might be from [email protected] are