Skip to contentSkip to conversation

tpm: Remove unintentional dump_stack() call

PATCH In review [email protected] 2 participants 2 messages Mar 1, 2021

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 tpm: Remove unintentional dump_stack() call

From: Jarkko Sakkinen <[email protected]>

Somewhere along the line, probably during a rebase, an unintentional dump_stack() got included. Revert this change.

Fixes 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
---
 drivers/char/tpm/tpm-chip.c | 2 --
 1 file changed, 2 deletions(-)
drivers/char/tpm/tpm-chip.c +0 -2
index 19e23fcc6bc8..ddaeceb7e109 100644
@@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
 {
 	struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
 
-	dump_stack();
-
 	/* release the master device reference */
 	put_device(&chip->dev);
 }
Signature · 1 line
2.30.1
Acked-by on v1 1/1
#1 lore raw
Quoted 28 lines · On Mon, Mar 01, 2021 at 11:44:09AM +0200, [email protected] wrote:

From: Jarkko Sakkinen <[email protected]>

Somewhere along the line, probably during a rebase, an unintentional dump_stack() got included. Revert this change.

Fixes 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
---
 drivers/char/tpm/tpm-chip.c | 2 --
 1 file changed, 2 deletions(-)
drivers/char/tpm/tpm-chip.c +0 -2
index 19e23fcc6bc8..ddaeceb7e109 100644
@@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
 {
 	struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
 
-	dump_stack();
-
 	/* release the master device reference */
 	put_device(&chip->dev);
 }
Signature · 1 line
2.30.1