drm/amd/display: fix the return of the uninitialized value in ret
PATCH 1/1 drm/amd/display: fix the return of the uninitialized value in ret
From: Colin Ian King <[email protected]>
Currently if stream->signal is neither SIGNAL_TYPE_DISPLAY_PORT_MST or SIGNAL_TYPE_DISPLAY_PORT then variable ret is uninitialized and this is checked for > 0 at the end of the function. Ret should be initialized, I believe setting it to zero is a correct default.
Addresses-Coverity: ("Uninitialized scalar variable")
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1
@@ -530,7 +530,7 @@ bool dm_helpers_dp_write_dsc_enable( {uint8_t enable_dsc = enable ?1 :0 ;struct amdgpu_dm_connector *aconnector; -uint8_t ret; +uint8_t ret =0 ;if (!stream)return false;
Signature · 6 lines
2.30.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Colin King
From: Colin Ian King <[email protected]>
Currently if
stream->signalis neitherSIGNAL_TYPE_DISPLAY_PORT_MSTorSIGNAL_TYPE_DISPLAY_PORTthen variable ret is uninitialized and this is checked for > 0 at the end of the function. Ret should be initialized, I believe setting it to zero is a correct default.Addresses-Coverity: ("Uninitialized scalar variable")
Fixes bd0c064c161c ("drm/amd/display: Add return code instead of boolean for future use")Signed-off-by Colin Ian King <[email protected]>
Harry
Quoted 10 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0
-0
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c bool dm_helpers_dp_write_dsc_enable( · line 536
Quoted 8 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1
-1@@ -530,7 +530,7 @@ bool dm_helpers_dp_write_dsc_enable( {uint8_t enable_dsc = enable ?1 :0 ;struct amdgpu_dm_connector *aconnector; -uint8_t ret; +uint8_t ret =0 ;if (!stream)return false;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 32 lines · Harry Wentland
Quoted 10 lines · Colin King
From: Colin Ian King <[email protected]>
Currently if
stream->signalis neitherSIGNAL_TYPE_DISPLAY_PORT_MSTorSIGNAL_TYPE_DISPLAY_PORTthen variable ret is uninitialized and this is checked for > 0 at the end of the function. Ret should be initialized, I believe setting it to zero is a correct default.Addresses-Coverity: ("Uninitialized scalar variable")
Fixes bd0c064c161c ("drm/amd/display: Add return code instead of boolean for future use")Signed-off-by Colin Ian King <[email protected]>Reviewed-by Harry Wentland <[email protected]>Harry
Quoted 15 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1
-1@@ -530,7 +530,7 @@ bool dm_helpers_dp_write_dsc_enable( {uint8_t enable_dsc = enable ?1 :0 ;struct amdgpu_dm_connector *aconnector; -uint8_t ret; +uint8_t ret =0 ;
Quoted 7 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c bool dm_helpers_dp_write_dsc_enable( · line 536
Quoted 3 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0
-0if (!stream)return false;_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel