Skip to contentSkip to conversation

ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level

PATCH RESEND New Krzysztof Kozlowski 1 participant 2 messages Mar 3, 2021 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/2 ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level

The Maxim fuel gauge datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct.

Fixes 45dfa741df86 ("ARM: dts: qcom: msm8974-lge-nexus5: Add fuel gauge")
---
 arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts +1 -1
index 0cda654371ae..56ee02ceba7d 100644
@@ -575,7 +575,7 @@ fuelgauge: max17048@36 {
 			maxim,rcomp = /bits/ 8 <0x4d>;
 
 			interrupt-parent = <&msmgpio>;
-			interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
+			interrupts = <9 IRQ_TYPE_LEVEL_LOW>;
 
 			pinctrl-names = "default";
 			pinctrl-0 = <&fuelgauge_pin>;
Signature · 1 line
2.25.1
#1 lore raw

PATCH RESEND 2/2 ARM: dts: qcom: msm8974-samsung-klte: correct fuel gauge interrupt trigger level

The Maxim fuel gauge datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct.

Fixes da8d46992e67 ("ARM: dts: qcom: msm8974-klte: Add fuel gauge")
---
 arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/qcom-msm8974-samsung-klte.dts +1 -1
index a0f7f461f48c..2dadb836c5fe 100644
@@ -717,7 +717,7 @@ fuelgauge@36 {
 			maxim,rcomp = /bits/ 8 <0x56>;
 
 			interrupt-parent = <&pma8084_gpios>;
-			interrupts = <21 IRQ_TYPE_EDGE_FALLING>;
+			interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
 
 			pinctrl-names = "default";
 			pinctrl-0 = <&fuelgauge_pin>;
Signature · 1 line
2.25.1