scsi: mpt3sas: fix error return code of mpt3sas_base_attach()
Subsystems (2)
PATCH 1/1 scsi: mpt3sas: fix error return code of mpt3sas_base_attach()
When kzalloc() returns NULL, no error return code of mpt3sas_base_attach() is assigned.
To fix this bug, r is assigned with -ENOMEM in this case.
Fixes c696f7b83ede ("scsi: mpt3sas: Implement device_remove_in_progress check in IOCTL path")
Reported-by TOTE Robot <[email protected]>
Signed-off-by Jia-Ju Bai <[email protected]>
--- drivers/scsi/mpt3sas/mpt3sas_base.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/scsi/mpt3sas/mpt3sas_base.c +6 -2
@@ -7806,14 +7806,18 @@ mpt3sas_base_attach(struct MPT3SAS_ADAPTER *ioc) ioc->pend_os_device_add_sz++; ioc->pend_os_device_add =kzalloc (ioc->pend_os_device_add_sz,GFP_KERNEL ); -if (!ioc->pend_os_device_add) +if (!ioc->pend_os_device_add) { + r = -ENOMEM ; goto out_free_resources; + } ioc->device_remove_in_progress_sz = ioc->pend_os_device_add_sz; ioc->device_remove_in_progress =kzalloc (ioc->device_remove_in_progress_sz,GFP_KERNEL ); -if (!ioc->device_remove_in_progress) +if (!ioc->device_remove_in_progress) { + r = -ENOMEM ; goto out_free_resources; + } ioc->fwfault_debug = mpt3sas_fwfault_debug;
Signature · 1 line
2.17.1
Martin K. Petersen
AppliedQuoted 3 lines · Jia-Ju Bai
When
kzalloc()returns NULL, no error return code ofmpt3sas_base_attach()is assigned.
To fix this bug, r is assigned with-ENOMEMin this case.
Applied to 5.12/scsi-fixes, thanks!
[1/1] scsi: mpt3sas: fix error return code of mpt3sas_base_attach()
https://git.kernel.org/mkp/scsi/c/3401ecf7fc1b
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering