resolvconf: add missing dependencies to RDEPENDS
PATCH 1/1 resolvconf: add missing dependencies to RDEPENDS
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.
--- meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1 -1
@@ -9,7 +9,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux" SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://fix-path-for-busybox.patch \
Signature · 1 line
2.30.1
Quoted 19 lines · Khem Raj
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.Signed-off-by Khem Raj <[email protected]>--- meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-0
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb LICENSE = "GPLv2+" · line 12
Quoted 5 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux"
util-linux-flock has its own package.
Patching resolvconf to use readlink -f (instead of readlink -m) should be sufficient to allow it to work with busybox readlink.
Quoted 8 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-1SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://fix-path-for-busybox.patch \ --2.30.1
Quoted 15 lines · Andre McCurdy
Quoted 14 lines · Khem Raj
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.Signed-off-by Khem Raj <[email protected]>--- meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb LICENSE = "GPLv2+" · line 12
Quoted 10 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux"util-linux-flock has its own package.
yeah and busybox also provides flock too. Lets drop it
Quoted 12 lines
Patching resolvconf to use readlink -f (instead of readlink -m) should be sufficient to allow it to work with busybox readlink.
Quoted 8 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-1SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://fix-path-for-busybox.patch \ --2.30.1
Quoted 30 lines · Khem Raj
Quoted 15 lines · Andre McCurdy
Quoted 14 lines · Khem Raj
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.Signed-off-by Khem Raj <[email protected]>--- meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 12 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb LICENSE = "GPLv2+" · line 12
Quoted 10 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux"util-linux-flock has its own package.
Quoted 1 line
yeah and busybox also provides flock too. Lets drop it
Busybox provides flock, but it doesn't support the -w option (wait with timeout). Either the util-linux flock is required or resolvconf needs to be patched to drop the -w option.
Quoted 11 lines
Quoted 11 lines
Patching resolvconf to use readlink -f (instead of readlink -m) should be sufficient to allow it to work with busybox readlink.
Quoted 8 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-1SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://fix-path-for-busybox.patch \ --2.30.1
Quoted 31 lines · Andre McCurdy
Quoted 30 lines · Khem Raj
Quoted 27 lines · Andre McCurdy
Quoted 19 lines · Khem Raj
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.Signed-off-by Khem Raj <[email protected]>--- meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-0meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb LICENSE = "GPLv2+" · line 12
Quoted 5 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux"util-linux-flock has its own package.
Quoted 6 lines
Quoted 1 line
yeah and busybox also provides flock too. Lets drop it
Busybox provides flock, but it doesn't support the -w option (wait with timeout). Either the util-linux flock is required or resolvconf needs to be patched to drop the -w option.
right, its to explore possibilities to avoid the deps.
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Patching resolvconf to use readlink -f (instead of readlink -m) should be sufficient to allow it to work with busybox readlink.
Quoted 8 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-1SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://fix-path-for-busybox.patch \ --2.30.1
Freaking yahoo email seems to have no option any more to quote decently.Guess it is time for a new email provider :-)Anyway my response below prefixed with FM:
Op dinsdag 9 maart 2021 00:26:05 CET schreef Khem Raj <[email protected]>:
Quoted 31 lines · Andre McCurdy
Quoted 30 lines · Khem Raj
Quoted 27 lines · Andre McCurdy
Quoted 22 lines · Khem Raj
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.Signed-off-by Khem Raj <[email protected]>---
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-0@@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
LIC_FILES_CHKSUM= "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood"
HOMEPAGE = "http://packages.debian.org/resolvconf"meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb LICENSE = "GPLv2+" · line 12
Quoted 2 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1
-1-RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux"util-linux-flock has its own package.
Quoted 6 lines
Quoted 1 line
yeah and busybox also provides flock too. Lets drop it
Busybox provides flock, but it doesn't support the -w option (wait with timeout). Either the util-linux flock is required or resolvconf needs to be patched to drop the -w option.
right, its to explore possibilities to avoid the deps.
FM: While I am all in favor of avoiding these dependencies, I'm not versed enough in the resolvconf code to judge the impact of dropping -w, so my preference would be to depend on util-linux-flock.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Patching resolvconf to use readlink -f (instead of readlink -m) should be sufficient to allow it to work with busybox readlink.
FM: this will most likely work. I can make a patch for that, no problem.
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
SRC_URI= "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable\
file://fix-path-for-busybox.patch \
--
2.30.1
On a general note: in the current form the package is broken, so some fix is desirable.
Kind regards, Frans.
Quoted 40 lines · Frans Meulenbroeks
Freaking yahoo email seems to have no option any more to quote decently. Guess it is time for a new email provider :-)
Anyway my response below prefixed with FM:Op dinsdag 9 maart 2021 00:26:05 CET schreef Khem Raj <[email protected]>:
Quoted 33 lines · Andre McCurdy
Quoted 31 lines · Khem Raj
Quoted 15 lines · Andre McCurdy
Quoted 14 lines · Khem Raj
From: Frans Meulenbroeks <[email protected]>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils (for readlink).
Note that the options used with flock and readlink are not part of the busybox implementations so full-fledged implementations are needed.Signed-off-by Khem Raj <[email protected]>--- meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 12 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb LICENSE = "GPLv2+" · line 12
Quoted 10 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +1
-1@@ -9,7 +9,7 @@ LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b" AUTHOR = "Thomas Hood" HOMEPAGE = "http://packages.debian.org/resolvconf" -RDEPENDS_${PN} = "bash" +RDEPENDS_${PN} = "bash coreutils util-linux"util-linux-flock has its own package.
yeah and busybox also provides flock too. Lets drop it
Quoted 7 lines
Quoted 3 lines
Busybox provides flock, but it doesn't support the -w option (wait with timeout). Either the util-linux flock is required or resolvconf needs to be patched to drop the -w option.
right, its to explore possibilities to avoid the deps.
FM: While I am all in favor of avoiding these dependencies, I'm not versed enough in the resolvconf code to judge the impact of dropping -w, so my preference would be to depend on util-linux-flock.
Agreed. Adding a runtime dependency on util-linux-flock is the safest fix.
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Patching resolvconf to use readlink -f (instead of readlink -m) should be sufficient to allow it to work with busybox readlink.
FM: this will most likely work. I can make a patch for that, no problem.
For reference, there's a patch which does that here:
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb +0
-1SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \ file://fix-path-for-busybox.patch \ --2.30.1
On a general note: in the current form the package is broken, so some fix is desirable.
Agreed.