Skip to contentSkip to conversation

io-wq: fix ref leak for req

PATCH New yangerkun 1 participant 1 message Mar 9, 2021

Subsystems (2)
lore
Share & tools
lore

yangerkun

author
#0 lore raw

PATCH 1/1 io-wq: fix ref leak for req

do_work such as io_wq_submit_work that cancel the work will leave ref of req as 1. Fix it by call io_run_cancel.

Fixes 4fb6ac326204 ("io-wq: improve manager/worker handling over exec")
---
 fs/io-wq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/io-wq.c +1 -2
index 28868eb4cd09..0229fed33b99 100644
@@ -794,8 +794,7 @@ static void io_wqe_enqueue(struct io_wqe *wqe, struct io_wq_work *work)
 	/* Can only happen if manager creation fails after exec */
 	if (io_wq_fork_manager(wqe->wq) ||
 	    test_bit(IO_WQ_BIT_EXIT, &wqe->wq->state)) {
-		work->flags |= IO_WQ_WORK_CANCEL;
-		wqe->wq->do_work(work);
+		io_run_cancel(work, wqe);
 		return;
 	}
 
Signature · 1 line
2.25.4