Skip to contentSkip to conversation

tests/kms_cursor_legacy: added test description

PATCH New Nidhi Gupta 2 participants 2 messages Mar 9, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 tests/kms_cursor_legacy: added test description

Added test_describe for all the subtests.

---
 tests/kms_cursor_legacy.c | 156 ++++++++++++++++++++++++--------------
 1 file changed, 97 insertions(+), 59 deletions(-)
tests/kms_cursor_legacy.c +97 -59
index 6034ad04..4723e1ff 100644
@@ -1365,6 +1365,9 @@ igt_main
 		igt_display_require(&display, display.drm_fd);
 	}
 
+	/*Test description for pipe-* and all-pipe-* tests*/
+	igt_describe("Test checks how many cursor updates we can fit between vblanks "
+		     "on single pipe with different modes, priority and number of processes");
 	igt_subtest_group {
 		enum pipe n;
 		for_each_pipe_static(n) {
@@ -1391,68 +1394,90 @@ igt_main
 		}
 	}
 
-	igt_subtest("all-pipes-single-bo")
-		stress(&display, -1, 1, DRM_MODE_CURSOR_BO, 20);
-	igt_subtest("all-pipes-single-move")
-		stress(&display, -1, 1, DRM_MODE_CURSOR_MOVE, 20);
+	/*Test description for pipe-* and all-pipe-* tests*/
+	igt_describe("Test checks how many cursor updates we can fit between vblanks "
+		    "on all pipes with different modes, priority and number of processes");
+	igt_subtest_group {
+
+		igt_subtest("all-pipes-single-bo")
+			stress(&display, -1, 1, DRM_MODE_CURSOR_BO, 20);
+		igt_subtest("all-pipes-single-move")
+			stress(&display, -1, 1, DRM_MODE_CURSOR_MOVE, 20);
+
+		igt_subtest("all-pipes-forked-bo")
+			stress(&display, -1, ncpus, DRM_MODE_CURSOR_BO, 20);
+		igt_subtest("all-pipes-forked-move")
+			stress(&display, -1, ncpus, DRM_MODE_CURSOR_MOVE, 20);
 
-	igt_subtest("all-pipes-forked-bo")
-		stress(&display, -1, ncpus, DRM_MODE_CURSOR_BO, 20);
-	igt_subtest("all-pipes-forked-move")
-		stress(&display, -1, ncpus, DRM_MODE_CURSOR_MOVE, 20);
+		igt_subtest("all-pipes-torture-bo")
+			stress(&display, -1, -ncpus, DRM_MODE_CURSOR_BO, 20);
+		igt_subtest("all-pipes-torture-move")
+			stress(&display, -1, -ncpus, DRM_MODE_CURSOR_MOVE, 20);
 
-	igt_subtest("all-pipes-torture-bo")
-		stress(&display, -1, -ncpus, DRM_MODE_CURSOR_BO, 20);
-	igt_subtest("all-pipes-torture-move")
-		stress(&display, -1, -ncpus, DRM_MODE_CURSOR_MOVE, 20);
+		igt_subtest("nonblocking-modeset-vs-cursor-atomic")
+			nonblocking_modeset_vs_cursor(&display, 1);
+
+		igt_subtest("long-nonblocking-modeset-vs-cursor-atomic")
+			nonblocking_modeset_vs_cursor(&display, 16);
+	}
 
-	igt_subtest("nonblocking-modeset-vs-cursor-atomic")
-		nonblocking_modeset_vs_cursor(&display, 1);
+	/*Test Description for 2x-* tests*/
+	igt_describe("This test executes flips on both CRTCs "
+		     "while running cursor updates in parallel");
+	igt_subtest_group {
 
-	igt_subtest("long-nonblocking-modeset-vs-cursor-atomic")
-		nonblocking_modeset_vs_cursor(&display, 16);
+		igt_subtest("2x-flip-vs-cursor-legacy")
+			two_screens_flip_vs_cursor(&display, 8, false, false);
 
-	igt_subtest("2x-flip-vs-cursor-legacy")
-		two_screens_flip_vs_cursor(&display, 8, false, false);
+		igt_subtest("2x-flip-vs-cursor-atomic")
+			two_screens_flip_vs_cursor(&display, 8, false, true);
 
-	igt_subtest("2x-flip-vs-cursor-atomic")
-		two_screens_flip_vs_cursor(&display, 8, false, true);
+		igt_subtest("2x-cursor-vs-flip-legacy")
+			two_screens_cursor_vs_flip(&display, 8, false);
 
-	igt_subtest("2x-cursor-vs-flip-legacy")
-		two_screens_cursor_vs_flip(&display, 8, false);
+		igt_subtest("2x-long-flip-vs-cursor-legacy")
+			two_screens_flip_vs_cursor(&display, 150, false, false);
 
-	igt_subtest("2x-long-flip-vs-cursor-legacy")
-		two_screens_flip_vs_cursor(&display, 150, false, false);
+		igt_subtest("2x-long-flip-vs-cursor-atomic")
+			two_screens_flip_vs_cursor(&display, 150, false, true);
 
-	igt_subtest("2x-long-flip-vs-cursor-atomic")
-		two_screens_flip_vs_cursor(&display, 150, false, true);
+		igt_subtest("2x-long-cursor-vs-flip-legacy")
+			two_screens_cursor_vs_flip(&display, 50, false);
 
-	igt_subtest("2x-long-cursor-vs-flip-legacy")
-		two_screens_cursor_vs_flip(&display, 50, false);
+		igt_subtest("2x-nonblocking-modeset-vs-cursor-atomic")
+			two_screens_flip_vs_cursor(&display, 4, true, true);
 
-	igt_subtest("2x-nonblocking-modeset-vs-cursor-atomic")
-		two_screens_flip_vs_cursor(&display, 4, true, true);
+		igt_subtest("2x-cursor-vs-flip-atomic")
+			two_screens_cursor_vs_flip(&display, 8, true);
 
-	igt_subtest("2x-cursor-vs-flip-atomic")
-		two_screens_cursor_vs_flip(&display, 8, true);
+		igt_subtest("2x-long-nonblocking-modeset-vs-cursor-atomic")
+			two_screens_flip_vs_cursor(&display, 15, true, true);
 
-	igt_subtest("2x-long-nonblocking-modeset-vs-cursor-atomic")
-		two_screens_flip_vs_cursor(&display, 15, true, true);
+		igt_subtest("2x-long-cursor-vs-flip-atomic")
+			two_screens_cursor_vs_flip(&display, 50, true);
+	}
 
-	igt_subtest("2x-long-cursor-vs-flip-atomic")
-		two_screens_cursor_vs_flip(&display, 50, true);
+	/*Test description for cursor-crc tests*/
+	igt_describe("Test will first does a page flip and then cursor update");
+	igt_subtest_group {
 
-	igt_subtest("flip-vs-cursor-crc-legacy")
-		flip_vs_cursor_crc(&display, false);
+		igt_subtest("flip-vs-cursor-crc-legacy")
+			flip_vs_cursor_crc(&display, false);
 
-	igt_subtest("flip-vs-cursor-crc-atomic")
-		flip_vs_cursor_crc(&display, true);
+		igt_subtest("flip-vs-cursor-crc-atomic")
+			flip_vs_cursor_crc(&display, true);
+	}
 
-	igt_subtest("flip-vs-cursor-busy-crc-legacy")
-		flip_vs_cursor_busy_crc(&display, false);
+	/*Test description for busy-crc tests*/
+	igt_describe("this test perform a busy bo update followed by a cursor update");
+	igt_subtest_group {
 
-	igt_subtest("flip-vs-cursor-busy-crc-atomic")
-		flip_vs_cursor_busy_crc(&display, true);
+		igt_subtest("flip-vs-cursor-busy-crc-legacy")
+			flip_vs_cursor_busy_crc(&display, false);
+
+		igt_subtest("flip-vs-cursor-busy-crc-atomic")
+			flip_vs_cursor_busy_crc(&display, true);
+	}
 
 	for (i = 0; i <= flip_test_last; i++) {
 		const char *modes[flip_test_last+1] = {
@@ -1474,6 +1499,12 @@ igt_main
 		default: break;
 		}
 
+	igt_describe("Adds variety of tests: "
+		     "varying-size: change the size of cursor b/w 64*64 to maxw x maxh. "
+		     "atomic-transition: alternates between a full screen sprite plane. "
+						"and full screen primary plane. "
+		     "toggle: which toggles cursor visibility and make sure cursor moves between updates.");
+	igt_subtest_group {
 		igt_subtest_f("%sflip-before-cursor-%s", prefix, modes[i])
 			basic_flip_cursor(&display, i, FLIP_BEFORE_CURSOR, 0);
 
@@ -1484,27 +1515,34 @@ igt_main
 						  BASIC_BUSY);
 			}
 		}
+	}
 
-		igt_subtest_f("%sflip-after-cursor-%s", prefix, modes[i])
-			basic_flip_cursor(&display, i, FLIP_AFTER_CURSOR, 0);
+		igt_describe("The essence of the basic test is that neither the cursor nor the "
+			     "nonblocking flip stall the application of the next");
+		igt_subtest_group {
 
-		igt_subtest_f("flip-vs-cursor-%s", modes[i])
-			flip_vs_cursor(&display, i, 150);
-		igt_subtest_f("cursor-vs-flip-%s", modes[i])
-			cursor_vs_flip(&display, i, 50);
+			igt_subtest_f("%sflip-after-cursor-%s", prefix, modes[i])
+				basic_flip_cursor(&display, i, FLIP_AFTER_CURSOR, 0);
 
-		igt_subtest_f("cursorA-vs-flipA-%s", modes[i])
-			flip(&display, 0, 0, 10, i);
+			igt_subtest_f("flip-vs-cursor-%s", modes[i])
+				flip_vs_cursor(&display, i, 150);
 
-		igt_subtest_f("cursorA-vs-flipB-%s", modes[i])
-			flip(&display, 0, 1, 10, i);
+			igt_subtest_f("cursor-vs-flip-%s", modes[i])
+				cursor_vs_flip(&display, i, 50);
 
-		igt_subtest_f("cursorB-vs-flipA-%s", modes[i])
-			flip(&display, 1, 0, 10, i);
+			igt_subtest_f("cursorA-vs-flipA-%s", modes[i])
+				flip(&display, 0, 0, 10, i);
 
-		igt_subtest_f("cursorB-vs-flipB-%s", modes[i])
-			flip(&display, 1, 1, 10, i);
-	}
+			igt_subtest_f("cursorA-vs-flipB-%s", modes[i])
+				flip(&display, 0, 1, 10, i);
+
+			igt_subtest_f("cursorB-vs-flipA-%s", modes[i])
+				flip(&display, 1, 0, 10, i);
+
+			igt_subtest_f("cursorB-vs-flipB-%s", modes[i])
+				flip(&display, 1, 1, 10, i);
+			}
+		}
 
 	igt_fixture {
 		igt_display_fini(&display);
Signature · 6 lines
2.26.2

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: added test description (rev5)

== Series Details ==

== Series Details ==

Series: tests/kms_cursor_legacy: added test description (rev5)
URL : https://patchwork.freedesktop.org/series/86430/
State : success

== Summary ==

CI Bug Log - changes from IGT_6027 -> IGTPW_5583
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/index.html

Known issues
------------

Here are the changes found in IGTPW_5583 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/fi-bsw-nick/igt@amdgpu/[email protected]

* igt@gem_exec_gttfill@basic:
- fi-kbl-8809g: [PASS][2] -> [TIMEOUT][3] ([i915#3145])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6027/fi-kbl-8809g/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/fi-kbl-8809g/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][4] -> [INCOMPLETE][5] ([i915#2782])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6027/fi-snb-2600/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][6] ([i915#1602] / [i915#2029] / [i915#2369])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/fi-bdw-5557u/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-nick: [DMESG-FAIL][7] ([i915#2927]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6027/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145

Participating hosts (46 -> 41)
------------------------------

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6027 -> IGTPW_5583

CI-20190529: 20190529
CI_DRM_9842: 1c2e0e8e88b495547c87064738ef1d13f8bef6ff @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5583: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/index.html
IGT_6027: b8b3facdfbb99a0b9ef5f541a0ee7d6bca2aafea @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5583/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev