sched : Initialize tc ov watermark.

PATCH Superseded Savinay Dharmappa 5 participants 11 messages Mar 9, 2021 – Apr 21, 2021

lore

Share & tools

lore

Savinay Dharmappa

author

2021-03-09 16:03 UTC #0 lore raw

PATCH 1/1 sched : Initialize tc ov watermark.

tc ov watermark is intialized with computed value of max tc ov watermark.

Signed-off-by Savinay Dharmappa <[email protected]>

---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/librte_sched/rte_sched.c +1 -1

index 7c56880681..cd87e688e4 100644
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		/* TC oversubscription */
 		s->tc_ov_wm_min = port->mtu;
-		s->tc_ov_wm = s->tc_ov_wm_max;
 		s->tc_ov_period_id = 0;
 		s->tc_ov = 0;
 		s->tc_ov_n = 0;

@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile->tc_period,
 							s->pipe_tc_be_rate_max);
+		s->tc_ov_wm = s->tc_ov_wm_max;
 #endif
 		s->profile = subport_profile_id;

Signature · 1 line

2.17.1

Savinay Dharmappa

author

2021-03-09 16:11 UTC #1 lore raw

PATCH v2 1/1 sched : Initialize tc ov watermark.

tc ov watermark is initialized with computed value of max tc ov watermark.

Signed-off-by Savinay Dharmappa <[email protected]>

---
v2: fix spelling error.

---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/librte_sched/rte_sched.c +1 -1

index 7c56880681..cd87e688e4 100644
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		/* TC oversubscription */
 		s->tc_ov_wm_min = port->mtu;
-		s->tc_ov_wm = s->tc_ov_wm_max;
 		s->tc_ov_period_id = 0;
 		s->tc_ov = 0;
 		s->tc_ov_n = 0;

@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile->tc_period,
 							s->pipe_tc_be_rate_max);
+		s->tc_ov_wm = s->tc_ov_wm_max;
 #endif
 		s->profile = subport_profile_id;

Signature · 1 line

2.17.1

Singh, Jasvinder

Acked-by on v2 1/1

2021-03-10 16:54 UTC #2 lore raw

Quoted 41 lines

-----Original Message-----
From: Dharmappa, Savinay <[email protected]>
Sent: Tuesday, March 9, 2021 4:10 PM
To: Singh, Jasvinder <[email protected]>; Dumitrescu, Cristian <[email protected]>; [email protected]
Cc: Dharmappa, Savinay <[email protected]>
Subject: [PATCH v2] sched : Initialize tc ov watermark.
tc ov watermark is initialized with computed value of max tc ov watermark.
Signed-off-by Savinay Dharmappa <[email protected]>
---
v2: fix spelling error.
---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_sched/rte_sched.c index renamed from lib/librte_sched/rte_sched.c +0 -0
7c56880681..cd87e688e4 100644
lib/librte_sched/rte_sched.c +1 -1
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
 *port,  #ifdef RTE_SCHED_SUBPORT_TC_OV
 		/* TC oversubscription */
 		s->tc_ov_wm_min = port->mtu;
-		s->tc_ov_wm = s->tc_ov_wm_max;
 		s->tc_ov_period_id = 0;
 		s->tc_ov = 0;
 		s->tc_ov_n = 0;
@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
 *port,  #ifdef RTE_SCHED_SUBPORT_TC_OV
 		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
 >tc_period,
 							s-
 >pipe_tc_be_rate_max);
+		s->tc_ov_wm = s->tc_ov_wm_max;
 #endif
s->profile = subport_profile_id;

Quoted 2 lines

--
2.17.1

Acked-by Jasvinder Singh <[email protected]>

Coyle, David

Tested-by on v2 1/1

2021-03-15 16:42 UTC #3 lore raw

In reply to Savinay Dharmappa

Quoted 9 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Savinay Dharmappa
Sent: Tuesday, March 9, 2021 4:10 PM
To: Singh, Jasvinder <[email protected]>; Dumitrescu, Cristian <[email protected]>; [email protected]
Cc: Dharmappa, Savinay <[email protected]>
Subject: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

Quoted 9 lines

tc ov watermark is initialized with computed value of max tc ov watermark.
Signed-off-by Savinay Dharmappa <[email protected]>
---
v2: fix spelling error.
---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Tested-by David Coyle <[email protected]>

Thomas Monjalon

2021-03-23 16:02 UTC #4 lore raw

In reply to Savinay Dharmappa

09/03/2021 17:10, Savinay Dharmappa:

Quoted 2 lines

tc ov watermark is initialized with computed value of max tc ov watermark.

Sorry I don't understand what the change is doing. Was there an issue?

In the title, please avoid "tc ov" which is meaningless for most of readers I guess.

Quoted 3 lines

lib/librte_sched/rte_sched.c +0 -1
-		s->tc_ov_wm = s->tc_ov_wm_max;

[...]

Quoted 1 line

lib/librte_sched/rte_sched.c +1 -0
+		s->tc_ov_wm = s->tc_ov_wm_max;

Thomas Monjalon

2021-04-20 10:13 UTC #5 lore raw

Ping

23/03/2021 17:02, Thomas Monjalon:

Quoted 9 lines

09/03/2021 17:10, Savinay Dharmappa:
Quoted 2 lines
tc ov watermark is initialized with computed value of max tc ov watermark.
Sorry I don't understand what the change is doing. Was there an issue?
In the title, please avoid "tc ov" which is meaningless for most of readers I guess.

Singh, Jasvinder

2021-04-20 10:36 UTC #6 lore raw

Quoted 11 lines

-----Original Message-----
From: Thomas Monjalon <[email protected]>
Sent: Tuesday, April 20, 2021 11:14 AM
To: Dharmappa, Savinay <[email protected]>; Singh, Jasvinder <[email protected]>; Dumitrescu, Cristian <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

Quoted 14 lines

Ping
23/03/2021 17:02, Thomas Monjalon:
Quoted 9 lines
09/03/2021 17:10, Savinay Dharmappa:
Quoted 2 lines
tc ov watermark is initialized with computed value of max tc ov watermark.
Sorry I don't understand what the change is doing. Was there an issue?
In the title, please avoid "tc ov" which is meaningless for most of readers I guess.

Hi Thomas,

This is a fix for oversubscription threshold value of traffic class which is computed later. We will re-spin the patch by mentioning "fix" in the message and title.

Thanks,
Jasvinder

Thomas Monjalon

2021-04-20 13:54 UTC #7 lore raw

20/04/2021 12:36, Singh, Jasvinder:

Quoted 12 lines

From: Thomas Monjalon <[email protected]>
Quoted 11 lines
Ping
23/03/2021 17:02, Thomas Monjalon:
Quoted 7 lines
09/03/2021 17:10, Savinay Dharmappa:
Quoted 2 lines
tc ov watermark is initialized with computed value of max tc ov watermark.
Sorry I don't understand what the change is doing. Was there an issue?

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
In the title, please avoid "tc ov" which is meaningless for most of readers I guess.
Hi Thomas,
This is a fix for oversubscription threshold value of traffic class which is computed later. We will re-spin the patch by mentioning "fix" in the message and title.

Yes please give a clear explanation with full words, thanks.

Savinay Dharmappa

author

2021-04-21 06:50 UTC #8 lore raw

PATCH v3 1/1 sched : fix traffic class oversubscription parameter

In reply to Savinay Dharmappa

This patch fixes the traffic class oversubscription watermark value by initialising it with computed value of maximum watermark.

Fixes ac6fcb841b0f ("sched: update subport rate dynamically")

Cc [email protected]

Signed-off-by Savinay Dharmappa <[email protected]>

Acked-by Jasvinder Singh <[email protected]>

---
v3: update the title.

---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

lib/librte_sched/rte_sched.c +1 -1

index 7c56880681..cd87e688e4 100644
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		/* TC oversubscription */
 		s->tc_ov_wm_min = port->mtu;
-		s->tc_ov_wm = s->tc_ov_wm_max;
 		s->tc_ov_period_id = 0;
 		s->tc_ov = 0;
 		s->tc_ov_n = 0;

@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile->tc_period,
 							s->pipe_tc_be_rate_max);
+		s->tc_ov_wm = s->tc_ov_wm_max;
 #endif
 		s->profile = subport_profile_id;

Signature · 1 line

2.17.1

Thomas Monjalon

Applied

2021-04-21 14:54 UTC #9 lore raw

Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter

21/04/2021 08:50, Savinay Dharmappa:

Quoted 8 lines

This patch fixes the traffic class oversubscription watermark value by initialising it with computed value of maximum watermark.
Fixes ac6fcb841b0f ("sched: update subport rate dynamically")
Cc [email protected]
Signed-off-by Savinay Dharmappa <[email protected]>
Acked-by Jasvinder Singh <[email protected]>

Applied, thanks

Dumitrescu, Cristian

Acked-by on v3 1/1

2021-04-21 15:24 UTC #10 lore raw

Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter

In reply to Savinay Dharmappa

Quoted 48 lines

-----Original Message-----
From: Dharmappa, Savinay <[email protected]>
Sent: Wednesday, April 21, 2021 7:50 AM
To: [email protected]; Singh, Jasvinder <[email protected]>; Dumitrescu, Cristian <[email protected]>
Cc: Dharmappa, Savinay <[email protected]>; [email protected]
Subject: [PATCH v3] sched : fix traffic class oversubscription parameter
This patch fixes the traffic class oversubscription watermark value by initialising it with computed value of maximum watermark.
Fixes ac6fcb841b0f ("sched: update subport rate dynamically")
Cc [email protected]
Signed-off-by Savinay Dharmappa <[email protected]>
Acked-by Jasvinder Singh <[email protected]>
---
v3: update the title.
---
 lib/librte_sched/rte_sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_sched/rte_sched.c +0 -1
index 7c56880681..cd87e688e4 100644
@@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port
 *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		/* TC oversubscription */
 		s->tc_ov_wm_min = port->mtu;
-		s->tc_ov_wm = s->tc_ov_wm_max;
 		s->tc_ov_period_id = 0;
 		s->tc_ov = 0;
lib/librte_sched/rte_sched.c +1 -0
 		s->tc_ov_n = 0;
@@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port
 *port,
 #ifdef RTE_SCHED_SUBPORT_TC_OV
 		s->tc_ov_wm_max = rte_sched_time_ms_to_bytes(profile-
 >tc_period,
 							s-
 >pipe_tc_be_rate_max);
+		s->tc_ov_wm = s->tc_ov_wm_max;
#endif
s->profile = subport_profile_id;

Quoted 2 lines

--
2.17.1

Acked-by Cristian Dumitrescu <[email protected]>