xfs: ensure xfs_errortag_random_default matches XFS_ERRTAG_MAX
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 xfs: ensure xfs_errortag_random_default matches XFS_ERRTAG_MAX
From: Gao Xiang <[email protected]>
Add the BUILD_BUG_ON to xfs_errortag_add() in order to make sure that the length of xfs_errortag_random_default matches XFS_ERRTAG_MAX when building.
Signed-off-by Gao Xiang <[email protected]>
--- fs/xfs/xfs_error.c | 1 + 1 file changed, 1 insertion(+)
fs/xfs/xfs_error.c +1 -0
@@ -299,6 +299,7 @@ xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag) { + BUILD_BUG_ON(ARRAY_SIZE(xfs_errortag_random_default) != XFS_ERRTAG_MAX);if (error_tag >=XFS_ERRTAG_MAX )return -EINVAL ;
Signature · 1 line
2.20.1
Quoted 7 lines · Gao Xiang
From: Gao Xiang <[email protected]>
Add the
BUILD_BUG_ONtoxfs_errortag_add()in order to make sure that the length ofxfs_errortag_random_defaultmatchesXFS_ERRTAG_MAXwhen building.Signed-off-by Gao Xiang <[email protected]>
Yay!
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 19 lines
--- fs/xfs/xfs_error.c | 1 + 1 file changed, 1 insertion(+)fs/xfs/xfs_error.c +1
-0@@ -299,6 +299,7 @@ xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag) { + BUILD_BUG_ON(ARRAY_SIZE(xfs_errortag_random_default) != XFS_ERRTAG_MAX);if (error_tag >=XFS_ERRTAG_MAX )return -EINVAL ;Signature · 1 line
2.20.1
Looks good,
Reviewed-by Christoph Hellwig <[email protected]>