Skip to contentSkip to conversation

dt-bindings: at25: add Fujitsu MB85RS4MT

PATCH In review Tim Harvey 4 participants 9 messages Mar 9, 2021 – Mar 16, 2021

Subsystems (4)
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/4 dt-bindings: at25: add Fujitsu MB85RS4MT

Document the compatible value for the Fujitsu MB85RS4MT SPI FRAM EEPROM device so that it can be used in DTS files.

This is a 512KiB FRAM EEPROM.

---
 Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at25.yaml +1 -0
index 6a2dc8b3ed14..f594db72b711 100644
@@ -26,6 +26,7 @@ properties:
               - anvo,anv32e61w
               - atmel,at25256B
               - fujitsu,mb85rs1mt
+              - fujitsu,mb85rs4mt
               - fujitsu,mb85rs64
               - microchip,at25160bn
               - microchip,25lc040
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
author
#1 lore raw

PATCH 2/4 mtd: spi-nor: fujitsu: add support for MB85RS4MT

Add support for the Fujitsu MB85RS4MT SPI FRAM EEPROM device.

This is a 512KiB FRAM EEPROM.

---
 drivers/mtd/spi-nor/fujitsu.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi-nor/fujitsu.c +1 -0
index e385d93e756c..9df5d0576cea 100644
@@ -11,6 +11,7 @@
 static const struct flash_info fujitsu_parts[] = {
 	/* Fujitsu */
 	{ "mb85rs1mt", INFO(0x047f27, 0, 128 * 1024, 1, SPI_NOR_NO_ERASE) },
+	{ "mb85rs4mt", INFO(0x047f49, 0, 512 * 1024, 1, SPI_NOR_NO_ERASE) },
 };
 
 const struct spi_nor_manufacturer spi_nor_fujitsu = {
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
author
#2 lore raw

PATCH 3/4 dt-bindings: arm: imx: add imx8mm gw7901 support

In reply to Tim Harvey

The Gateworks GW7901 is an ARM based single board computer (SBC) featuring:
- i.MX8M Mini SoC
- LPDDR4 DRAM
- eMMC FLASH
- SPI FRAM
- Gateworks System Controller (GSC)
- Atmel ATECC Crypto Authentication
- USB 2.0
- Microchip GbE Switch
- Multiple multi-protocol RS232/RS485/RS422 Serial ports
- onboard 802.11ac WiFi / BT
- microSD socket
- miniPCIe socket with PCIe, USB 2.0 and dual SIM sockets
- Wide range DC power input
- 802.3at PoE

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 297c87f45db8..9af86ce3142d 100644
@@ -684,6 +684,7 @@ properties:
               - gw,imx8mm-gw71xx-0x       # i.MX8MM Gateworks Development Kit
               - gw,imx8mm-gw72xx-0x       # i.MX8MM Gateworks Development Kit
               - gw,imx8mm-gw73xx-0x       # i.MX8MM Gateworks Development Kit
+              - gw,imx8mm-gw7901          # i.MX8MM Gateworks Board
               - kontron,imx8mm-n801x-som  # i.MX8MM Kontron SL (N801X) SOM
               - variscite,var-som-mx8mm   # i.MX8MM Variscite VAR-SOM-MX8MM module
           - const: fsl,imx8mm
Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
maintainer Acked-by on v1 3/4
#3 lore raw

Re: [PATCH 3/4] dt-bindings: arm: imx: add imx8mm gw7901 support

Quoted 17 lines · Tim Harvey

The Gateworks GW7901 is an ARM based single board computer (SBC) featuring:
- i.MX8M Mini SoC
- LPDDR4 DRAM
- eMMC FLASH
- SPI FRAM
- Gateworks System Controller (GSC)
- Atmel ATECC Crypto Authentication
- USB 2.0
- Microchip GbE Switch
- Multiple multi-protocol RS232/RS485/RS422 Serial ports
- onboard 802.11ac WiFi / BT
- microSD socket
- miniPCIe socket with PCIe, USB 2.0 and dual SIM sockets
- Wide range DC power input
- 802.3at PoE

Quoted 5 lines
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)
author
#4 lore raw

PATCH 4/4 arm64: dts: imx: Add i.mx8mm Gateworks gw7901 dts support

In reply to Tim Harvey

The Gateworks GW7901 is an ARM based single board computer (SBC) featuring:
- i.MX8M Mini SoC
- LPDDR4 DRAM
- eMMC FLASH
- SPI FRAM
- Gateworks System Controller (GSC)
- Atmel ATECC Crypto Authentication
- USB 2.0
- Microchip GbE Switch
- Multiple multi-protocol RS232/RS485/RS422 Serial ports
- onboard 802.11ac WiFi / BT
- microSD socket
- miniPCIe socket with PCIe, USB 2.0 and dual SIM sockets
- Wide range DC power input
- 802.3at PoE

---
 arch/arm64/boot/dts/freescale/Makefile        |    1 +
 .../dts/freescale/imx8mm-venice-gw7901.dts    | 1008 +++++++++++++++++
 2 files changed, 1009 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
arch/arm64/boot/dts/freescale/Makefile +1 -0
index 6438db3822f8..2a93323a7d3e 100644
@@ -39,6 +39,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mm-var-som-symphony.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw71xx-0x.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw72xx-0x.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw73xx-0x.dtb
+dtb-$(CONFIG_ARCH_MXC) += imx8mm-venice-gw7901.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-beacon-kit.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-evk.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx8mn-ddr4-evk.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts new file +1008 -0

1,008 lines not on this page · raw message

Signature · 6 lines
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#5 lore raw
In reply to Tim Harvey

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:

Quoted 16 lines

Document the compatible value for the Fujitsu MB85RS4MT SPI FRAM EEPROM device so that it can be used in DTS files.

This is a 512KiB FRAM EEPROM.

---
 Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at25.yaml +0 -0
index 6a2dc8b3ed14..f594db72b711 100644

Documentation/devicetree/bindings/eeprom/at25.yaml properties: · line 32

Quoted 7 lines
Documentation/devicetree/bindings/eeprom/at25.yaml +1 -0
@@ -26,6 +26,7 @@ properties:
               - anvo,anv32e61w
               - atmel,at25256B
               - fujitsu,mb85rs1mt
+              - fujitsu,mb85rs4mt
               - fujitsu,mb85rs64
               - microchip,at25160bn
               - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is this correct? Doesn't it work if you just add the ID to spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

-michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#6 lore raw
Quoted 24 lines · Michael Walle

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:

Quoted 19 lines

Document the compatible value for the Fujitsu MB85RS4MT SPI FRAM EEPROM device so that it can be used in DTS files.

This is a 512KiB FRAM EEPROM.

---
 Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +

 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at25.yaml +0 -0
index 6a2dc8b3ed14..f594db72b711 100644
@@ -26,6 +26,7 @@ properties:

               - anvo,anv32e61w
               - atmel,at25256B
               - fujitsu,mb85rs1mt

Quoted 9 lines
Quoted 4 lines

+              - fujitsu,mb85rs4mt
               - fujitsu,mb85rs64
               - microchip,at25160bn
               - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is this correct? Doesn't it work if you just add the ID to spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

Tim,

Can you try and see if you can work with this flash by setting "atmel,at25" compatible?

There are some SPI NOR-like flashes MRAMs, FRAMs, even EEPROMs, that share a part of opcodes of SPI NORs, but have slightly different characteristics (ex. no erase, no wait times for writes on FRAMs).
See the patch series submitted by Richard, that I have stalled:
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=208584&state=*

I now have time to allocate for this, I'll study all and come up with a proposal in one or two weeks.

Cheers,
ta

author
#7 lore raw
Quoted 36 lines · 'On Tue, Mar 9, 2021 at 9:34 PM <[email protected]> wrote:
Quoted 24 lines · Michael Walle

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:

Quoted 19 lines

Document the compatible value for the Fujitsu MB85RS4MT SPI FRAM EEPROM device so that it can be used in DTS files.

This is a 512KiB FRAM EEPROM.

---
 Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at25.yaml +0 -0
index 6a2dc8b3ed14..f594db72b711 100644
@@ -26,6 +26,7 @@ properties:
               - anvo,anv32e61w
               - atmel,at25256B
               - fujitsu,mb85rs1mt
Quoted 9 lines

Documentation/devicetree/bindings/eeprom/at25.yaml properties: · line 32

Quoted 4 lines
Documentation/devicetree/bindings/eeprom/at25.yaml +1 -0
+              - fujitsu,mb85rs4mt
               - fujitsu,mb85rs64
               - microchip,at25160bn
               - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is this correct? Doesn't it work if you just add the ID to spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

Quoted 4 lines

Tim,

Can you try and see if you can work with this flash by setting "atmel,at25" compatible?

It does not work with 'atmel,at25'. I was fooled into adding it to at25.yaml because that is where the mb85rs1mt compatible was. I suppose at some time the drivers were split as mb85rs1mt is clearly in the spi-nor driver now.

I will drop the patch to at25.yaml and now that I realize all I need is 'jedec,spi-nor' I won't need any bindings patch.

Quoted 7 lines

There are some SPI NOR-like flashes MRAMs, FRAMs, even EEPROMs, that share a part of opcodes of SPI NORs, but have slightly different characteristics (ex. no erase, no wait times for writes on FRAMs).
See the patch series submitted by Richard, that I have stalled:
https://patchwork.ozlabs.org/project/linux-mtd/list/?series=208584&state=*

This series makes sense to me. I tested it and indeed it provides a vast performance improvement. Richards patch would collide with my patch that adds the mb85rs4mt detection. Let me know what you're going to do there and if you need me to rebase 'mtd: spi-nor: fujitsu: add support for MB85RS4MT' on top of it.

Best regards,

Tim

author
#8 lore raw
In reply to Michael Walle
Quoted 23 lines · Michael Walle

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:

Quoted 19 lines

Document the compatible value for the Fujitsu MB85RS4MT SPI FRAM EEPROM device so that it can be used in DTS files.

This is a 512KiB FRAM EEPROM.

---
 Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/eeprom/at25.yaml +0 -0
index 6a2dc8b3ed14..f594db72b711 100644
@@ -26,6 +26,7 @@ properties:
               - anvo,anv32e61w
               - atmel,at25256B
               - fujitsu,mb85rs1mt
Quoted 9 lines

Documentation/devicetree/bindings/eeprom/at25.yaml properties: · line 32

Quoted 4 lines
Documentation/devicetree/bindings/eeprom/at25.yaml +1 -0
+              - fujitsu,mb85rs4mt
               - fujitsu,mb85rs64
               - microchip,at25160bn
               - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is this correct? Doesn't it work if you just add the ID to spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

Michael,

Yes it works just fine as 'compatible = "jedec,spi-nor"' and that makes sense. I'll drop this patch and update my device-tree accordingly.

Thanks,

Tim

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/