Skip to contentSkip to conversation

net/i40e: fix parse ptype issue for NEON vector

PATCH Applied Feifei Wang 3 participants 3 messages Mar 10, 2021 – Mar 25, 2021 Network drivers

lore
Share & tools
lore

Feifei Wang

author
#0 lore raw

PATCH 1/1 net/i40e: fix parse ptype issue for NEON vector

In i40e NEON vector rx path, the packet descs processing is incorrect. This caused wrong packet type been filled in mbuf.

To fix this, when shifting the pktlen field to be 16-bit aligned, it only needs to process the high 16bit of the packet descs instead of the high 32bit.

Test Results:
Architecture: arm64
NIC: XL710
Driver: i40e
Package: Ether()/IP()/

Without this patch:
desc_to_ptype_v: ptype = 7 (error)

With this patch:
desc_to_ptype_v: ptype = 23 (correct)

Fixes ae0eb310f253 ("net/i40e: implement vector PMD for ARM")
Cc [email protected]
Signed-off-by Feifei Wang <[email protected]>
Reviewed-by Ruifeng Wang <[email protected]>
---
 drivers/net/i40e/i40e_rxtx_vec_neon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)
drivers/net/i40e/i40e_rxtx_vec_neon.c +16 -4
index d81269624..ada82a14d 100644
@@ -310,10 +310,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq,
 		/* pkt 3,4 shift the pktlen field to be 16-bit aligned*/
 		uint32x4_t len3 = vshlq_u32(vreinterpretq_u32_u64(descs[3]),
 					    len_shl);
-		descs[3] = vreinterpretq_u64_u32(len3);
+		descs[3] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len3), 7),
+				 vreinterpretq_u16_u64(descs[3]),
+				 7));
 		uint32x4_t len2 = vshlq_u32(vreinterpretq_u32_u64(descs[2]),
 					    len_shl);
-		descs[2] = vreinterpretq_u64_u32(len2);
+		descs[2] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len2), 7),
+				 vreinterpretq_u16_u64(descs[2]),
+				 7));
 
 		/* D.1 pkt 3,4 convert format from desc to pktmbuf */
 		pkt_mb4 = vqtbl1q_u8(vreinterpretq_u8_u64(descs[3]), shuf_msk);

@@ -341,10 +347,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq,
 		/* pkt 1,2 shift the pktlen field to be 16-bit aligned*/
 		uint32x4_t len1 = vshlq_u32(vreinterpretq_u32_u64(descs[1]),
 					    len_shl);
-		descs[1] = vreinterpretq_u64_u32(len1);
+		descs[1] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len1), 7),
+				 vreinterpretq_u16_u64(descs[1]),
+				 7));
 		uint32x4_t len0 = vshlq_u32(vreinterpretq_u32_u64(descs[0]),
 					    len_shl);
-		descs[0] = vreinterpretq_u64_u32(len0);
+		descs[0] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len0), 7),
+				 vreinterpretq_u16_u64(descs[0]),
+				 7));
 
 		/* D.1 pkt 1,2 convert format from desc to pktmbuf */
 		pkt_mb2 = vqtbl1q_u8(vreinterpretq_u8_u64(descs[1]), shuf_msk);
Signature · 1 line
2.25.1
Tested-by on v1 1/1
#1 lore raw
Tested-by Kathleen Capella <[email protected]>
Quoted 89 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Feifei Wang
Sent: Tuesday, March 9, 2021 9:40 PM
To: [email protected]; Ruifeng Wang <[email protected]>; Beilei Xing <[email protected]>; Jeff Guo <[email protected]>; Bruce Richardson <[email protected]>; Jianbo Liu <[email protected]>
Cc: [email protected]; nd <[email protected]>; Feifei Wang <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector

In i40e NEON vector rx path, the packet descs processing is incorrect. This caused wrong packet type been filled in mbuf.

To fix this, when shifting the pktlen field to be 16-bit aligned, it only needs to process the high 16bit of the packet descs instead of the high 32bit.

Test Results:
Architecture: arm64
NIC: XL710
Driver: i40e
Package: Ether()/IP()/

Without this patch:
desc_to_ptype_v: ptype = 7 (error)

With this patch:
desc_to_ptype_v: ptype = 23 (correct)

Fixes ae0eb310f253 ("net/i40e: implement vector PMD for ARM")
Cc [email protected]
Signed-off-by Feifei Wang <[email protected]>
Reviewed-by Ruifeng Wang <[email protected]>
---
 drivers/net/i40e/i40e_rxtx_vec_neon.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)
drivers/net/i40e/i40e_rxtx_vec_neon.c +8 -2
index d81269624..ada82a14d 100644
@@ -310,10 +310,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue
 *__rte_restrict rxq,
 		/* pkt 3,4 shift the pktlen field to be 16-bit aligned*/
 		uint32x4_t len3 = vshlq_u32(vreinterpretq_u32_u64(descs[3]),
 					    len_shl);
-		descs[3] = vreinterpretq_u64_u32(len3);
+		descs[3] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len3),
 7),
+				 vreinterpretq_u16_u64(descs[3]),
+				 7));
 		uint32x4_t len2 = vshlq_u32(vreinterpretq_u32_u64(descs[2]),
 					    len_shl);
-		descs[2] = vreinterpretq_u64_u32(len2);
+		descs[2] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len2),
 7),
+				 vreinterpretq_u16_u64(descs[2]),
+				 7));
drivers/net/i40e/i40e_rxtx_vec_neon.c +0 -0
 		/* D.1 pkt 3,4 convert format from desc to pktmbuf */
 		pkt_mb4 = vqtbl1q_u8(vreinterpretq_u8_u64(descs[3]),

shuf_msk); @@ -341,10 +347,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq,

drivers/net/i40e/i40e_rxtx_vec_neon.c +2 -1
 		/* pkt 1,2 shift the pktlen field to be 16-bit aligned*/
 		uint32x4_t len1 = vshlq_u32(vreinterpretq_u32_u64(descs[1]),
 					    len_shl);
-		descs[1] = vreinterpretq_u64_u32(len1);
+		descs[1] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len1),

7),

drivers/net/i40e/i40e_rxtx_vec_neon.c +4 -1
+				 vreinterpretq_u16_u64(descs[1]),
+				 7));
 		uint32x4_t len0 = vshlq_u32(vreinterpretq_u32_u64(descs[0]),
 					    len_shl);
-		descs[0] = vreinterpretq_u64_u32(len0);
+		descs[0] = vreinterpretq_u64_u16(vsetq_lane_u16
+				(vgetq_lane_u16(vreinterpretq_u16_u32(len0),

7),

drivers/net/i40e/i40e_rxtx_vec_neon.c +2 -0
+				 vreinterpretq_u16_u64(descs[0]),
+				 7));
 
 		/* D.1 pkt 1,2 convert format from desc to pktmbuf */
 		pkt_mb2 = vqtbl1q_u8(vreinterpretq_u8_u64(descs[1]),

shuf_msk);
--
2.25.1

Applied
#2 lore raw
Quoted 29 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Kathleen Capella
Sent: Thursday, March 11, 2021 3:51 AM
To: Feifei Wang <[email protected]>; [email protected]; Ruifeng Wang <[email protected]>; Xing, Beilei <[email protected]>; Guo, Jia <[email protected]>; Richardson, Bruce <[email protected]>; Jianbo Liu <[email protected]>
Cc: [email protected]; nd <[email protected]>; Feifei Wang <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector

Tested-by Kathleen Capella <[email protected]>
Quoted 8 lines

-----Original Message-----
From: dev <[email protected]> On Behalf Of Feifei Wang
Sent: Tuesday, March 9, 2021 9:40 PM
To: [email protected]; Ruifeng Wang <[email protected]>; Beilei Xing <[email protected]>; Jeff Guo <[email protected]>; Bruce Richardson <[email protected]>; Jianbo Liu <[email protected]>
Cc: [email protected]; nd <[email protected]>; Feifei Wang

<[email protected]>;

Quoted 4 lines

[email protected]
Subject: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector

Quoted 24 lines
Quoted 5 lines

In i40e NEON vector rx path, the packet descs processing is incorrect. This caused wrong packet type been filled in mbuf.

To fix this, when shifting the pktlen field to be 16-bit aligned, it only needs to process the high 16bit of the packet descs instead of the high

32bit.

Quoted 18 lines

Test Results:
Architecture: arm64
NIC: XL710
Driver: i40e
Package: Ether()/IP()/

Without this patch:
desc_to_ptype_v: ptype = 7 (error)

With this patch:
desc_to_ptype_v: ptype = 23 (correct)

Fixes ae0eb310f253 ("net/i40e: implement vector PMD for ARM")
Cc [email protected]
Signed-off-by Feifei Wang <[email protected]>
Reviewed-by Ruifeng Wang <[email protected]>

Applied to dpdk-next-net-intel.

Thanks
Qi