examples/packet_ordering: use local port config
PATCH 1/1 examples/packet_ordering: use local port config
From: Dapeng Yu <[email protected]>
A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be enabled on port.
This patch use this local variable as input of rte_eth_dev_configure().
--- examples/packet_ordering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/packet_ordering/main.c +1 -1
@@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id)if (dev_info.tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE ) port_conf.txmode.offloads |=DEV_TX_OFFLOAD_MBUF_FAST_FREE ; - ret =rte_eth_dev_configure (port_id, rxRings, txRings, &port_conf_default); + ret =rte_eth_dev_configure (port_id, rxRings, txRings, &port_conf);if (ret !=0 )return ret;
Signature · 1 line
2.27.0
Quoted 8 lines
-----Original Message-----
From: [email protected] <[email protected]>Fixes 6833f919f56b ("examples/packet_ordering: convert to new ethdevoffloads API")
Cc: [email protected]
Also, need to add CC: <author of the commit> i.e CC: Shahaf Shuler <[email protected]>
Other than that , patch looks ok to me. Please include my ack in next version of the patch .
PATCH v2 1/1 examples/packet_ordering: use local port config
In reply to [email protected]From: Dapeng Yu <[email protected]>
A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of rte_eth_dev_configure() in original implementation, and cause that fast mbuf free feature cannot be enabled on port.
This patch use this local variable as input of rte_eth_dev_configure().
---
v2:
* Add Cc:<original author> and Acked-by:<maintainer>
examples/packet_ordering/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/packet_ordering/main.c +1 -1
@@ -290,7 +290,7 @@ configure_eth_port(uint16_t port_id)if (dev_info.tx_offload_capa &DEV_TX_OFFLOAD_MBUF_FAST_FREE ) port_conf.txmode.offloads |=DEV_TX_OFFLOAD_MBUF_FAST_FREE ; - ret =rte_eth_dev_configure (port_id, rxRings, txRings, &port_conf_default); + ret =rte_eth_dev_configure (port_id, rxRings, txRings, &port_conf);if (ret !=0 )return ret;
Signature · 1 line
2.27.0
Thomas Monjalon
Applied19/03/2021 08:11, [email protected]:
Quoted 8 lines
From: Dapeng Yu <[email protected]>
A global ethernet port configuration is assigned to local variable because in this way the local variable may be updated as required. But this local variable is not used as input of
rte_eth_dev_configure()in original implementation, and cause that fast mbuf free feature cannot be enabled on port.
Quoted 8 lines
This patch use this local variable as input of
rte_eth_dev_configure().Fixes 6833f919f56b ("examples/packet_ordering: convert to new ethdev offloads API")Signed-off-by Dapeng Yu <[email protected]>Acked-by Reshma Pattan <[email protected]>
Applied, thanks