Skip to contentSkip to conversation

Rectify spelling and grammar

PATCH In review Xiaofeng Cao 2 participants 3 messages Mar 11, 2021 – Mar 16, 2021 1 message not in the archive Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Rectify spelling and grammar

Change 'inaccesable' to 'inaccessible'
Change 'detrmine' to 'determine'
Delete 'in' grammatically

---
 drivers/media/radio/radio-si476x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/radio/radio-si476x.c +3 -3
index 23997425bdb5..b39a68f83c5f 100644
@@ -152,7 +152,7 @@ static struct v4l2_ctrl_config si476x_ctrls[] = {
 
 	/*
 	 * SI476X during its station seeking(or tuning) process uses several
-	 * parameters to detrmine if "the station" is valid:
+	 * parameters to determine if "the station" is valid:
 	 *
 	 *	- Signal's SNR(in dBuV) must be lower than
 	 *	#V4L2_CID_SI476X_SNR_THRESHOLD
@@ -255,7 +255,7 @@ struct si476x_radio;
  *
  * This table holds pointers to functions implementing particular
  * operations depending on the mode in which the tuner chip was
- * configured to start in. If the function is not supported
+ * configured to start. If the function is not supported
  * corresponding element is set to #NULL.
  *
  * @tune_freq: Tune chip to a specific frequency
@@ -917,7 +917,7 @@ static int si476x_radio_s_ctrl(struct v4l2_ctrl *ctrl)
 	case V4L2_CID_RDS_RECEPTION:
 		/*
 		 * It looks like RDS related properties are
-		 * inaccesable when tuner is in AM mode, so cache the
+		 * inaccessible when tuner is in AM mode, so cache the
 		 * changes
 		 */
 		if (si476x_core_is_in_am_receiver_mode(radio->core))
Signature · 1 line
2.25.1
#1 lore raw

Hi Xiaofeng Cao,

The patch is good, but scripts/checkpatch.pl complains about a mismatch:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Xiaofeng Cao <[email protected]>' != 'Signed-off-by: Xiaofeng Cao <[email protected]>'

Which is the one I should use?

Regards,

Hans

Quoted 41 lines · Xiaofeng Cao

Change 'inaccesable' to 'inaccessible'
Change 'detrmine' to 'determine'
Delete 'in' grammatically

---
 drivers/media/radio/radio-si476x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/media/radio/radio-si476x.c +3 -3
index 23997425bdb5..b39a68f83c5f 100644
@@ -152,7 +152,7 @@ static struct v4l2_ctrl_config si476x_ctrls[] = {
 
 	/*
 	 * SI476X during its station seeking(or tuning) process uses several
-	 * parameters to detrmine if "the station" is valid:
+	 * parameters to determine if "the station" is valid:
 	 *
 	 *	- Signal's SNR(in dBuV) must be lower than
 	 *	#V4L2_CID_SI476X_SNR_THRESHOLD
@@ -255,7 +255,7 @@ struct si476x_radio;
  *
  * This table holds pointers to functions implementing particular
  * operations depending on the mode in which the tuner chip was
- * configured to start in. If the function is not supported
+ * configured to start. If the function is not supported
  * corresponding element is set to #NULL.
  *
  * @tune_freq: Tune chip to a specific frequency
@@ -917,7 +917,7 @@ static int si476x_radio_s_ctrl(struct v4l2_ctrl *ctrl)
 	case V4L2_CID_RDS_RECEPTION:
 		/*
 		 * It looks like RDS related properties are
-		 * inaccesable when tuner is in AM mode, so cache the
+		 * inaccessible when tuner is in AM mode, so cache the
 		 * changes
 		 */
 		if (si476x_core_is_in_am_receiver_mode(radio->core))

A message that is not in the archive (sent off-list or not yet received): CAHHmPVFHkgGdo6C+FYBo+jsH=xzpnEUgGs7bKT6=MQFhZC-N1g@mail.gmail.com

#3 lore raw
Quoted 3 lines · Xiaofeng Cao

Hi Hans Verkuil,

I'm sorry to make you confused. Please use Xiaofeng Cao <[email protected] <mailto:[email protected]>>

Thanks, I've updated this to keep checkpatch happy.

BTW, for your next patch: it is good practice to add a prefix of the driver you are patching, so:

[PATCH] radio-si476x: rectify spelling and grammar

That way we know in which driver the change is.

Regards,

Hans

Quoted 69 lines

Gmail.com is my personal email while yulong.com <http://yulong.com> is my company email which is in trouble when communicating with the Linux kernel.

According to relevant regulations, I have to use the company mailbox to indicate company information.

Best regards,

    Xiaofeng

Hans Verkuil <[email protected] <mailto:[email protected]>> 于2021年3月16日周二 下午3:45写道:

Hi Xiaofeng Cao,

The patch is good, but scripts/checkpatch.pl <http://checkpatch.pl> complains about a mismatch:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Xiaofeng Cao <[email protected] <mailto:[email protected]>>' != 'Signed-off-by: Xiaofeng Cao
<[email protected] <mailto:[email protected]>>'

Which is the one I should use?

Regards,

        Hans

On 11/03/2021 08:20, Xiaofeng Cao wrote:
> Change 'inaccesable' to 'inaccessible'
> Change 'detrmine' to 'determine'
> Delete 'in' grammatically
>
> Signed-off-by: Xiaofeng Cao <[email protected] <mailto:[email protected]>> > ---
>  drivers/media/radio/radio-si476x.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/radio/radio-si476x.c b/drivers/media/radio/radio-si476x.c > index 23997425bdb5..b39a68f83c5f 100644
> --- a/drivers/media/radio/radio-si476x.c
> +++ b/drivers/media/radio/radio-si476x.c
> @@ -152,7 +152,7 @@ static struct v4l2_ctrl_config si476x_ctrls[] = { >
>       /*
>        * SI476X during its station seeking(or tuning) process uses several > -      * parameters to detrmine if "the station" is valid:
> +      * parameters to determine if "the station" is valid:
>        *
>        *      - Signal's SNR(in dBuV) must be lower than
>        *      #V4L2_CID_SI476X_SNR_THRESHOLD
> @@ -255,7 +255,7 @@ struct si476x_radio;
>   *
>   * This table holds pointers to functions implementing particular
>   * operations depending on the mode in which the tuner chip was
> - * configured to start in. If the function is not supported
> + * configured to start. If the function is not supported
>   * corresponding element is set to #NULL.
>   *
>   * @tune_freq: Tune chip to a specific frequency
> @@ -917,7 +917,7 @@ static int si476x_radio_s_ctrl(struct v4l2_ctrl *ctrl) >       case V4L2_CID_RDS_RECEPTION:
>               /*
>                * It looks like RDS related properties are
> -              * inaccesable when tuner is in AM mode, so cache the
> +              * inaccessible when tuner is in AM mode, so cache the >                * changes
>                */
>               if (si476x_core_is_in_am_receiver_mode(radio->core))
>