Skip to contentSkip to conversation

ASoC: qcom: lpass-cpu: Fix lpass dai ids parse

PATCH Superseded Srinivasa Rao Mandadapu 2 participants 4 messages Mar 11, 2021

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: qcom: lpass-cpu: Fix lpass dai ids parse

The max boundary check while parsing dai ids makes sound card registration fail after common up dai ids.

Fixes cd3484f7f1386 (ASoC: dt-bindings: lpass: Fix and common up lpass dai ids)
---
 sound/soc/qcom/lpass-cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/qcom/lpass-cpu.c +1 -1
index 4762286b33fe..c62d2612e8f5 100644
@@ -739,7 +739,7 @@ static void of_lpass_cpu_parse_dai_data(struct device *dev,
 
 	for_each_child_of_node(dev->of_node, node) {
 		ret = of_property_read_u32(node, "reg", &id);
-		if (ret || id < 0 || id >= data->variant->num_dai) {
+		if (ret || id < 0) {
 			dev_err(dev, "valid dai id not found: %d\n", ret);
 			continue;
 		}
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
maintainer
#1 lore raw
Quoted 4 lines · Srinivasa Rao Mandadapu

The max boundary check while parsing dai ids makes sound card registration fail after common up dai ids.

Fixes cd3484f7f1386 (ASoC: dt-bindings: lpass: Fix and common up lpass dai ids)

Commit: 43e2ca64db47 ("ASoC: qcom: lpass-cpu: Fix lpass dai ids parse")
Fixes tag: Fixes: cd3484f7f1386 (ASoC: dt-bindings: lpass: Fix and common up lpass dai ids) Has these problem(s):
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

#2 lore raw

Thanks for the info Mark!!

Sorry for the typo mistake. Will re-post with proper subject.

Quoted 1 line · Mark Brown

git log -1 --format='Fixes: %h ("%s")'

Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
maintainer
#3 lore raw
In reply to Srinivasa Rao Mandadapu
Quoted 4 lines · Srinivasa Rao Mandadapu

The max boundary check while parsing dai ids makes sound card registration fail after common up dai ids.

Fixes cd3484f7f1386 (ASoC: dt-bindings: lpass: Fix and common up lpass dai ids)

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: qcom: lpass-cpu: Fix lpass dai ids parse

      commit: 9922f50f7178496e709d3d064920b5031f0d9061

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark