Skip to contentSkip to conversation

arm64: dts: qcom: sm8350: Add PMICs

PATCH In review Vinod Koul 2 participants 10 messages Mar 12, 2021

Subsystems (3)
lore
Share & tools
lore

Vinod Koul

author
#0 lore raw

cover arm64: dts: qcom: sm8350: Add PMICs

This adds the SPMI nodes for SM8350 followed by PMIC base file containing the GPIO nodes for these pmics (pmic compatibles have been picked by LinusW)

SM8350-MTP includes PM8350, PM8350B, PM8350C, PMK8350, PMR735A AND PMR735B pmics.

Vinod Koul (8):
arm64: dts: qcom: sm8350: Add spmi node
arm64: dts: qcom: pmk8350: Add base dts file
arm64: dts: qcom: pm8350: Add base dts file
arm64: dts: qcom: pm8350b: Add base dts file
arm64: dts: qcom: pm8350c: Add base dts file
arm64: dts: qcom: pmr735a: Add base dts file
arm64: dts: qcom: pmr735b: Add base dts file
arm64: dts: qcom: sm8350-mtp: Add PMICs

 arch/arm64/boot/dts/qcom/pm8350.dtsi    | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8350b.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8350c.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pmk8350.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pmr735a.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pmr735b.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8350-mtp.dts |  6 ++++++
 arch/arm64/boot/dts/qcom/sm8350.dtsi    | 18 ++++++++++++++++++
 8 files changed, 174 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350b.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmr735b.dtsi
Signature · 1 line
2.26.2
author
#1 lore raw

PATCH 1/8 arm64: dts: qcom: sm8350: Add spmi node

Add SPMI node found in SM8350 SoC

---
 arch/arm64/boot/dts/qcom/sm8350.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
arch/arm64/boot/dts/qcom/sm8350.dtsi +18 -0
index 90439bd6eea8..5e2569ceebad 100644
@@ -634,6 +634,24 @@ aoss_qmp: qmp@c300000 {
 			#power-domain-cells = <1>;
 		};
 
+		spmi_bus: qcom,spmi@c440000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0x0 0xc440000 0x0 0x1100>,
+			      <0x0 0xc600000 0x0 0x2000000>,
+			      <0x0 0xe600000 0x0 0x100000>,
+			      <0x0 0xe700000 0x0 0xa0000>,
+			      <0x0 0xc40a000 0x0 0x26000>;
+			reg-names = "core", "chnls", "obsrvr", "intr", "cnfg";
+			interrupt-names = "periph_irq";
+			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+			qcom,ee = <0>;
+			qcom,channel = <0>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+			interrupt-controller;
+			#interrupt-cells = <4>;
+		};
+
 		tlmm: pinctrl@f100000 {
 			compatible = "qcom,sm8350-tlmm";
 			reg = <0 0x0f100000 0 0x300000>;
Signature · 1 line
2.26.2
author
#2 lore raw

PATCH 2/8 arm64: dts: qcom: pmk8350: Add base dts file

In reply to Vinod Koul

Add base DTS file for PMK8350 along with GPIO node

---
 arch/arm64/boot/dts/qcom/pmk8350.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
arch/arm64/boot/dts/qcom/pmk8350.dtsi new file +25 -0
new file mode 100644
index 000000000000..1530b8ff270f
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pmk8350: pmic@0 {
+		compatible = "qcom,pmk8350", "qcom,spmi-pmic";
+		reg = <0x0 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pmk8350_gpios: gpio@b000 {
+			compatible = "qcom,pmk8350-gpio";
+			reg = <0xb000>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
Signature · 1 line
2.26.2
author
#3 lore raw

PATCH 3/8 arm64: dts: qcom: pm8350: Add base dts file

In reply to Vinod Koul

Add base DTS file for PM8350 along with GPIO node

---
 arch/arm64/boot/dts/qcom/pm8350.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350.dtsi
arch/arm64/boot/dts/qcom/pm8350.dtsi new file +25 -0
new file mode 100644
index 000000000000..308f9ca7c744
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pm8350: pmic@1 {
+		compatible = "qcom,pm8350", "qcom,spmi-pmic";
+		reg = <0x1 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm8350_gpios: gpio@8800 {
+			compatible = "qcom,pm8350-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
Signature · 1 line
2.26.2
author
#4 lore raw

PATCH 4/8 arm64: dts: qcom: pm8350b: Add base dts file

In reply to Vinod Koul

Add base DTS file for PM8350B along with GPIO node

---
 arch/arm64/boot/dts/qcom/pm8350b.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350b.dtsi
arch/arm64/boot/dts/qcom/pm8350b.dtsi new file +25 -0
new file mode 100644
index 000000000000..b23bb1d49a4d
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pm8350b: pmic@3 {
+		compatible = "qcom,pm8350b", "qcom,spmi-pmic";
+		reg = <0x3 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm8350b_gpios: gpio@8800 {
+			compatible = "qcom,pm8350b-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
Signature · 1 line
2.26.2
author
#5 lore raw

PATCH 5/8 arm64: dts: qcom: pm8350c: Add base dts file

In reply to Vinod Koul

Add base DTS file for PM8350C along with GPIO node

---
 arch/arm64/boot/dts/qcom/pm8350c.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
arch/arm64/boot/dts/qcom/pm8350c.dtsi new file +25 -0
new file mode 100644
index 000000000000..2b9b75ecec60
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pm8350c: pmic@2 {
+		compatible = "qcom,pm8350c", "qcom,spmi-pmic";
+		reg = <0x2 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm8350c_gpios: gpio@8800 {
+			compatible = "qcom,pm8350c-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
Signature · 1 line
2.26.2
author
#6 lore raw

PATCH 6/8 arm64: dts: qcom: pmr735a: Add base dts file

In reply to Vinod Koul

Add base DTS file for PMR735A along with GPIO node

---
 arch/arm64/boot/dts/qcom/pmr735a.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
arch/arm64/boot/dts/qcom/pmr735a.dtsi new file +25 -0
new file mode 100644
index 000000000000..1c675af13cbf
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pmr735a: pmic@4 {
+		compatible = "qcom,pmr735a", "qcom,spmi-pmic";
+		reg = <0x4 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pmr735a_gpios: gpio@8800 {
+			compatible = "qcom,pmr735a-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
Signature · 1 line
2.26.2
author
#7 lore raw

PATCH 7/8 arm64: dts: qcom: pmr735B: Add base dts file

In reply to Vinod Koul

Add base DTS file for PMR735B along with GPIO node

---
 arch/arm64/boot/dts/qcom/pmr735b.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pmr735b.dtsi
arch/arm64/boot/dts/qcom/pmr735b.dtsi new file +25 -0
new file mode 100644
index 000000000000..1144086280f5
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, Linaro Limited
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pmr735b: pmic@5 {
+		compatible = "qcom,pmr735b", "qcom,spmi-pmic";
+		reg = <0x5 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pmr735b_gpios: gpio@8800 {
+			compatible = "qcom,pmr735b-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
Signature · 1 line
2.26.2
author
#8 lore raw

PATCH 8/8 arm64: dts: qcom: sm8350-mtp: Add PMICs

In reply to Vinod Koul

SM8350-MTP features PM8350, PM8350B, PM8350C, PMK8350, PMR735A and PMR735B. PMICs Add the dtsi for these PMICs to MTP.

---
 arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/sm8350-mtp.dts +6 -0
index 98a517edd442..6ca638b4e321 100644
@@ -8,6 +8,12 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include "sm8350.dtsi"
+#include "pm8350.dtsi"
+#include "pm8350b.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"
+#include "pmr735a.dtsi"
+#include "pmr735b.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. sm8350 MTP";
Signature · 1 line
2.26.2
Reviewed-by on the v1 series
#9 lore raw
In reply to Vinod Koul

Looks good to me.

Quoted 36 lines · Vinod Koul

This adds the SPMI nodes for SM8350 followed by PMIC base file containing the GPIO nodes for these pmics (pmic compatibles have been picked by LinusW)

SM8350-MTP includes PM8350, PM8350B, PM8350C, PMK8350, PMR735A AND PMR735B pmics.

Vinod Koul (8):
arm64: dts: qcom: sm8350: Add spmi node
arm64: dts: qcom: pmk8350: Add base dts file
arm64: dts: qcom: pm8350: Add base dts file
arm64: dts: qcom: pm8350b: Add base dts file
arm64: dts: qcom: pm8350c: Add base dts file
arm64: dts: qcom: pmr735a: Add base dts file
arm64: dts: qcom: pmr735b: Add base dts file
arm64: dts: qcom: sm8350-mtp: Add PMICs

 arch/arm64/boot/dts/qcom/pm8350.dtsi    | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8350b.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8350c.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pmk8350.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pmr735a.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pmr735b.dtsi   | 25 +++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8350-mtp.dts |  6 ++++++
 arch/arm64/boot/dts/qcom/sm8350.dtsi    | 18 ++++++++++++++++++
 8 files changed, 174 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350b.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pm8350c.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmk8350.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmr735a.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmr735b.dtsi

--
2.26.2

Signature · 2 lines
With best wishes
Dmitry