zram-fix-broken-page-writeback.patch removed from -mm tree
The patch titled
Subject: zram: fix broken page writeback
has been removed from the -mm tree. Its filename was
zram-fix-broken-page-writeback.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Minchan Kim <[email protected]>
Subject: zram: fix broken page writeback
commit 0d8359620d9b ("zram: support page writeback") introduced two problems. It overwrites writeback_store's return value as kstrtol's return value, which makes return value zero so user could see zero as return value of write syscall even though it wrote data successfully.
It also breaks index value in the loop in that it doesn't increase the index any longer. It means it can write only first starting block index so user couldn't write all idle pages in the zram so lose memory saving chance.
This patch fixes those issues.
---
drivers/block/zram/zram_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/block/zram/zram_drv.c renamed from drivers/block/zram/zram_drv.c~zram-fix-broken-page-writeback +3 -3
@@ -638,8 +638,8 @@ static ssize_t writeback_store(struct deif (strncmp (buf,PAGE_WB_SIG ,sizeof (PAGE_WB_SIG ) -1 ))return -EINVAL ; - ret =kstrtol (buf +sizeof (PAGE_WB_SIG ) -1 ,10 , &index); -if (ret || index >= nr_pages) +if (kstrtol (buf +sizeof (PAGE_WB_SIG ) -1 ,10 , &index) || + index >= nr_pages)return -EINVAL ; nr_pages =1 ;
@@ -663,7 +663,7 @@ static ssize_t writeback_store(struct de goto release_init_lock; } -while (nr_pages--) { +for (; nr_pages !=0 ; index++, nr_pages--) {struct bio_vec bvec; bvec.bv_page = page;
_
Patches currently in -mm which might be from [email protected] are
mm-remove-lru_add_drain_all-in-alloc_contig_range.patch mm-page_alloc-dump-migrate-failed-pages.patch mm-vmstat-add-cma-statistics.patch mm-cma-support-sysfs.patch