gpio: mockup: Drop duplicate NULL check in gpio_mockup_unregister_pdevs()
Subsystems (2)
PATCH 1/1 gpio: mockup: Drop duplicate NULL check in gpio_mockup_unregister_pdevs()
Since platform_device_unregister() is NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/gpio/gpio-mockup.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/gpio/gpio-mockup.c +2 -7
@@ -479,15 +479,10 @@ static struct platform_device *gpio_mockup_pdevs[GPIO_MOCKUP_MAX_GC];static void gpio_mockup_unregister_pdevs (void ) { -struct platform_device *pdev;int i; -for (i =0 ; i <GPIO_MOCKUP_MAX_GC ; i++) { - pdev = gpio_mockup_pdevs[i]; - -if (pdev) -platform_device_unregister (pdev); - } +for (i =0 ; i <GPIO_MOCKUP_MAX_GC ; i++) +platform_device_unregister (gpio_mockup_pdevs[i]); } static __init char **gpio_mockup_make_line_names(const char *label,
Signature · 1 line
2.30.2
Bartosz Golaszewski
AppliedQuoted 32 lines · Andy Shevchenko
Since
platform_device_unregister()is NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/gpio/gpio-mockup.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)drivers/gpio/gpio-mockup.c +2
-8@@ -479,15 +479,10 @@ static struct platform_device *gpio_mockup_pdevs[GPIO_MOCKUP_MAX_GC];static void gpio_mockup_unregister_pdevs (void ) { -struct platform_device *pdev;int i; -for (i =0 ; i <GPIO_MOCKUP_MAX_GC ; i++) { - pdev = gpio_mockup_pdevs[i]; - -if (pdev) -platform_device_unregister (pdev); - } +for (i =0 ; i <GPIO_MOCKUP_MAX_GC ; i++) +platform_device_unregister (gpio_mockup_pdevs[i]); } static __init char **gpio_mockup_make_line_names(const char *label, --
Quoted 2 lines
2.30.2
Applied, thanks!
Bartosz