Skip to contentSkip to conversation

rtc: rx6110: add ACPI bindings to I2C

PATCH Applied Claudius Heine 3 participants 5 messages Mar 17, 2021 – Mar 23, 2021 Real time clock (RTC)

lore
Share & tools
lore

Claudius Heine

author
#0 lore raw

PATCH v5 1/1 rtc: rx6110: add ACPI bindings to I2C

From: Johannes Hahn <[email protected]>

This allows the RX6110 driver to be automatically assigned to the right device on the I2C bus.

Signed-off-by Johannes Hahn <[email protected]>
Co-developed-by Claudius Heine <[email protected]>
Signed-off-by Claudius Heine <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
Reported-by kernel test robot <[email protected]>
---
 drivers/rtc/rtc-rx6110.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/rtc/rtc-rx6110.c +7 -0
index 79161d4c6ce4..f4d425002f7f 100644
@@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
 	return rx6110_probe(rx6110, &client->dev);
 }
 
+static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
+	{ "SECC6110" },
+	{ }
+};
+MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
+
 static const struct i2c_device_id rx6110_i2c_id[] = {
 	{ "rx6110", 0 },
 	{ }

@@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
 static struct i2c_driver rx6110_i2c_driver = {
 	.driver = {
 		.name = RX6110_DRIVER_NAME,
+		.acpi_match_table = rx6110_i2c_acpi_match,
 	},
 	.probe		= rx6110_i2c_probe,
 	.id_table	= rx6110_i2c_id,

base-commit: 1df27313f50a57497c1faeb6a6ae4ca939c85a7d

Signature · 1 line
2.30.1
#1 lore raw
Quoted 5 lines · Claudius Heine

From: Johannes Hahn <[email protected]>

This allows the RX6110 driver to be automatically assigned to the right device on the I2C bus.

Thanks for an update!

Quoted 6 lines
Signed-off-by Johannes Hahn <[email protected]>
Co-developed-by Claudius Heine <[email protected]>
Signed-off-by Claudius Heine <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
Reported-by kernel test robot <[email protected]>

This is usually for patches that do fix found problems, here it's a completely new item and the report was done in the middle of the development. That said, you may give credit to LKP by just mentioning it in the comments section (after the cutter '---' line). I'll leave this to Alexandre and Alessandro to decide if you need a resend or they may remove it when applying. (In my opinion resend is not needed right now)

Quoted 34 lines
---
 drivers/rtc/rtc-rx6110.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/rtc/rtc-rx6110.c +7 -0
index 79161d4c6ce4..f4d425002f7f 100644
@@ -447,6 +447,12 @@ static int rx6110_i2c_probe(struct i2c_client *client,
        return rx6110_probe(rx6110, &client->dev);
 }
 
+static const struct acpi_device_id rx6110_i2c_acpi_match[] = {
+       { "SECC6110" },
+       { }
+};
+MODULE_DEVICE_TABLE(acpi, rx6110_i2c_acpi_match);
+
 static const struct i2c_device_id rx6110_i2c_id[] = {
        { "rx6110", 0 },
        { }

@@ -456,6 +462,7 @@ MODULE_DEVICE_TABLE(i2c, rx6110_i2c_id);
 static struct i2c_driver rx6110_i2c_driver = {
        .driver = {
                .name = RX6110_DRIVER_NAME,
+               .acpi_match_table = rx6110_i2c_acpi_match,
        },
        .probe          = rx6110_i2c_probe,
        .id_table       = rx6110_i2c_id,

base-commit: 1df27313f50a57497c1faeb6a6ae4ca939c85a7d --
2.30.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author
#2 lore raw

Hi Andy,

Quoted 16 lines · Andy Shevchenko
Quoted 5 lines · Claudius Heine

From: Johannes Hahn <[email protected]>

This allows the RX6110 driver to be automatically assigned to the right device on the I2C bus.

Thanks for an update!

Quoted 6 lines
Signed-off-by Johannes Hahn <[email protected]>
Co-developed-by Claudius Heine <[email protected]>
Signed-off-by Claudius Heine <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
Reported-by kernel test robot <[email protected]>
Quoted 7 lines

This is usually for patches that do fix found problems, here it's a completely new item and the report was done in the middle of the development. That said, you may give credit to LKP by just mentioning it in the comments section (after the cutter '---' line). I'll leave this to Alexandre and Alessandro to decide if you need a resend or they may remove it when applying. (In my opinion resend is not needed right now)

Ok. Thanks a lot for your reviews and patience!

regards,
Claudius

maintainer
#3 lore raw
Quoted 19 lines · Claudius Heine

Hi Andy,

Quoted 16 lines · Andy Shevchenko
Quoted 5 lines · Claudius Heine

From: Johannes Hahn <[email protected]>

This allows the RX6110 driver to be automatically assigned to the right device on the I2C bus.

Thanks for an update!

Quoted 6 lines
Signed-off-by Johannes Hahn <[email protected]>
Co-developed-by Claudius Heine <[email protected]>
Signed-off-by Claudius Heine <[email protected]>
Reviewed-by Andy Shevchenko <[email protected]>
Reported-by kernel test robot <[email protected]>
Quoted 9 lines
Quoted 7 lines

This is usually for patches that do fix found problems, here it's a completely new item and the report was done in the middle of the development. That said, you may give credit to LKP by just mentioning it in the comments section (after the cutter '---' line). I'll leave this to Alexandre and Alessandro to decide if you need a resend or they may remove it when applying. (In my opinion resend is not needed right now)

Ok. Thanks a lot for your reviews and patience!

I removed it when applying. Thanks for the work and the reviews!

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
maintainer Applied
#4 lore raw
In reply to Claudius Heine
Quoted 2 lines · Claudius Heine

This allows the RX6110 driver to be automatically assigned to the right device on the I2C bus.

Applied, thanks!

[1/1] rtc: rx6110: add ACPI bindings to I2C

      commit: 8d69f62fddf6c1a8c7745120c4d6aab9322b001a

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>