Skip to contentSkip to conversation

kernel: debug: Ordinary typo fixes in the file gdbstub.c

PATCH Superseded Bhaskar Chowdhury 2 participants 3 messages Mar 17, 2021 KGDB / KDB /debug_core

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: debug: Ordinary typo fixes in the file gdbstub.c

s/'O'utput/'Output/
s/overwitten/overwritten/
s/procesing/processing/

---
 kernel/debug/gdbstub.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/debug/gdbstub.c +3 -3
index e149a0ac9e9e..5c96590725f1 100644
@@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
 	if (len == 0)
 		len = strlen(s);
 
-	/* 'O'utput */
+	/* 'Output */
 	gdbmsgbuf[0] = 'O';
 
 	/* Fill and send buffers... */
@@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
 /*
  * Copy the binary array pointed to by buf into mem.  Fix $, #, and
  * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
- * The input buf is overwitten with the result to write to mem.
+ * The input buf is overwritten with the result to write to mem.
  */
 static int kgdb_ebin2mem(char *buf, char *mem, int count)
 {
@@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
 }
 
 /*
- * This function performs all gdbserial command procesing
+ * This function performs all gdbserial command processing
  */
 int gdb_serial_stub(struct kgdb_state *ks)
 {

--
2.30.2

#1 lore raw
Quoted 15 lines · Bhaskar Chowdhury

s/'O'utput/'Output/
s/overwitten/overwritten/
s/procesing/processing/

---
 kernel/debug/gdbstub.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/debug/gdbstub.c +0 -0
index e149a0ac9e9e..5c96590725f1 100644

kernel/debug/gdbstub.c void gdbstub_msg_write(const char *s, int len) · line 207

Quoted 5 lines
kernel/debug/gdbstub.c +1 -1
@@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
 	if (len == 0)
 		len = strlen(s);
 
-	/* 'O'utput */
+	/* 'Output */

This is not a typo.

It is showing that the 'O' being writing into the message buffer is a mnemonic and describing what it expands to.

Other changes look good, please can you resend with this one removed?

Daniel.

Quoted 24 lines
kernel/debug/gdbstub.c +2 -3
 	gdbmsgbuf[0] = 'O';
 
 	/* Fill and send buffers... */
@@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
 /*
  * Copy the binary array pointed to by buf into mem.  Fix $, #, and
  * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
- * The input buf is overwitten with the result to write to mem.
+ * The input buf is overwritten with the result to write to mem.
  */
 static int kgdb_ebin2mem(char *buf, char *mem, int count)
 {
@@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
 }
 
 /*
- * This function performs all gdbserial command procesing
+ * This function performs all gdbserial command processing
  */
 int gdb_serial_stub(struct kgdb_state *ks)
 {
--

2.30.2

#2 lore raw
Quoted 24 lines · Daniel Thompson
Quoted 15 lines · Bhaskar Chowdhury

s/'O'utput/'Output/
s/overwitten/overwritten/
s/procesing/processing/

---
 kernel/debug/gdbstub.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/debug/gdbstub.c +0 -0
index e149a0ac9e9e..5c96590725f1 100644

kernel/debug/gdbstub.c void gdbstub_msg_write(const char *s, int len) · line 207

Quoted 5 lines
kernel/debug/gdbstub.c +1 -1
@@ -204,7 +204,7 @@ void gdbstub_msg_write(const char *s, int len)
 	if (len == 0)
 		len = strlen(s);
 
-	/* 'O'utput */
+	/* 'Output */

This is not a typo.

Quoted 6 lines

It is showing that the 'O' being writing into the message buffer is a mnemonic and describing what it expands to.

Other changes look good, please can you resend with this one removed?

Sure, thanks Daniel....V2 on the way...

Quoted 27 lines

Daniel.

Quoted 24 lines
kernel/debug/gdbstub.c +2 -3
 	gdbmsgbuf[0] = 'O';
 
 	/* Fill and send buffers... */
@@ -321,7 +321,7 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val)
 /*
  * Copy the binary array pointed to by buf into mem.  Fix $, #, and
  * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success.
- * The input buf is overwitten with the result to write to mem.
+ * The input buf is overwritten with the result to write to mem.
  */
 static int kgdb_ebin2mem(char *buf, char *mem, int count)
 {
@@ -952,7 +952,7 @@ static int gdb_cmd_exception_pass(struct kgdb_state *ks)
 }
 
 /*
- * This function performs all gdbserial command procesing
+ * This function performs all gdbserial command processing
  */
 int gdb_serial_stub(struct kgdb_state *ks)
 {
--

2.30.2