nvme: warn of unhandled effects only once
Keith Busch
maintainerPATCH 1/1 nvme: warn of unhandled effects only once
We don't need to repeatedly spam the kernel logs with the same warning about unhandled passthrough IO effects. Just one warning is sufficient to observe this condition occurs.
Signed-off-by Keith Busch <[email protected]>
--- drivers/nvme/host/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/nvme/host/core.c +3 -3
@@ -1072,9 +1072,9 @@ u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns, u8 opcode)if (ns->head->effects) effects =le32_to_cpu (ns->head->effects->iocs[opcode]);if (effects & ~(NVME_CMD_EFFECTS_CSUPP |NVME_CMD_EFFECTS_LBCC )) -dev_warn (ctrl->device, -"IO command:%02x has unhandled effects:%08x\n" , - opcode, effects); +dev_warn_once (ctrl->device, +"IO command:%02x has unhandled effects:%08x\n" , + opcode, effects);return 0 ; }
Signature · 7 lines
2.25.4 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 5 lines · Keith Busch
We don't need to repeatedly spam the kernel logs with the same warning about unhandled passthrough IO effects. Just one warning is sufficient to observe this condition occurs.
Signed-off-by Keith Busch <[email protected]>
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Thanks,
applied to nvme-5.13.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme