fanotify tests for v5.13
cover fanotify tests for v5.13
Hi Petr,
Following tests were used for development of the two features queued for v5.13 (in linux-next):
- Performance improvements for events merge [1]
- Unprivileged fanotify listener [2]
All test cases of fanotify05 pass on upstream, but their runtime on linux-next is reduced by more than half.
Only the first test case of fanotify17 pass on upstream. The rest of the test cases as well as fanotify18 and fanotify19 tests exit with TCONF on upstream. They all pass on linux-next.
Thanks,
Amir.
[1] https://lore.kernel.org/linux-fsdevel/[email protected]/
[2] https://lore.kernel.org/linux-fsdevel/[email protected]/
Amir Goldstein (8):
syscalls/fanotify05: Fix test output when not getting overflow syscalls/fanotify05: Verify events are received by queue order syscalls/fanotify05: Verify getting a single overflow event syscalls/fanotify05: Add a test case for unlimited queue syscalls/fanotify05: adjust test to tunable max_queued_events syscalls/fanotify: New test for fanotify user limits syscalls/fanotify: New test to validate unprivileged user permissions syscalls/fanotify: New test to validate unprivileged listener events
runtest/syscalls | 3 + testcases/kernel/syscalls/fanotify/.gitignore | 3 + testcases/kernel/syscalls/fanotify/fanotify.h | 3 + .../kernel/syscalls/fanotify/fanotify05.c | 147 ++++++++-- .../kernel/syscalls/fanotify/fanotify17.c | 266 ++++++++++++++++++ .../kernel/syscalls/fanotify/fanotify18.c | 198 +++++++++++++ .../kernel/syscalls/fanotify/fanotify19.c | 253 +++++++++++++++++ 7 files changed, 845 insertions(+), 28 deletions(-) create mode 100644 testcases/kernel/syscalls/fanotify/fanotify17.c create mode 100644 testcases/kernel/syscalls/fanotify/fanotify18.c create mode 100644 testcases/kernel/syscalls/fanotify/fanotify19.c
Signature · 1 line
2.25.1
PATCH 1/8 syscalls/fanotify05: Fix test output when not getting overflow
When test does not get an overflow event, errno for empty queue was not tested correctly and test printed a generic error instead of the intended message about not getting an overflow event.
Use a helper function to generate events and add info prints about the time it takes fill up the events queue and number of read events.
--- .../kernel/syscalls/fanotify/fanotify05.c | 50 +++++++++++++------ 1 file changed, 34 insertions(+), 16 deletions(-)
testcases/kernel/syscalls/fanotify/fanotify05.c +34 -16
@@ -21,11 +21,14 @@#include <string.h> #include <sys/syscall.h> #include "tst_test.h" +#include "tst_timer.h" #ifdef HAVE_SYS_FANOTIFY_H #include "fanotify.h" #define MOUNT_PATH "fs_mnt" +#define FNAME_PREFIX "fname_" +#define PATH_PREFIX MOUNT_PATH "/" FNAME_PREFIX/* Currently this is fixed in kernel... */ #define MAX_EVENTS 16384
@@ -36,37 +39,52 @@ static int fd, fd_notify;struct fanotify_event_metadata event; -void test01 (void ) +static void generate_events (int num_files) { +long long elapsed_ms;int i; -int len; -/* -* generate events -*/ -for (i =0 ; i <MAX_EVENTS +1 ; i++) { -sprintf (fname,MOUNT_PATH "/fname_%d" , i); +tst_timer_start (CLOCK_MONOTONIC ); + +for (i =0 ; i < num_files; i++) { +sprintf (fname,PATH_PREFIX "%d" , i); fd =SAFE_OPEN (fname,O_RDWR |O_CREAT ,0644 );SAFE_CLOSE (fd); } +tst_timer_stop (); + + elapsed_ms =tst_timer_elapsed_ms (); + +tst_res (TINFO ,"Created %d files in %llims" , i, elapsed_ms); +} + +void test01 (void ) +{ +int len, nevents =0 ; +int num_files =MAX_EVENTS +1 ; + +/* +* Generate events on unique files so they won't be merged +*/ +generate_events (num_files); +while (1 ) {/* * get list on events */ len =read (fd_notify, &event,sizeof (event));if (len <0 ) { -if (errno == -EAGAIN ) { -tst_res (TFAIL ,"Overflow event not " -"generated!\n" ); -break ; +if (errno !=EAGAIN ) { +tst_brk (TBROK |TERRNO , +"read of notification event failed" ); } -tst_brk (TBROK |TERRNO , -"read of notification event failed" ); +tst_res (TFAIL ,"Overflow event not generated!\n" );break ; }if (event.fd !=FAN_NOFD )close (event.fd); + nevents++;/* * check events
@@ -92,12 +110,12 @@ void test01(void)break ; }tst_res (TPASS , -"got event: mask=%llx pid=%u fd=%d" , - (unsigned long long )event.mask, +"Got an overflow event: pid=%u fd=%d" , (unsigned )event.pid, event.fd); -break ; +break ; } } +tst_res (TINFO ,"Got %d events" , nevents); }static void setup (void )
Signature · 1 line
2.25.1
PATCH 2/8 syscalls/fanotify05: Verify events are received by queue order
In reply to Amir GoldsteinWhen all events are generated on unique objects, re-ordering no events are expected to be merged and therefore no event re-order is expected. Verify that events are received in the order that they were generated.
--- .../kernel/syscalls/fanotify/fanotify05.c | 31 ++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-)
testcases/kernel/syscalls/fanotify/fanotify05.c +30 -1
@@ -18,6 +18,8 @@#include <sys/stat.h> #include <sys/types.h> #include <errno.h> +#include <libgen.h> +#include <stdlib.h> #include <string.h> #include <sys/syscall.h> #include "tst_test.h"
@@ -28,6 +30,7 @@#define MOUNT_PATH "fs_mnt"#define FNAME_PREFIX "fname_" +#define FNAME_PREFIX_LEN 6#define PATH_PREFIX MOUNT_PATH "/" FNAME_PREFIX/* Currently this is fixed in kernel... */
@@ -35,10 +38,29 @@#define BUF_SIZE 256static char fname[BUF_SIZE ]; +static char symlnk[BUF_SIZE ]; +static char fdpath[BUF_SIZE ];static int fd, fd_notify;struct fanotify_event_metadata event; +static void event_res (struct fanotify_event_metadata *event,int i) +{ +int len =0 ; +const char *filename; +sprintf (symlnk,"/proc/self/fd/%d" , event->fd); + len =readlink (symlnk, fdpath,sizeof (fdpath)); +if (len <0 ) + len =0 ; + fdpath[len] =0 ; + filename =basename (fdpath); +if (len >FNAME_PREFIX_LEN &&atoi (filename +FNAME_PREFIX_LEN ) != i) { +tst_res (TFAIL ,"Got event #%d out of order filename=%s" , i, filename); + }else if (i ==0 ) { +tst_res (TINFO ,"Got event #%d filename=%s" , i, filename); + } +} +static void generate_events (int num_files) {long long elapsed_ms;
@@ -82,8 +104,15 @@ void test01(void)tst_res (TFAIL ,"Overflow event not generated!\n" );break ; } -if (event.fd !=FAN_NOFD ) +if (event.fd !=FAN_NOFD ) { +/* +* Verify that events generated on unique files +* are received by the same order they were generated. +*/ +if (nevents < num_files) +event_res (&event, nevents);close (event.fd); + } nevents++;/*
Signature · 1 line
2.25.1
PATCH 3/8 syscalls/fanotify05: Verify getting a single overflow event
In reply to Amir GoldsteinInstead of generating just one extra event, generate many events after filling events queue. The result should remain the same - just one overflow event is expected.
--- .../kernel/syscalls/fanotify/fanotify05.c | 26 ++++++++++++------- 1 file changed, 17 insertions(+), 9 deletions(-)
testcases/kernel/syscalls/fanotify/fanotify05.c +17 -9
@@ -61,7 +61,7 @@ static void event_res(struct fanotify_event_metadata *event, int i) } } -static void generate_events (int num_files) +static void generate_events (int open_flags,int num_files) {long long elapsed_ms;int i;
@@ -70,7 +70,7 @@ static void generate_events(int num_files)for (i =0 ; i < num_files; i++) {sprintf (fname,PATH_PREFIX "%d" , i); - fd =SAFE_OPEN (fname,O_RDWR |O_CREAT ,0644 ); + fd =SAFE_OPEN (fname, open_flags,0644 );SAFE_CLOSE (fd); }
@@ -78,18 +78,24 @@ static void generate_events(int num_files) elapsed_ms =tst_timer_elapsed_ms (); -tst_res (TINFO ,"Created %d files in %llims" , i, elapsed_ms); +tst_res (TINFO ,"%s %d files in %llims" , + (open_flags &O_CREAT ) ?"Created" :"Opened" , i, elapsed_ms); }void test01 (void ) { -int len, nevents =0 ; +int len, nevents =0 , got_overflow =0 ;int num_files =MAX_EVENTS +1 ;/* * Generate events on unique files so they won't be merged */ -generate_events (num_files); +generate_events (O_RDWR |O_CREAT , num_files); + +/* +* Generate more events on the same files that me be merged +*/ +generate_events (O_RDONLY , num_files);while (1 ) {/*
@@ -101,7 +107,8 @@ void test01(void)tst_brk (TBROK |TERRNO ,"read of notification event failed" ); } -tst_res (TFAIL ,"Overflow event not generated!\n" ); +if (!got_overflow) +tst_res (TFAIL ,"Overflow event not generated!\n" );break ; }if (event.fd !=FAN_NOFD ) {
@@ -129,10 +136,11 @@ void test01(void)break ; }if (event.mask ==FAN_Q_OVERFLOW ) { -if (event.fd !=FAN_NOFD ) { +if (got_overflow || event.fd !=FAN_NOFD ) {tst_res (TFAIL , -"invalid overflow event: " +"%s overflow event: " "mask=%llx pid=%u fd=%d" , + got_overflow ?"unexpected" :"invalid" , (unsigned long long )event.mask, (unsigned )event.pid, event.fd);
@@ -141,7 +149,7 @@ void test01(void)tst_res (TPASS ,"Got an overflow event: pid=%u fd=%d" , (unsigned )event.pid, event.fd); -break ; + got_overflow =1 ; } }tst_res (TINFO ,"Got %d events" , nevents);
Signature · 1 line
2.25.1
PATCH 4/8 syscalls/fanotify05: Add a test case for unlimited queue
In reply to Amir GoldsteinThe existing test case verifies getting an overflow event when events cannot fit in events queue.
Add a test case to verify that no overflow is generated when events queue size is unlimited.
--- .../kernel/syscalls/fanotify/fanotify05.c | 41 +++++++++++++++---- 1 file changed, 33 insertions(+), 8 deletions(-)
testcases/kernel/syscalls/fanotify/fanotify05.c +33 -8
@@ -36,6 +36,20 @@/* Currently this is fixed in kernel... */ #define MAX_EVENTS 16384 +static struct tcase { +const char *tname; +unsigned int init_flags; +} tcases[] = { + { +"Limited queue" , +FAN_CLASS_NOTIF , + }, + { +"Unlimited queue" , +FAN_CLASS_NOTIF |FAN_UNLIMITED_QUEUE , + }, +}; +#define BUF_SIZE 256static char fname[BUF_SIZE ];static char symlnk[BUF_SIZE ];
@@ -82,10 +96,19 @@ static void generate_events(int open_flags, int num_files) (open_flags & O_CREAT) ? "Created" : "Opened", i, elapsed_ms); } -void test01 (void ) +static void test_fanotify (unsigned int n) { +struct tcase *tc = &tcases[n];int len, nevents =0 , got_overflow =0 ;int num_files =MAX_EVENTS +1 ; +int expect_overflow = !(tc->init_flags &FAN_UNLIMITED_QUEUE ); + +tst_res (TINFO ,"Test #%d: %s" , n, tc->tname); + + fd_notify =SAFE_FANOTIFY_INIT (tc->init_flags |FAN_NONBLOCK ,O_RDONLY ); + +SAFE_FANOTIFY_MARK (fd_notify,FAN_MARK_MOUNT |FAN_MARK_ADD ,FAN_OPEN , +AT_FDCWD ,MOUNT_PATH );/* * Generate events on unique files so they won't be merged
@@ -108,7 +131,7 @@ void test01(void) "read of notification event failed"); }if (!got_overflow) -tst_res (TFAIL ,"Overflow event not generated!\n" ); +tst_res (expect_overflow ?TFAIL :TPASS ,"Overflow event not generated!\n" );break ; }if (event.fd !=FAN_NOFD ) {
@@ -146,22 +169,23 @@ void test01(void) event.fd);break ; } -tst_res (TPASS , +tst_res (expect_overflow ?TPASS :TFAIL ,"Got an overflow event: pid=%u fd=%d" , (unsigned )event.pid, event.fd); got_overflow =1 ; } }tst_res (TINFO ,"Got %d events" , nevents); +SAFE_CLOSE (fd_notify); }static void setup (void ) { - fd_notify =SAFE_FANOTIFY_INIT (FAN_CLASS_NOTIF |FAN_NONBLOCK , -O_RDONLY ); +int fd; -SAFE_FANOTIFY_MARK (fd_notify,FAN_MARK_MOUNT |FAN_MARK_ADD ,FAN_OPEN , -AT_FDCWD ,MOUNT_PATH ); +/* Check for kernel fanotify support */ + fd =SAFE_FANOTIFY_INIT (FAN_CLASS_NOTIF ,O_RDONLY ); +SAFE_CLOSE (fd); }static void cleanup (void )
@@ -171,7 +195,8 @@ static void cleanup(void) }static struct tst_test test = { - .test_all = test01, + .test = test_fanotify, + .tcnt =ARRAY_SIZE (tcases), .setup = setup, .cleanup = cleanup, .needs_root =1 ,
Signature · 1 line
2.25.1
PATCH 5/8 syscalls/fanotify05: adjust test to tunable max_queued_events
In reply to Amir GoldsteinSimilar to test inotify05, check if there is a system tunable for /proc/sys/fs/fanotify/max_queued_events and adjust the test according to the system limit.
--- testcases/kernel/syscalls/fanotify/fanotify05.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)
testcases/kernel/syscalls/fanotify/fanotify05.c +14 -3
@@ -33,8 +33,12 @@#define FNAME_PREFIX_LEN 6#define PATH_PREFIX MOUNT_PATH "/" FNAME_PREFIX -/* Currently this is fixed in kernel... */ -#define MAX_EVENTS 16384 +#define SYSFS_MAX_EVENTS "/proc/sys/fs/fanotify/max_queued_events" + +/* In older kernels this limit is fixed in kernel */ +#define DEFAULT_MAX_EVENTS 16384 + +static int max_events; static struct tcase { const char *tname;
@@ -100,7 +104,7 @@ static void test_fanotify(unsigned int n) {struct tcase *tc = &tcases[n];int len, nevents =0 , got_overflow =0 ; -int num_files =MAX_EVENTS +1 ; +int num_files = max_events +1 ;int expect_overflow = !(tc->init_flags &FAN_UNLIMITED_QUEUE );tst_res (TINFO ,"Test #%d: %s" , n, tc->tname);
@@ -186,6 +190,13 @@ static void setup(void)/* Check for kernel fanotify support */ fd =SAFE_FANOTIFY_INIT (FAN_CLASS_NOTIF ,O_RDONLY );SAFE_CLOSE (fd); + +/* In older kernels this limit is fixed in kernel */ +if (access (SYSFS_MAX_EVENTS ,F_OK ) && errno ==ENOENT ) + max_events =DEFAULT_MAX_EVENTS ; +else +SAFE_FILE_SCANF (SYSFS_MAX_EVENTS ,"%d" , &max_events); +tst_res (TINFO ,"max_queued_events=%d" , max_events); }static void cleanup (void )
Signature · 1 line
2.25.1
PATCH 6/8 syscalls/fanotify: New test for fanotify user limits
In reply to Amir GoldsteinCheck that fanotify groups and marks limit are enforced correctly. If user ns is supported, verify that global limit and per user ns limits are both enforced.
In older kernels, the groups limit per user is hardcoded 128. In recent kernels, the global limits can be configured via /proc/sys/fs/fanotify/max_user_* and can be further restricted per user ns via /proc/sys/user/max_fanotify_*.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/fanotify/.gitignore | 1 + testcases/kernel/syscalls/fanotify/fanotify.h | 3 + .../kernel/syscalls/fanotify/fanotify17.c | 266 ++++++++++++++++++ 4 files changed, 271 insertions(+) create mode 100644 testcases/kernel/syscalls/fanotify/fanotify17.c
runtest/syscalls +1 -0
@@ -590,6 +590,7 @@ fanotify13 fanotify13 fanotify14 fanotify14 fanotify15 fanotify15 fanotify16 fanotify16 +fanotify17 fanotify17 ioperm01 ioperm01 ioperm02 ioperm02
testcases/kernel/syscalls/fanotify/.gitignore +1 -0
@@ -14,4 +14,5 @@ /fanotify14 /fanotify15 /fanotify16 +/fanotify17 /fanotify_child
testcases/kernel/syscalls/fanotify/fanotify.h +3 -0
@@ -125,6 +125,9 @@ static inline int safe_fanotify_mark(const char *file, const int lineno,#define FAN_OPEN_EXEC_PERM 0x00040000#endif +/* Flags required for unprivileged user group */ +#define FANOTIFY_REQUIRED_USER_INIT_FLAGS (FAN_REPORT_FID) +/* * FAN_ALL_PERM_EVENTS has been deprecated, so any new permission events * are not to be added to it. To cover the instance where a new permission
testcases/kernel/syscalls/fanotify/fanotify17.c new file +266 -0
266 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH 7/8 syscalls/fanotify: New test to validate unprivileged user permissions
In reply to Amir GoldsteinDefined a set of new test cases to validate the fanotify interface. They are to ensure that the correct error values are returned upon requesting configurations forbidden for an unprivileged user.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/fanotify/.gitignore | 1 + .../kernel/syscalls/fanotify/fanotify18.c | 198 ++++++++++++++++++ 3 files changed, 200 insertions(+) create mode 100644 testcases/kernel/syscalls/fanotify/fanotify18.c
runtest/syscalls +1 -0
@@ -591,6 +591,7 @@ fanotify14 fanotify14 fanotify15 fanotify15 fanotify16 fanotify16 fanotify17 fanotify17 +fanotify18 fanotify18 ioperm01 ioperm01 ioperm02 ioperm02
testcases/kernel/syscalls/fanotify/.gitignore +1 -0
@@ -15,4 +15,5 @@ /fanotify15 /fanotify16 /fanotify17 +/fanotify18 /fanotify_child
testcases/kernel/syscalls/fanotify/fanotify18.c new file +198 -0
198 lines not on this page · raw message
Signature · 1 line
2.25.1
PATCH 8/8 syscalls/fanotify: New test to validate unprivileged listener events
In reply to Amir GoldsteinDefined test cases that are responsible for validating that the events returned to an unprivileged event listener contain the correct values.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/fanotify/.gitignore | 1 + .../kernel/syscalls/fanotify/fanotify19.c | 253 ++++++++++++++++++ 3 files changed, 255 insertions(+) create mode 100644 testcases/kernel/syscalls/fanotify/fanotify19.c
runtest/syscalls +1 -0
@@ -592,6 +592,7 @@ fanotify15 fanotify15 fanotify16 fanotify16 fanotify17 fanotify17 fanotify18 fanotify18 +fanotify19 fanotify19 ioperm01 ioperm01 ioperm02 ioperm02
testcases/kernel/syscalls/fanotify/.gitignore +1 -0
@@ -16,4 +16,5 @@ /fanotify16 /fanotify17 /fanotify18 +/fanotify19 /fanotify_child
testcases/kernel/syscalls/fanotify/fanotify19.c new file +253 -0
253 lines not on this page · raw message
Signature · 1 line
2.25.1
cover fanotify tests for v5.13
In reply to Amir GoldsteinHi Amir,
Quoted 6 lines
Hi Petr,
Following tests were used for development of the two features queued for v5.13 (in linux-next):
- Performance improvements for events merge [1]
- Unprivileged fanotify listener [2]
As these are features not fixes, I suppose nothing from these already merged 2 patchsets in next tree can be added with struct tst_tag to document it. I wonder if any of these are could be at least noted in the tests / commit messages.
Quoted 6 lines
All test cases of fanotify05 pass on upstream, but their runtime on linux-next is reduced by more than half.
Only the first test case of fanotify17 pass on upstream. The rest of the test cases as well as fanotify18 and fanotify19 tests exit with TCONF on upstream. They all pass on linux-next.
Thanks! LGTM, thanks for testing them on both mainline and next tree.
To whole patchset:
I'll apply it with following tiny fixes to fix compilation on very old kernels (2.6.x) and to use our documentation format [3] [4].
(+ later I'll fix documentation format for the rest of the tests)
Kind regards,
Petr
Quoted 5 lines
Thanks,
Amir.[1] https://lore.kernel.org/linux-fsdevel/[email protected]/
[2] https://lore.kernel.org/linux-fsdevel/[email protected]/
[3] https://github.com/linux-test-project/ltp/releases/download/20210121/metadata.20210121.pdf
[4] https://github.com/linux-test-project/ltp/releases/download/20210121/metadata.20210121.html
kernel/syscalls/fanotify/fanotify17.c +8 -6
@@ -7,13 +7,15 @@* Forked from getxattr05.c by Amir Goldstein <[email protected]> */ -/* -* DESCRIPTION -* Check that fanotify groups and marks limits are enforced correctly. -* If user ns is supported, verify that global limit and per user ns -* limits are both enforced. -* Otherwise, we only check that global groups limit is enforced. +/*\ +* [Description] +* +* Check that fanotify groups and marks limits are enforced correctly. +* If user ns is supported, verify that global limit and per user ns +* limits are both enforced. +* Otherwise, we only check that global groups limit is enforced. */ +#define _GNU_SOURCE#include "config.h" #include <errno.h>
kernel/syscalls/fanotify/fanotify18.c +12 -9
@@ -3,13 +3,17 @@* Copyright (c) 2018 Matthew Bobrowski. All Rights Reserved. * * Started by Matthew Bobrowski <[email protected]> +*/ + +/*\ +* [Description] * -* DESCRIPTION -* This set of tests is to ensure that the unprivileged listener feature of -* fanotify is functioning as expected. The objective this test case file -* is to validate whether any forbidden flags that are passed by an -* unprivileged user return the correct error result. +* This set of tests is to ensure that the unprivileged listener feature of +* fanotify is functioning as expected. The objective this test case file +* is to validate whether any forbidden flags that are passed by an +* unprivileged user return the correct error result. */ +#define _GNU_SOURCE#include "config.h"
@@ -17,10 +21,9 @@#include <stdio.h> #include <errno.h> #include "tst_test.h" -#include "fanotify.h" -#if defined(HAVE_SYS_FANOTIFY_H ) -#include <sys/fanotify.h> +#ifdef HAVE_SYS_FANOTIFY_H +#include "fanotify.h" /* * This is a set of intialization flags that are not permitted to be used by an
@@ -194,5 +197,5 @@ static struct tst_test test = { };#else -TST_TEST_CONF ("System does not have required fanotify support" ); +TST_TEST_TCONF ("system doesn't have required fanotify support" );#endif
kernel/syscalls/fanotify/fanotify19.c +13 -10
@@ -3,14 +3,18 @@* Copyright (c) 2018 Matthew Bobrowski. All Rights Reserved. * * Started by Matthew Bobrowski <[email protected]> +*/ + +/*\ +* [Description] * -* DESCRIPTION -* This set of tests is to ensure that the unprivileged listener feature of -* fanotify is functioning as expected. The objective of this test file is -* to generate a sequence of events and ensure that the returned events -* contain the limited values that an unprivileged listener is expected -* to receive. +* This set of tests is to ensure that the unprivileged listener feature of +* fanotify is functioning as expected. The objective of this test file is +* to generate a sequence of events and ensure that the returned events +* contain the limited values that an unprivileged listener is expected +* to receive. */ +#define _GNU_SOURCE#include "config.h"
@@ -21,10 +25,9 @@#include <sys/wait.h> #include "tst_test.h" -#include "fanotify.h" -#if defined(HAVE_SYS_FANOTIFY_H ) -#include <sys/fanotify.h> +#ifdef HAVE_SYS_FANOTIFY_H +#include "fanotify.h" #define EVENT_MAX 1024#define EVENT_SIZE (sizeof (struct fanotify_event_metadata))
@@ -249,5 +252,5 @@ static struct tst_test test = { };#else -TST_TEST_CONF ("System does not have required fanotify support" ); +TST_TEST_TCONF ("system doesn't have required fanotify support" );#endif
cover fanotify tests for v5.13
Quoted 10 lines · Petr Vorel
Hi Amir,
Quoted 6 lines
Hi Petr,
Following tests were used for development of the two features queued for v5.13 (in linux-next):
- Performance improvements for events merge [1]
- Unprivileged fanotify listener [2]
Quoted 5 lines
As these are features not fixes, I suppose nothing from these already merged 2 patchsets in next tree can be added with struct
tst_tagto document it. I wonder if any of these are could be at least noted in the tests / commit messages.
Whatever you think is best for your project users.
If you want to document the commits that added the features, I suggest that you wait until those commits hit master (next cycle). These are the relevant commit subjects:
fanotify: configurable limits via sysfs
fanotify: support limited functionality for unprivileged users
Thanks,
Amir.
cover fanotify tests for v5.13
Hi Amir,
Quoted 7 lines
Whatever you think is best for your project users.
If you want to document the commits that added the features, I suggest that you wait until those commits hit master (next cycle). These are the relevant commit subjects:fanotify: configurable limits via sysfs
fanotify: support limited functionality for unprivileged users
Thanks a lot!
IMHO being in next tree should be ok (commits hashes should be kept).
FYI next week I'm busy due hackweek, thus I'll probably merge this after.
Kind regards,
Petr
[1] http://lists.linux.it/pipermail/ltp/2021-March/021637.html
cover fanotify tests for v5.13
Quoted 8 lines · Petr Vorel
Hi Amir,
Quoted 4 lines
Whatever you think is best for your project users.
If you want to document the commits that added the features, I suggest that you wait until those commits hit master (next cycle). These are the relevant commit subjects:
Quoted 6 lines
Quoted 2 lines
fanotify: configurable limits via sysfs
fanotify: support limited functionality for unprivileged usersThanks a lot!
IMHO being in next tree should be ok (commits hashes should be kept).
There is no such guarantee, certainly not so far from the v5.13 merge window, so I advise against including the commit ids at this point. The commit subject is descriptive enough IMO and you can add commit ids later on if you think it is necessary.
Thanks,
Amir.
cover fanotify tests for v5.13
Hi Amir,
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
Whatever you think is best for your project users.
If you want to document the commits that added the features, I suggest that you wait until those commits hit master (next cycle). These are the relevant commit subjects:fanotify: configurable limits via sysfs
fanotify: support limited functionality for unprivileged users
Quoted 8 lines
Quoted 2 lines
Thanks a lot!
IMHO being in next tree should be ok (commits hashes should be kept).There is no such guarantee, certainly not so far from the v5.13 merge window, so I advise against including the commit ids at this point. The commit subject is descriptive enough IMO and you can add commit ids later on if you think it is necessary.
OK, make sense to wait with commit hashes. I'll merge it tomorrow as is (with that formatting and fixing old kernel changes I posted earlier).
Kind regards,
Petr
cover fanotify tests for v5.13
In reply to Amir GoldsteinHi Amir,
Quoted 8 lines
Quoted 7 lines
Quoted 7 lines
Whatever you think is best for your project users.
If you want to document the commits that added the features, I suggest that you wait until those commits hit master (next cycle). These are the relevant commit subjects:fanotify: configurable limits via sysfs
fanotify: support limited functionality for unprivileged users
Quoted 8 lines
Quoted 2 lines
Thanks a lot!
IMHO being in next tree should be ok (commits hashes should be kept).There is no such guarantee, certainly not so far from the v5.13 merge window, so I advise against including the commit ids at this point. The commit subject is descriptive enough IMO and you can add commit ids later on if you think it is necessary.
Merged + updated doc formatting for our doc generation. Thanks for your work!
Kind regards,
Petr