Simple question for comment in btrfs-progs qgroup code
Hello!
I see an comment in qgroup cmds below.
cmds/qgroup.c +0 -0
@@ -84,6 +84,7 @@ static int _cmd_qgroup_assign(const struct cmd_struct
*cmd, int assign,
/* * FIXME src should accept subvol path */
This comment is little confusing for me. src was parsed with parse_qgroupid() and it also accepts subvol path. is it outdated comment? or src should accept only lowest level of qgroup?
Thanks,
Sidong
Quoted 14 lines · Sidong Yang
Hello!
I see an comment in qgroup cmds below.
cmds/qgroup.c +0
-0@@ -84,6 +84,7 @@ static int _cmd_qgroup_assign(const struct cmd_struct *cmd, int assign,/* * FIXME src should accept subvol path */
Quoted 3 lines
This comment is little confusing for me. src was parsed with
parse_qgroupid()and it also accepts subvol path. is it outdated comment? or src should accept only lowest level of qgroup?
It's outdated and confusing.
For the assign ioctl, it only accepts 3 u64 parameters, assign:bool to indicate if it's adding or deleting qgroup relationship. src/dst to specify the qgroupid (u64).
There is no room for path at all.
The qgroupid resolve is done completely in user space.
Feel free to delete the comment.
Quoted 4 lines
Thanks,
Sidong