Skip to contentSkip to conversation

misdn: avoid -Wempty-body warning

PATCH Applied Arnd Bergmann 3 participants 4 messages Mar 22, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 misdn: avoid -Wempty-body warning

From: Arnd Bergmann <[email protected]>

gcc warns about a pointless condition:

drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt':
drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
2752 | ; /* external IRQ */

As the check has no effect, just remove it.

---
v2: remove the line instead of adding {}

---
 drivers/isdn/hardware/mISDN/hfcmulti.c | 2 --
 1 file changed, 2 deletions(-)
drivers/isdn/hardware/mISDN/hfcmulti.c +0 -2
index 7013a3f08429..14092152b786 100644
@@ -2748,8 +2748,6 @@ hfcmulti_interrupt(int intno, void *dev_id)
 		if (hc->ctype != HFC_TYPE_E1)
 			ph_state_irq(hc, r_irq_statech);
 	}
-	if (status & V_EXT_IRQSTA)
-		; /* external IRQ */
 	if (status & V_LOST_STA) {
 		/* LOST IRQ */
 		HFC_outb(hc, R_INC_RES_FIFO, V_RES_LOST); /* clear irq! */
Signature · 1 line
2.29.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

gcc warns about a pointless condition:

drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt':
drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
2752 | ; /* external IRQ */

As the check has no effect, just remove it.

Quoted 8 lines

---
v2: remove the line instead of adding {}

---
 drivers/isdn/hardware/mISDN/hfcmulti.c | 2 --
 1 file changed, 2 deletions(-)

Thanks, interesting when we will delete whole drivers/isdn :)

#2 lore raw
Quoted 4 lines · Leon Romanovsky

Thanks, interesting when we will delete whole drivers/isdn :)

Not any time soon I think, Harald Welte mentioned that Osmocom still relies on mISDN.

The CAPI stuff only remains because of net/bluetooth/cmtp/ though. I don't think there are any users, but Marcel wanted to keep cmtp since it is not really hardware specific. We could probably move drivers/isdn/capi/* to net/bluetooth/cmtp/ if there was a good reason.

Arnd

#3 lore raw
In reply to Arnd Bergmann
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 9 lines · On Mon, 22 Mar 2021 13:14:47 +0100 you wrote:

From: Arnd Bergmann <[email protected]>

gcc warns about a pointless condition:

drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt':
drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
2752 | ; /* external IRQ */

[...]

Here is the summary with links:
- [net-next,v2] misdn: avoid -Wempty-body warning

    https://git.kernel.org/netdev/net-next/c/13e8c216d2ed

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html