nvmet-fc: simplify nvmet_fc_alloc_hostport
Subsystems (3)
PATCH 1/1 nvmet-fc: simplify nvmet_fc_alloc_hostport
From: Amit Engel <[email protected]>
Once a host is already created,
avoid allocate additional hostports that will be thrown away. add an helper function to handle host search.
--- drivers/nvme/target/fc.c | 77 ++++++++++++++++++++++++---------------- 1 file changed, 46 insertions(+), 31 deletions(-)
drivers/nvme/target/fc.c +46 -31
@@ -1020,61 +1020,76 @@ nvmet_fc_free_hostport(struct nvmet_fc_hostport *hostport)nvmet_fc_hostport_put (hostport); } +static struct nvmet_fc_hostport * +nvmet_fc_match_hostport (struct nvmet_fc_tgtport *tgtport,void *hosthandle) +{ +struct nvmet_fc_hostport *host; + +/* tgtport->lock is held by caller */ + +list_for_each_entry (host, &tgtport->host_list, host_list) { +if (host->hosthandle == hosthandle && !host->invalid) { +if (nvmet_fc_hostport_get (host)) +return (host); + } + } + +return (NULL ); +} +static struct nvmet_fc_hostport *nvmet_fc_alloc_hostport (struct nvmet_fc_tgtport *tgtport,void *hosthandle) { -struct nvmet_fc_hostport *newhost, *host, *match =NULL ; +struct nvmet_fc_hostport *newhost, *match =NULL ;unsigned long flags;/* if LLDD not implemented, leave as NULL */ if (!hosthandle)return NULL ; -/* take reference for what will be the newly allocated hostport */ +/* +* take reference for what will be the newly allocated hostport if +* we end up using a new allocation +*/ if (!nvmet_fc_tgtport_get (tgtport))return ERR_PTR (-EINVAL ); +spin_lock_irqsave (&tgtport->lock, flags); + match =nvmet_fc_match_hostport (tgtport, hosthandle); +spin_unlock_irqrestore (&tgtport->lock, flags); + +if (match) { +/* no new allocation - release reference */ +nvmet_fc_tgtport_put (tgtport); +return match; + } + newhost =kzalloc (sizeof (*newhost),GFP_KERNEL );if (!newhost) { -spin_lock_irqsave (&tgtport->lock, flags); -list_for_each_entry (host, &tgtport->host_list, host_list) { -if (host->hosthandle == hosthandle && !host->invalid) { -if (nvmet_fc_hostport_get (host)) { - match = host; -break ; - } - } - } -spin_unlock_irqrestore (&tgtport->lock, flags); -/* no allocation - release reference */ +/* no new allocation - release reference */ nvmet_fc_tgtport_put (tgtport); -return (match) ? match :ERR_PTR (-ENOMEM ); +return ERR_PTR (-ENOMEM ); } - newhost->tgtport = tgtport; - newhost->hosthandle = hosthandle; -INIT_LIST_HEAD (&newhost->host_list); -kref_init (&newhost->ref); -spin_lock_irqsave (&tgtport->lock, flags); -list_for_each_entry (host, &tgtport->host_list, host_list) { -if (host->hosthandle == hosthandle && !host->invalid) { -if (nvmet_fc_hostport_get (host)) { - match = host; -break ; - } - } - } + match =nvmet_fc_match_hostport (tgtport, hosthandle);if (match) { +/* new allocation not needed */ kfree (newhost); - newhost =NULL ; -/* releasing allocation - release reference */ + newhost = match; +/* no new allocation - release reference */ nvmet_fc_tgtport_put (tgtport); - }else + }else { + newhost->tgtport = tgtport; + newhost->hosthandle = hosthandle; +INIT_LIST_HEAD (&newhost->host_list); +kref_init (&newhost->ref); +list_add_tail (&newhost->host_list, &tgtport->host_list); + }spin_unlock_irqrestore (&tgtport->lock, flags); -return (match) ? match : newhost; +return newhost; } static void
Signature · 7 lines
2.18.2 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
drivers/nvme/target/fc.c nvmet_fc_free_hostport(struct nvmet_fc_hostport *hostport) · line 1029
Quoted 4 lines · On 3/22/21 12:08, [email protected] wrote:
drivers/nvme/target/fc.c +4
-0+struct nvmet_fc_hostport *host; + +/* tgtport->lock is held by caller */ +
Please consider adding lockdep instead of comment.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
drivers/nvme/target/fc.c nvmet_fc_free_hostport(struct nvmet_fc_hostport *hostport) · line 1038
Quoted 4 lines · On 3/22/21 12:08, [email protected] wrote:
drivers/nvme/target/fc.c +4
-0+ } + +return (NULL ); +}
nit:- no need for () around NULL.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
drivers/nvme/target/fc.c nvmet_fc_free_hostport(struct nvmet_fc_hostport *hostport) · line 1072
Quoted 3 lines · On 3/22/21 12:08, [email protected] wrote:
drivers/nvme/target/fc.c +1
-1-return (match) ? match :ERR_PTR (-ENOMEM ); +return ERR_PTR (-ENOMEM ); }
Same comment about return () here.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 8 lines · Chaitanya Kulkarni
drivers/nvme/target/fc.c nvmet_fc_free_hostport(struct nvmet_fc_hostport *hostport) · line 1072
Quoted 3 lines · On 3/22/21 12:08, [email protected] wrote:
drivers/nvme/target/fc.c +1
-1-return (match) ? match :ERR_PTR (-ENOMEM ); +return ERR_PTR (-ENOMEM ); }Same comment about return () here.
nothing wrong here....
-- james
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 8 lines · James Smart
Quoted 3 lines
Same comment about return () here.
nothing wrong here....
-- james
Wrong comment plesae ignore.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme