Skip to contentSkip to conversation

dmaengine: dw: Make it dependent to HAVE_IOMEM

PATCH Superseded Andy Shevchenko 2 participants 3 messages Mar 24, 2021

Subsystems (2)
dmaengine Synopsys DesignWare DMAC driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 dmaengine: dw: Make it dependent to HAVE_IOMEM

Some architectures do not provide devm_*() APIs. Hence make the driver dependent on HAVE_IOMEM.

Fixes dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
Reported-by kernel test robot <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/dma/dw/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/dma/dw/Kconfig +2 -0
index e5162690de8f..dd4b56669d9f 100644
@@ -10,6 +10,7 @@ config DW_DMAC_CORE
 
 config DW_DMAC
 	tristate "Synopsys DesignWare AHB DMA platform driver"
+	depends on HAVE_IOMEM
 	select DW_DMAC_CORE
 	help
 	  Support the Synopsys DesignWare AHB DMA controller. This

@@ -18,6 +19,7 @@ config DW_DMAC
 config DW_DMAC_PCI
 	tristate "Synopsys DesignWare AHB DMA PCI driver"
 	depends on PCI
+	depends on HAVE_IOMEM
 	select DW_DMAC_CORE
 	help
 	  Support the Synopsys DesignWare AHB DMA controller on the
Signature · 1 line
2.30.2
#1 lore raw

Hi Andy

Quoted 2 lines · Andy Shevchenko

Some architectures do not provide devm_*() APIs. Hence make the driver dependent on HAVE_IOMEM.

You must have meant "HAS_IOMEM", right?

-Sergey

Quoted 31 lines
Fixes dbde5c2934d1 ("dw_dmac: use devm_* functions to simplify code")
Reported-by kernel test robot <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/dma/dw/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/dma/dw/Kconfig +2 -0
index e5162690de8f..dd4b56669d9f 100644
@@ -10,6 +10,7 @@ config DW_DMAC_CORE
 
 config DW_DMAC
 	tristate "Synopsys DesignWare AHB DMA platform driver"
+	depends on HAVE_IOMEM
 	select DW_DMAC_CORE
 	help
 	  Support the Synopsys DesignWare AHB DMA controller. This

@@ -18,6 +19,7 @@ config DW_DMAC
 config DW_DMAC_PCI
 	tristate "Synopsys DesignWare AHB DMA PCI driver"
 	depends on PCI
+	depends on HAVE_IOMEM
 	select DW_DMAC_CORE
 	help
 	  Support the Synopsys DesignWare AHB DMA controller on the
Signature · 1 line
2.30.2
author reviewer
#2 lore raw
Quoted 7 lines · Serge Semin

Hi Andy

Quoted 2 lines · Andy Shevchenko

Some architectures do not provide devm_*() APIs. Hence make the driver dependent on HAVE_IOMEM.

You must have meant "HAS_IOMEM", right?

Good catch!
My memory tricked me :-)

Signature · 2 lines
With Best Regards,
Andy Shevchenko