Skip to contentSkip to conversation

btrfs: fixed rudimentary typos

PATCH In review Bhaskar Chowdhury 2 participants 5 messages Mar 25, 2021 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: fixed rudimentary typos

s/contaning/containing
s/clearning/clearing/

---
 fs/btrfs/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/btrfs/inode.c +2 -2
index 7cdf65be3707..e0c08176bc18 100644
@@ -2784,8 +2784,8 @@ static int insert_reserved_file_extent(struct btrfs_trans_handle *trans,
 	/*
 	 * If we dropped an inline extent here, we know the range where it is
 	 * was not marked with the EXTENT_DELALLOC_NEW bit, so we update the
-	 * number of bytes only for that range contaning the inline extent.
-	 * The remaining of the range will be processed when clearning the
+	 * number of bytes only for that range containing the inline extent.
+	 * The remaining of the range will be processed when clearing the
 	 * EXTENT_DELALLOC_BIT bit through the ordered extent completion.
 	 */
 	if (file_pos == 0 && !IS_ALIGNED(drop_args.bytes_found, sectorsize)) {

--
2.30.1

#1 lore raw
Quoted 3 lines · Bhaskar Chowdhury

s/contaning/containing
s/clearning/clearing/

Have hou scanned the whole subdirectory for typos? We do typo fixing about once a year in one big patch and won't fix them one by one.

#2 lore raw
Quoted 7 lines · David Sterba
Quoted 3 lines · Bhaskar Chowdhury

s/contaning/containing
s/clearning/clearing/

Have hou scanned the whole subdirectory for typos? We do typo fixing about once a year in one big patch and won't fix them one by one.

Once a year???? You must be kidding! that is not good whatever the workflow you have .

#3 lore raw
Quoted 11 lines · Bhaskar Chowdhury
Quoted 7 lines · David Sterba
Quoted 3 lines · Bhaskar Chowdhury

s/contaning/containing
s/clearning/clearing/

Have hou scanned the whole subdirectory for typos? We do typo fixing about once a year in one big patch and won't fix them one by one.

Once a year???? You must be kidding! that is not good whatever the workflow you have .

No kidding. It's even worse, we get that every two years.

* 2016 0132761017e012ab4dc8584d679503f2ba26ca86

  33 files changed, 106 insertions(+), 105 deletions(-)

* 2018 52042d8e82ff50d40e76a275ac0b97aa663328b0

  25 files changed, 70 insertions(+), 69 deletions(-)

You can see the diffstat touches nearly all the files, almost hundred of fixed typos per patch. Now compare that to sending 70-100 individual patches. Time spent on any patch is not zero and for such trivial changes it's not justified so the workflow is to do that in batches. If you care about fixing typos in fs/btrfs/, please fix them all. I've found about 50.

#4 lore raw
Quoted 19 lines · David Sterba
Quoted 11 lines · Bhaskar Chowdhury
Quoted 7 lines · David Sterba
Quoted 3 lines · Bhaskar Chowdhury

s/contaning/containing
s/clearning/clearing/

Have hou scanned the whole subdirectory for typos? We do typo fixing about once a year in one big patch and won't fix them one by one.

Once a year???? You must be kidding! that is not good whatever the workflow you have .

No kidding. It's even worse, we get that every two years.

* 2016 0132761017e012ab4dc8584d679503f2ba26ca86

 33 files changed, 106 insertions(+), 105 deletions(-)

* 2018 52042d8e82ff50d40e76a275ac0b97aa663328b0

Quoted 8 lines
 25 files changed, 70 insertions(+), 69 deletions(-)

You can see the diffstat touches nearly all the files, almost hundred of fixed typos per patch. Now compare that to sending 70-100 individual patches. Time spent on any patch is not zero and for such trivial changes it's not justified so the workflow is to do that in batches. If you care about fixing typos in fs/btrfs/, please fix them all. I've found about 50.

I certainly do , not only for btrfs but for the whole kernel, it might sound ridiculous , but someone has to bell the cat , right?

If I get little cooperation from everyone , we can pull it through, it would be good for the future generation.