Skip to contentSkip to conversation

package/network-manager: add CPE variables

PATCH New Heiko Thiery 3 participants 6 messages Mar 25, 2021 – Mar 31, 2021

lore
Share & tools
lore

Heiko Thiery

author
#0 lore raw

PATCH 1/2 package/network-manager: add CPE variables

cpe:2.3:a:gnome:networkmanager is a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetworkmanager

Signed-off-by Heiko Thiery <[email protected]>
---
 package/network-manager/network-manager.mk | 2 ++
 1 file changed, 2 insertions(+)
package/network-manager/network-manager.mk +2 -0
index 4b2ade5b9b..9402564cb4 100644
@@ -13,6 +13,8 @@ NETWORK_MANAGER_DEPENDENCIES = host-pkgconf udev gnutls libglib2 \
 	libgcrypt wireless_tools util-linux host-intltool readline libndp
 NETWORK_MANAGER_LICENSE = GPL-2.0+ (app), LGPL-2.1+ (libnm)
 NETWORK_MANAGER_LICENSE_FILES = COPYING COPYING.LGPL CONTRIBUTING
+NETWORK_MANAGER_CPE_ID_VENDOR = gnome
+NETWORK_MANAGER_CPE_ID_PRODUCT = networkmanager
 NETWORK_MANAGER_SELINUX_MODULES = networkmanager
 
 NETWORK_MANAGER_CONF_ENV = \
Signature · 1 line
2.30.0
author
#1 lore raw

PATCH 2/2 package/network-manager-openvpn: add CPE variables

cpe:2.3:a:gnome:network_manager_vpnc ia a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetwork_manager_vpnc

Signed-off-by Heiko Thiery <[email protected]>
---
 package/network-manager-openvpn/network-manager-openvpn.mk | 2 ++
 1 file changed, 2 insertions(+)
package/network-manager-openvpn/network-manager-openvpn.mk +2 -0
index 1a872dc127..d861ac65ae 100644
@@ -11,6 +11,8 @@ NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager
 NETWORK_MANAGER_OPENVPN_DEPENDENCIES = network-manager openvpn
 NETWORK_MANAGER_OPENVPN_LICENSE = GPL-2.0+
 NETWORK_MANAGER_OPENVPN_LICENSE_FILES = COPYING
+NETWORK_MANAGER_OPENVPN_CPE_ID_VENDOR = gnome
+NETWORK_MANAGER_OPENVPN_CPE_ID_PRODUCT = network_manager_vpnc
 
 NETWORK_MANAGER_OPENVPN_CONF_OPTS = \
 	--without-gnome
Signature · 1 line
2.30.0
#2 lore raw

PATCH 2/2 package/network-manager-openvpn: add CPE variables

Quoted 15 lines · On Thu, 25 Mar 2021 13:54:44 +0100 Heiko Thiery <[email protected]> wrote:

cpe:2.3:a:gnome:network_manager_vpnc ia a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetwork_manager_vpnc

Signed-off-by Heiko Thiery <[email protected]>
---
 package/network-manager-openvpn/network-manager-openvpn.mk | 2 ++
 1 file changed, 2 insertions(+)
package/network-manager-openvpn/network-manager-openvpn.mk +0 -0
index 1a872dc127..d861ac65ae 100644

package/network-manager-openvpn/network-manager-openvpn.mk NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager · line 15

Quoted 5 lines
package/network-manager-openvpn/network-manager-openvpn.mk +2 -0
@@ -11,6 +11,8 @@ NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager
 NETWORK_MANAGER_OPENVPN_DEPENDENCIES = network-manager openvpn
 NETWORK_MANAGER_OPENVPN_LICENSE = GPL-2.0+
 NETWORK_MANAGER_OPENVPN_LICENSE_FILES = COPYING
+NETWORK_MANAGER_OPENVPN_CPE_ID_VENDOR = gnome
+NETWORK_MANAGER_OPENVPN_CPE_ID_PRODUCT = network_manager_vpnc

Are you sure this is correct ? NetworkManager-vpnc is for Cisco client, not for OpenVPN clients. See
https://gitlab.gnome.org/GNOME/NetworkManager-vpnc vs
https://gitlab.gnome.org/GNOME/NetworkManager-openvpn.

Thomas

Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author
#3 lore raw

PATCH 2/2 package/network-manager-openvpn: add CPE variables

Hi Thomas,

Am So., 28. M?rz 2021 um 21:21 Uhr schrieb Thomas Petazzoni <[email protected]>:

Quoted 14 lines
Quoted 10 lines · On Thu, 25 Mar 2021 13:54:44 +0100 Heiko Thiery <[email protected]> wrote:

cpe:2.3:a:gnome:network_manager_vpnc ia a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetwork_manager_vpnc

Signed-off-by Heiko Thiery <[email protected]>
---
 package/network-manager-openvpn/network-manager-openvpn.mk | 2 ++
 1 file changed, 2 insertions(+)
Quoted 15 lines

package/network-manager-openvpn/network-manager-openvpn.mk NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager · line 15

Quoted 10 lines
package/network-manager-openvpn/network-manager-openvpn.mk +2 -0
index 1a872dc127..d861ac65ae 100644
@@ -11,6 +11,8 @@ NETWORK_MANAGER_OPENVPN_SITE = https://download.gnome.org/sources/NetworkManager
 NETWORK_MANAGER_OPENVPN_DEPENDENCIES = network-manager openvpn
 NETWORK_MANAGER_OPENVPN_LICENSE = GPL-2.0+
 NETWORK_MANAGER_OPENVPN_LICENSE_FILES = COPYING
+NETWORK_MANAGER_OPENVPN_CPE_ID_VENDOR = gnome
+NETWORK_MANAGER_OPENVPN_CPE_ID_PRODUCT = network_manager_vpnc

Are you sure this is correct ? NetworkManager-vpnc is for Cisco client, not for OpenVPN clients. See
https://gitlab.gnome.org/GNOME/NetworkManager-vpnc vs
https://gitlab.gnome.org/GNOME/NetworkManager-openvpn.

You are absolutely right. This was my fault. Please ignore this patch and sorry for the noise.

Signature · 1 line
Heiko
Applied
#4 lore raw

PATCH 1/2 package/network-manager: add CPE variables

In reply to Heiko Thiery
Quoted 9 lines · On Thu, 25 Mar 2021 13:54:42 +0100 Heiko Thiery <[email protected]> wrote:

cpe:2.3:a:gnome:networkmanager is a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetworkmanager

Signed-off-by Heiko Thiery <[email protected]>
---
 package/network-manager/network-manager.mk | 2 ++
 1 file changed, 2 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/2 package/network-manager: add CPE variables

In reply to Heiko Thiery
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Heiko" == Heiko Thiery <[email protected]> writes:

cpe:2.3:a:gnome:networkmanager is a valid CPE identifier for this package:

https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Agnome%3Anetworkmanager

Signed-off-by Heiko Thiery <[email protected]>

Committed to 2021.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard