Skip to contentSkip to conversation

usb: dwc2: Fix power saving general issues.

PATCH In review Artur Petrosyan 2 participants 4 messages Mar 26, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover usb: dwc2: Fix power saving general issues.

This patch set is part of multiple series and is continuation of the "usb: dwc2: Fix and improve
power saving modes" patch set.
(Patch set link: https://marc.info/?l=linux-usb&m=160379622403975&w=2).

The patches that were included in the "usb: dwc2:
Fix and improve power saving modes" which was submitted earlier was too large and needed to be split up into smaller patch sets. So this is the first series in the whole power saving mode fixes.

Each remaining patch set have dependency on previous set and will be submitted after each of them are integrated.

The series includes the following patch sets with multiple patches by below order.
1. usb: dwc2: Fix power saving general issues.
2. usb: dwc2: Fix Partial Power down issues.
3. usb: dwc2: Add clock gating support.
4. usb: dwc2: Fix Hibernation issues

Changes since V1:
- Added Fixes tag and stable kernel in below patches to point to the commits the fixes are addressing
1. "usb: dwc2: Prevent core suspend when port connection flag is 0"
2. "usb: dwc2: Fix HPRT0.PrtSusp bit setting for HiKey 960 board."
- Updated the changelog of "usb: dwc2: Add default param to control power optimization." patch.

Artur Petrosyan (3):
usb: dwc2: Add default param to control power optimization.
usb: dwc2: Fix HPRT0.PrtSusp bit setting for HiKey 960 board.
usb: dwc2: Prevent core suspend when port connection flag is 0

 drivers/usb/dwc2/core.h    |  3 +++
 drivers/usb/dwc2/debugfs.c |  2 ++
 drivers/usb/dwc2/hcd.c     |  5 +++--
 drivers/usb/dwc2/params.c  | 17 ++++++++++++-----
 4 files changed, 20 insertions(+), 7 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw
Quoted 14 lines · Artur Petrosyan

This patch set is part of multiple series and is continuation of the "usb: dwc2: Fix and improve
power saving modes" patch set.
(Patch set link: https://marc.info/?l=linux-usb&m=160379622403975&w=2).

The patches that were included in the "usb: dwc2:
Fix and improve power saving modes" which was submitted earlier was too large and needed to be split up into smaller patch sets. So this is the first series in the whole power saving mode fixes.

Each remaining patch set have dependency on previous set and will be submitted after each of them are integrated.

Quoted 6 lines

The series includes the following patch sets with multiple patches by below order.
1. usb: dwc2: Fix power saving general issues.
2. usb: dwc2: Fix Partial Power down issues.
3. usb: dwc2: Add clock gating support.
4. usb: dwc2: Fix Hibernation issues

You only sent 3 patches, not 4.

So this makes no sense to me, what am I supposed to do?

confused,

greg k-h

#2 lore raw

Hi Greg,

Quoted 22 lines · Greg Kroah-Hartman
Quoted 14 lines · Artur Petrosyan

This patch set is part of multiple series and is
continuation of the "usb: dwc2: Fix and improve
power saving modes" patch set.
(Patch set link: https://urldefense.com/v3/__https://marc.info/?l=linux-usb&m=160379622403975&w=2__;!!A4F2R9G_pg!Icyuillfz_Iy_FrHe2RmVP0zFNTYupWQYmma2AX71Jsqg4cwSaw4hKokDSvIBxrAdsRmUD4$ ).

The patches that were included in the "usb: dwc2:
Fix and improve power saving modes" which was submitted earlier was too large and needed to be split up into smaller patch sets. So this is the first series in the whole power saving mode fixes.

Each remaining patch set have dependency on previous set and will be submitted after each of them are integrated.

Quoted 6 lines

The series includes the following patch sets with multiple patches by below order.
1. usb: dwc2: Fix power saving general issues.
2. usb: dwc2: Fix Partial Power down issues.
3. usb: dwc2: Add clock gating support.
4. usb: dwc2: Fix Hibernation issues

Quoted 3 lines

You only sent 3 patches, not 4.

So this makes no sense to me, what am I supposed to do?

The 4 items that are listed are patch sets. The first patch set that I have sent is "usb: dwc2: Fix power saving general issues.", which includes the 3 patches that have been sent.

I wrote the other 3 patch set names in the list to indicate that I will send them after this "usb: dwc2: Fix power saving general issues." patch set is integrated to mainline.

Quoted 5 lines

confused,

greg k-h

Regards,
Artur

#3 lore raw
Quoted 27 lines · Artur Petrosyan

Hi Greg,

Quoted 24 lines · Greg Kroah-Hartman
Quoted 14 lines · Artur Petrosyan

This patch set is part of multiple series and is
continuation of the "usb: dwc2: Fix and improve
power saving modes" patch set.
(Patch set link: https://urldefense.com/v3/__https://marc.info/?l=linux-usb&m=160379622403975&w=2__;!!A4F2R9G_pg!Icyuillfz_Iy_FrHe2RmVP0zFNTYupWQYmma2AX71Jsqg4cwSaw4hKokDSvIBxrAdsRmUD4$ ).

The patches that were included in the "usb: dwc2:
Fix and improve power saving modes" which was submitted earlier was too large and needed to be split up into smaller patch sets. So this is the first series in the whole power saving mode fixes.

Each remaining patch set have dependency on previous set and will be submitted after each of them are integrated.

Quoted 6 lines

The series includes the following patch sets with multiple patches by below order.
1. usb: dwc2: Fix power saving general issues.
2. usb: dwc2: Fix Partial Power down issues.
3. usb: dwc2: Add clock gating support.
4. usb: dwc2: Fix Hibernation issues

You only sent 3 patches, not 4.

Quoted 8 lines
Quoted 1 line

So this makes no sense to me, what am I supposed to do?

The 4 items that are listed are patch sets. The first patch set that I have sent is "usb: dwc2: Fix power saving general issues.", which includes the 3 patches that have been sent.

I wrote the other 3 patch set names in the list to indicate that I will send them after this "usb: dwc2: Fix power saving general issues." patch set is integrated to mainline.

I'm not taking this first patch as-is, sorry, see my comments on it already.

I took patch 2 and 3 though.

thanks,

greg k-h