Skip to contentSkip to conversation

Staging: rtl8723bs: remove obsolete comments

PATCH New Marco Cesati 1 participant 2 messages Mar 26, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Staging: rtl8723bs: remove obsolete comments

Remove some orphan comments in the staging/rtl8723bs driver

---
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h    | 2 --
 drivers/staging/rtl8723bs/hal/odm.h             | 3 ---
 drivers/staging/rtl8723bs/hal/odm_interface.h   | 2 --
 drivers/staging/rtl8723bs/include/hal_com_h2c.h | 5 -----
 4 files changed, 12 deletions(-)
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h +0 -2
index 75e1d1a37626..7b2d94a33d9c 100644
@@ -198,8 +198,6 @@ enum {
 	BTC_WIFI_PNP_MAX
 };
 
-/* for 8723b-d cut large current issue */
-
 /*  defined for BFP_BTC_GET */
 enum {
 	/*  type bool */
drivers/staging/rtl8723bs/hal/odm.h +0 -3
index dd0c4616086d..ff21343fbe0b 100644
@@ -1147,9 +1147,6 @@ enum { /* tag_RF_Type_Definition */
 	RF_MAX = 2,
 };
 
-/* 3 =========================================================== */
-/* 3 Antenna Diversity */
-/* 3 =========================================================== */
 /*  Maximal number of antenna detection mechanism needs to perform, added by Roger, 2011.12.28. */
 #define	MAX_ANTENNA_DETECTION_CNT	10
 
drivers/staging/rtl8723bs/hal/odm_interface.h +0 -2
index 4ee5903c41b5..d19347b02890 100644
@@ -11,8 +11,6 @@
 
 
 
-/*  =========== Constant/Structure/Enum/... Define */
-
 /*  =========== Macro Define */
 
 #define _reg_all(_name)			ODM_##_name
drivers/staging/rtl8723bs/include/hal_com_h2c.h +0 -5
index c7c2ff6c83b1..24cd9415fa95 100644
@@ -7,11 +7,6 @@
 #ifndef __COMMON_H2C_H__
 #define __COMMON_H2C_H__
 
-/*  */
-/*     H2C CMD DEFINITION    ------------------------------------------------ */
-/*  */
-/*  88e, 8723b, 8812, 8821, 92e use the same FW code base */
-
 #define H2C_RSVDPAGE_LOC_LEN		5
 #define H2C_MEDIA_STATUS_RPT_LEN		3
 #define H2C_KEEP_ALIVE_CTRL_LEN	2
Signature · 1 line
2.30.2
#1 lore raw

PATCH 2/2 Staging: rtl8723bs: remove useless macros

Remove two 'no-op' macros, as well as two related unreferenced macros, in the staging/rtl8723bs driver.

---
 drivers/staging/rtl8723bs/include/osdep_service.h | 5 -----
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 --
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c      | 2 --
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c     | 4 +---
 4 files changed, 1 insertion(+), 12 deletions(-)
drivers/staging/rtl8723bs/include/osdep_service.h +0 -5
index fd8830a51707..b49838c7e457 100644
@@ -58,11 +58,6 @@
 
 extern int RTW_STATUS_CODE(int error_code);
 
-#define mstat_tf_idx(flags) ((flags)&0xff)
-#define mstat_ff_idx(flags) (((flags)&0xff00) >> 8)
-
-#define rtw_mstat_update(flag, status, sz) do {} while (0)
-#define rtw_mstat_dump(sel) do {} while (0)
 void *_rtw_zmalloc(u32 sz);
 void *_rtw_malloc(u32 sz);
 void _kfree(u8 *pbuf, u32 sz);
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0 -2
index 8deaf98a83dd..4f6398f86b75 100644
@@ -2385,8 +2385,6 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry(struct sk_buff *skb, struc
 	if (!skb)
 		goto fail;
 
-	rtw_mstat_update(MSTAT_TYPE_SKB, MSTAT_ALLOC_SUCCESS, skb->truesize);
-
 	if (unlikely(skb->len < sizeof(struct ieee80211_radiotap_header)))
 		goto fail;
 
drivers/staging/rtl8723bs/os_dep/sdio_intf.c +0 -2
index 156ad91d33ee..b6be1423ef75 100644
@@ -577,8 +577,6 @@ static void __exit rtw_drv_halt(void)
 	rtw_ndev_notifier_unregister();
 
 	DBG_871X_LEVEL(_drv_always_, "module exit success\n");
-
-	rtw_mstat_dump(RTW_DBGDUMP);
 }
 
 
drivers/staging/rtl8723bs/os_dep/xmit_linux.c +1 -3
index a3b6584ca0d0..216b2f62eefd 100644
@@ -248,10 +248,8 @@ int rtw_xmit_entry(struct sk_buff *pkt, struct net_device *pnetdev)
 {
 	int ret = 0;
 
-	if (pkt) {
-		rtw_mstat_update(MSTAT_TYPE_SKB, MSTAT_ALLOC_SUCCESS, pkt->truesize);
+	if (pkt)
 		ret = _rtw_xmit_entry(pkt, pnetdev);
-	}
 
 	return ret;
 }
Signature · 1 line
2.30.2