Skip to contentSkip to conversation

spi: dt-bindings: nvidia,tegra210-quad: Use documented compatible "jedec,spi-nor" in example

PATCH In review Rob Herring 2 participants 3 messages Mar 27, 2021 – Mar 29, 2021

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 spi: dt-bindings: nvidia,tegra210-quad: Use documented compatible "jedec,spi-nor" in example

The 'spi-nor' compatible used in the example is not documented. Use the documented 'jedec,spi-nor' compatible instead.

---
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml +1 -1
index 35a8045b2c70..53627c6e2ae3 100644
@@ -106,7 +106,7 @@ examples:
             dma-names = "rx", "tx";
 
             flash@0 {
-                    compatible = "spi-nor";
+                    compatible = "jedec,spi-nor";
                     reg = <0>;
                     spi-max-frequency = <104000000>;
                     spi-tx-bus-width = <2>;
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Rob Herring

The 'spi-nor' compatible used in the example is not documented. Use the documented 'jedec,spi-nor' compatible instead.

Quoted 3 lines
---
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
author maintainer
#2 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

The 'spi-nor' compatible used in the example is not documented. Use the documented 'jedec,spi-nor' compatible instead.

Quoted 3 lines
---
 Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ugg, I guess I should have tested this first:

Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.example.dt.yaml: flash@0: 'nvidia,rx-clk-tap-delay', 'nvidia,tx-clk-tap-delay' do not match any of the regexes: '^partition@', 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml

This issue has come up a couple of times recently. There's not really an easy fix for this other than dropping the properties from the example and that doesn't help for actual dts file checks.

The issue is nvidia,tegra210-quad.yaml is applied to the SPI controller node and jedec,spi-nor.yaml is applied to the child node. Since those are independent, there's never a single schema with all possible child properties.

We could have a schema listing all these slave properties and every SPI slave binding has to reference that schema.

Rob