Skip to contentSkip to conversation

Use standard features in the Makefile

PATCH Superseded Alejandro Colomar 2 participants 13 messages Apr 6, 2021 – May 9, 2021 1 message not in the archive

Subsystems (2)
Kbuild Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Alejandro Colomar

author
#1 lore raw

v4 cover Use standard features in the Makefile

v4:
- .gitignore: ignore everything new by default, instead of ignoring specific things.

Alejandro Colomar (3):
Makefile: Use standard features (IMPORTANT: default prefix changed)
Makefile: Fix bug when running in parallel
.gitignore: Add file

 .gitignore |   8 ++++
 Makefile   | 116 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 100 insertions(+), 24 deletions(-)
 create mode 100644 .gitignore
Signature · 1 line
2.31.0
author
#2 lore raw

v5 cover Use standard features in the Makefile

v4:
- .gitignore: ignore everything new by default, instead of ignoring specific things.

v5:
- .gitignore: Add .gitignore exception
- .gitignore: */** ==> * Ignore absolutely everything new.

Alejandro Colomar (3):
Makefile: Use standard features (IMPORTANT: default prefix changed)
Makefile: Fix bug when running in parallel
.gitignore: Add file

 .gitignore |   8 ++++
 Makefile   | 116 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 100 insertions(+), 24 deletions(-)
 create mode 100644 .gitignore
Signature · 1 line
2.31.0
author
#3 lore raw

PATCH v5 2/3 Makefile: Fix bug when running in parallel

In reply to Alejandro Colomar

Prerequisites can run in parallel. This wouldn't make any sense when uninstalling and installing again.

For that, use consecutive commands, which run one after the other even with multiple cores.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Makefile +3 -1
index 430090801..fdfaf9645 100644
@@ -20,7 +20,9 @@ INSTALL_DATA = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL) -m 755 -d
 
 .PHONY: all
-all: remove install
+all:
+	$(MAKE) uninstall;
+	$(MAKE) install;
 
 # Use with
 #  make HTOPTS=whatever html
Signature · 1 line
2.31.0
author
#4 lore raw

PATCH v5 3/3 .gitignore: Add file

In reply to Alejandro Colomar

Ignore everything new by default.

This avoids having to update the .gitignore when we need to ignore something new. It also avoids accidents that may add an unwanted temporary file.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
 .gitignore | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 .gitignore
.gitignore new file +11 -0
new file mode 100644
index 000000000..7caf4c49f
@@ -0,0 +1,11 @@
+*
+.*
+.gitignore
+!Changes*
+!CONTRIBUTING
+!MAINTAINER_NOTES
+!Makefile
+!man?/*.?
+!man-pages*
+!README
+!scripts/
Signature · 1 line
2.31.0
author
#5 lore raw

v6 cover Use standard features in the Makefile

In reply to Alejandro Colomar

Hi Michael,

I was probably a bit distracted when I sent v5. The .gitignore I sent had many issues. I rewrote it from scratch and did some thorough testing this time.

Alejandro Colomar (3):
Makefile: Use standard features (IMPORTANT: default prefix changed)
Makefile: Fix bug when running in parallel
.gitignore: Add file

 .gitignore |  12 ++++++
 Makefile   | 116 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 104 insertions(+), 24 deletions(-)
 create mode 100644 .gitignore
Signature · 1 line
2.31.0
#6 lore raw

Hi Alex,

Quoted 10 lines · Alejandro Colomar

Hi Michael,

I was probably a bit distracted when I sent v5. The .gitignore I sent had many issues. I rewrote it from scratch and did some thorough testing this time.

Alejandro Colomar (3):
Makefile: Use standard features (IMPORTANT: default prefix changed)
Makefile: Fix bug when running in parallel
.gitignore: Add file

Quoted 4 lines
 .gitignore |  12 ++++++
 Makefile   | 116 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 104 insertions(+), 24 deletions(-)
 create mode 100644 .gitignore

None of the patches in this series applies. Did I miss some prerequisite patches?

Thanks,

Michael

Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
author
#7 lore raw

Hi Michael,

Quoted 5 lines · Michael Kerrisk (man-pages)
Quoted 5 lines

Alejandro Colomar (3):
Makefile: Use standard features (IMPORTANT: default prefix changed)
Makefile: Fix bug when running in parallel
.gitignore: Add file

Quoted 7 lines
Quoted 4 lines
 .gitignore |  12 ++++++
 Makefile   | 116 ++++++++++++++++++++++++++++++++++++++++++-----------
 2 files changed, 104 insertions(+), 24 deletions(-)
 create mode 100644 .gitignore

None of the patches in this series applies. Did I miss some prerequisite patches?

Yes, but don't mind; I'll resend everything.

Cheers,

Alex

Signature · 3 lines
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
author
#8 lore raw

PATCH v6 2/3 Makefile: Fix bug when running in parallel

In reply to Alejandro Colomar

Prerequisites can run in parallel. This wouldn't make any sense when uninstalling and installing again.

For that, use consecutive commands, which run one after the other even with multiple cores.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Makefile +3 -1
index 430090801..fdfaf9645 100644
@@ -20,7 +20,9 @@ INSTALL_DATA = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL) -m 755 -d
 
 .PHONY: all
-all: remove install
+all:
+	$(MAKE) uninstall;
+	$(MAKE) install;
 
 # Use with
 #  make HTOPTS=whatever html
Signature · 1 line
2.31.0
author
#9 lore raw

PATCH v6 3/3 .gitignore: Add file

In reply to Alejandro Colomar

Ignore everything new by default.

This avoids adding to git unwanted temporary files.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
 .gitignore | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 .gitignore
.gitignore new file +13 -0
new file mode 100644
index 000000000..866012df4
@@ -0,0 +1,13 @@
+# Ignore everything new by default
+/*
+
+# Ignore everything in man?/ that doesn't follow conventions (e.g., tmp files)
+!/man?
+/man?/**
+!/man?/**.?
+
+# These files change name in each release
+!/man-pages*.Announce
+!/man-pages*.lsm
+
+!/scripts
Signature · 1 line
2.31.0
author
#10 lore raw

Re: [PATCH v6 3/3] .gitignore: Add file

Hi Michael,

Please see a few cosmetic changes below.

Thanks,

Alex

Quoted 18 lines · Alejandro Colomar

Ignore everything new by default.

This avoids adding to git unwanted temporary files.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
  .gitignore | 13 +++++++++++++
  1 file changed, 13 insertions(+)

create mode 100644 .gitignore

.gitignore new file +0 -0
new file mode 100644
index 000000000..866012df4

.gitignore line 5

Quoted 5 lines
.gitignore new file +5 -0
@@ -0,0 +1,13 @@
+# Ignore everything new by default
+/*
+
+# Ignore everything in man?/ that doesn't follow conventions (e.g., tmp files)
+!/man?

Please add a trailing / here (not needed, but for symmetry).

.gitignore line 13

Quoted 8 lines
.gitignore new file +8 -0
+/man?/**
+!/man?/**.?
+
+# These files change name in each release
+!/man-pages*.Announce
+!/man-pages*.lsm
+
+!/scripts

Please add a trailing / here (not needed, but for symmetry).

Quoted 1 line
Signature · 3 lines
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/
author
#11 lore raw

PATCH v4 2/3 Makefile: Fix bug when running in parallel

In reply to a message not in the archive

Prerequisites can run in parallel. This wouldn't make any sense when uninstalling and installing again.

For that, use consecutive commands, which run one after the other even with multiple cores.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
 Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Makefile +3 -1
index 430090801..fdfaf9645 100644
@@ -20,7 +20,9 @@ INSTALL_DATA = $(INSTALL) -m 644
 INSTALL_DIR = $(INSTALL) -m 755 -d
 
 .PHONY: all
-all: remove install
+all:
+	$(MAKE) uninstall;
+	$(MAKE) install;
 
 # Use with
 #  make HTOPTS=whatever html
Signature · 1 line
2.31.0
author
#12 lore raw

PATCH v4 3/3 .gitignore: Add file

In reply to a message not in the archive

Ignore everything new by default.

This avoids having to update the .gitignore when we need to ignore something new. It also avoids accidents that may add an unwanted temporary file.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
 .gitignore | 9 +++++++++
 1 file changed, 9 insertions(+)
 create mode 100644 .gitignore
.gitignore new file +9 -0
new file mode 100644
index 000000000..9c58a2718
@@ -0,0 +1,9 @@
+*/**
+!Changes*
+!CONTRIBUTING
+!MAINTAINER_NOTES
+!Makefile
+!man?/*.?
+!man-pages*
+!README
+!scripts/
Signature · 1 line
2.31.0
author
#13 lore raw

Re: [PATCH v4 3/3] .gitignore: Add file

Hi Michael,

Quoted 21 lines · Alejandro Colomar

Ignore everything new by default.

This avoids having to update the .gitignore when we need to ignore something new. It also avoids accidents that may add an unwanted temporary file.

Cc Debian man-pages <[email protected]>
Cc Dr. Tobias Quathamer <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>
---
  .gitignore | 9 +++++++++
  1 file changed, 9 insertions(+)

create mode 100644 .gitignore

.gitignore new file +0 -0
new file mode 100644
index 000000000..9c58a2718

.gitignore line 9

Quoted 9 lines
.gitignore new file +9 -0
@@ -0,0 +1,9 @@
+*/**
+!Changes*
+!CONTRIBUTING
+!MAINTAINER_NOTES
+!Makefile
+!man?/*.?
+!man-pages*
+!README
+!scripts/

I forgot to add the .gitignore to the .gitignore exceptions :-P

Please add it.

Thanks,

Alex

Signature · 3 lines
Alejandro Colomar
Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/
http://www.alejandro-colomar.es/