nvme: Report MDTS values that are too large
PATCH 1/1 nvme: Report MDTS values that are too large
Instead of triggering an integer overflow and undefined behavior if MDTS is too large, set max_hw_sectors to UINT_MAX and log an error message.
Signed-off-by Bart Van Assche <[email protected]>
--- drivers/nvme/host/core.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/nvme/host/core.c +7 -3
@@ -3123,10 +3123,14 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)atomic_set (&ctrl->abort_limit, id->acl +1 ); ctrl->vwc = id->vwc; -if (id->mdts) - max_hw_sectors =1 << (id->mdts + page_shift -9 ); -else + max_hw_sectors =UINT_MAX ; +if (id->mdts &&check_shl_overflow (1U , id->mdts + page_shift -9 , + &max_hw_sectors)) { +dev_err (ctrl->device, +"MDTS = %u is too large (page_shift = %u)\n" , + id->mdts, page_shift); max_hw_sectors =UINT_MAX ; + } ctrl->max_hw_sectors =min_not_zero (ctrl->max_hw_sectors, max_hw_sectors);
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
maintainerQuoted 2 lines · Bart Van Assche
Instead of triggering an integer overflow and undefined behavior if MDTS is too large, set
max_hw_sectorstoUINT_MAXand log an error message.
I really do not think reporting an error for something that is perfetly valid but not useful to Linux makes much sense.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme