Skip to contentSkip to conversation

drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'

PATCH In review Dan Carpenter 2 participants 2 messages Mar 31, 2021

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/7 drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git kvm-arm64/ptp
head:   b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64: Probe for the presence of KVM hypervisor
config: arm64-randconfig-m031-20210330 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>

smatch warnings:
drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'

vim +46 drivers/firmware/smccc/kvm_guest.c

fa591eac2e1ffd Will Deacon 2020-12-09 43 bool kvm_arm_hyp_service_available(u32 func_id)

                                           ^^^^
fa591eac2e1ffd Will Deacon 2020-12-09  44  {
fa591eac2e1ffd Will Deacon 2020-12-09  45  	if (func_id >= ARM_SMCCC_KVM_NUM_FUNCS)
fa591eac2e1ffd Will Deacon 2020-12-09 @46  		return -EINVAL;
                                                        ^^^^^^^^^^^^^^^

This counts as true.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#1 lore raw
Quoted 21 lines · Dan Carpenter

tree:
https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
kvm-arm64/ptp

head:   b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64:

Probe for the presence of KVM hypervisor
config: arm64-randconfig-m031-20210330 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate

Reported-by kernel test robot <[email protected]>
Reported-by Dan Carpenter <[email protected]>

smatch warnings:
drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available()
warn: signedness bug returning '(-22)'

vim +46 drivers/firmware/smccc/kvm_guest.c

fa591eac2e1ffd Will Deacon 2020-12-09 43 bool
kvm_arm_hyp_service_available(u32 func_id)

Quoted 8 lines
                                           ^^^^
fa591eac2e1ffd Will Deacon 2020-12-09  44  {
fa591eac2e1ffd Will Deacon 2020-12-09  45  	if (func_id >=
ARM_SMCCC_KVM_NUM_FUNCS)
fa591eac2e1ffd Will Deacon 2020-12-09 @46  		return -EINVAL;
                                                        ^^^^^^^^^^^^^^^

This counts as true.

Nice catch. Now fixed. Thanks for the heads up.

         M.
Signature · 1 line
Jazz is not dead. It just smells funny...