cifsd: use kfree to free memory allocated by kmalloc or kzalloc
Subsystems (3)
PATCH 1/1 cifsd: use kfree to free memory allocated by kmalloc or kzalloc
kfree should be used to free memory allocated by kmalloc or kzalloc to avoid any overhead and for maintaining consistency.
Fixes 5dfeb6d945 ("cifsd: use kmalloc() for small allocations")
Signed-off-by Muhammad Usama Anjum <[email protected]>
--- fs/cifsd/buffer_pool.c | 4 ++-- fs/cifsd/mgmt/share_config.c | 2 +- fs/cifsd/mgmt/user_config.c | 8 ++++---- fs/cifsd/mgmt/user_session.c | 6 +++--- fs/cifsd/smb2pdu.c | 4 ++-- fs/cifsd/vfs_cache.c | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-)
fs/cifsd/buffer_pool.c +2 -2
@@ -78,7 +78,7 @@ static int register_wm_size_class(size_t sz)list_for_each_entry (l, &wm_lists, list) {if (l->sz == sz) {write_unlock (&wm_lists_lock); -kvfree (nl); +kfree (nl);return 0 ; } }
@@ -181,7 +181,7 @@ static void wm_list_free(struct wm_list *l)list_del (&wm->list);kvfree (wm); } -kvfree (l); +kfree (l); }static void wm_lists_destroy (void )
fs/cifsd/mgmt/share_config.c +1 -1
@@ -102,7 +102,7 @@ static int parse_veto_list(struct ksmbd_share_config *share, p->pattern =kstrdup (veto_list,GFP_KERNEL );if (!p->pattern) { -ksmbd_free (p); +kfree (p);return -ENOMEM ; }
fs/cifsd/mgmt/user_config.c +4 -4
@@ -46,8 +46,8 @@ struct ksmbd_user *ksmbd_alloc_user(struct ksmbd_login_response *resp)if (!user->name || !user->passkey) {kfree (user->name); -ksmbd_free (user->passkey); -ksmbd_free (user); +kfree (user->passkey); +kfree (user); user =NULL ; }return user;
@@ -57,8 +57,8 @@ void ksmbd_free_user(struct ksmbd_user *user) {ksmbd_ipc_logout_request (user->name);kfree (user->name); -ksmbd_free (user->passkey); -ksmbd_free (user); +kfree (user->passkey); +kfree (user); }int ksmbd_anonymous_user (struct ksmbd_user *user)
fs/cifsd/mgmt/user_session.c +3 -3
@@ -53,7 +53,7 @@ static void __session_rpc_close(struct ksmbd_session *sess,ksmbd_free (resp);ksmbd_rpc_id_free (entry->id); -ksmbd_free (entry); +kfree (entry); }static void ksmbd_session_rpc_clear_list (struct ksmbd_session *sess)
@@ -119,7 +119,7 @@ int ksmbd_session_rpc_open(struct ksmbd_session *sess, char *rpc_name)return entry->id; error:list_del (&entry->list); -ksmbd_free (entry); +kfree (entry);return -EINVAL ; }
@@ -174,7 +174,7 @@ void ksmbd_session_destroy(struct ksmbd_session *sess)ksmbd_release_id (session_ida, sess->id);ksmbd_ida_free (sess->tree_conn_ida); -ksmbd_free (sess); +kfree (sess); }static struct ksmbd_session *__session_lookup (unsigned long long id)
fs/cifsd/smb2pdu.c +2 -2
@@ -1611,7 +1611,7 @@ int smb2_sess_setup(struct ksmbd_work *work)ksmbd_conn_set_good (work); sess->state =SMB2_SESSION_VALID ; -ksmbd_free (sess->Preauth_HashValue); +kfree (sess->Preauth_HashValue); sess->Preauth_HashValue =NULL ; }else if (conn->preferred_auth_mech ==KSMBD_AUTH_NTLMSSP ) { rc =generate_preauth_hash (work);
@@ -1637,7 +1637,7 @@ int smb2_sess_setup(struct ksmbd_work *work)ksmbd_conn_set_good (work); sess->state =SMB2_SESSION_VALID ; -ksmbd_free (sess->Preauth_HashValue); +kfree (sess->Preauth_HashValue); sess->Preauth_HashValue =NULL ; } }else {
fs/cifsd/vfs_cache.c +1 -1
@@ -829,6 +829,6 @@ void ksmbd_destroy_file_table(struct ksmbd_file_table *ft)__close_file_table_ids (ft,NULL , session_fd_check);idr_destroy (ft->idr); -ksmbd_free (ft->idr); +kfree (ft->idr); ft->idr =NULL ; }
Signature · 1 line
2.25.1
Quoted 6 lines
kfree should be used to free memory allocated by kmalloc or kzalloc to avoid any overhead and for maintaining consistency.
Fixes 5dfeb6d945 ("cifsd: use kmalloc() for small allocations")Signed-off-by Muhammad Usama Anjum <[email protected]>
Looks good. I will apply. Thanks for your patch!