Skip to contentSkip to conversation

iio:accel:stk8312: Add lowercase i2c device id

PATCH In review Jonathan Cameron 2 participants 2 messages Apr 1, 2021 – Apr 24, 2021 IIO

lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio:accel:stk8312: Add lowercase i2c device id

From: Jonathan Cameron <[email protected]>

These are never upper case. Chances are that all users of this driver were using the ACPI binding but just in case keep the uppercase version but mark it deprecated.

Whilst here tidy up some spacing.

---
 drivers/iio/accel/stk8312.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/iio/accel/stk8312.c +4 -2
index 157d8faefb9e..60aecfa9fd92 100644
@@ -635,13 +635,15 @@ static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
 #endif
 
 static const struct i2c_device_id stk8312_i2c_id[] = {
-	{"STK8312", 0},
+	/* Deprecated in favour of lowercase form */
+	{ "STK8312", 0 },
+	{ "stk8312", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
 
 static const struct acpi_device_id stk8312_acpi_id[] = {
-	{"STK8312", 0},
+	{ "STK8312", 0 },
 	{}
 };
 
Signature · 1 line
2.31.1
#1 lore raw
Quoted 9 lines · On Thu, 1 Apr 2021 15:42:26 +0100 Jonathan Cameron <[email protected]> wrote:

From: Jonathan Cameron <[email protected]>

These are never upper case. Chances are that all users of this driver were using the ACPI binding but just in case keep the uppercase version but mark it deprecated.

Whilst here tidy up some spacing.

I'm not going to pester anyone about reviewing this given how trivial it is.

Hence applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it and prove it's not as trivial as I'm assuming ;(

Jonathan

Quoted 26 lines
---
 drivers/iio/accel/stk8312.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/iio/accel/stk8312.c +4 -2
index 157d8faefb9e..60aecfa9fd92 100644
@@ -635,13 +635,15 @@ static SIMPLE_DEV_PM_OPS(stk8312_pm_ops, stk8312_suspend, stk8312_resume);
 #endif
 
 static const struct i2c_device_id stk8312_i2c_id[] = {
-	{"STK8312", 0},
+	/* Deprecated in favour of lowercase form */
+	{ "STK8312", 0 },
+	{ "stk8312", 0 },
 	{}
 };
 MODULE_DEVICE_TABLE(i2c, stk8312_i2c_id);
 
 static const struct acpi_device_id stk8312_acpi_id[] = {
-	{"STK8312", 0},
+	{ "STK8312", 0 },
 	{}
 };