iio:adc: Drop false comment about lack of timestamp control
Subsystems (2)
Jonathan Cameron
maintainerPATCH 1/1 iio:adc: Drop false comment about lack of timestamp control
From: Jonathan Cameron <[email protected]>
The timestamp control has been a function implemented in the core of IIO for a long time, so this comment is incorrect and has clearly been cut and paste into all these drivers.
The remainder of the comment added nothing and was confusing so dropped that as well.
--- drivers/iio/adc/ad7298.c | 6 ------ drivers/iio/adc/ad7887.c | 6 ------ drivers/iio/adc/ad7923.c | 6 ------ drivers/iio/adc/ad799x.c | 6 ------ 4 files changed, 24 deletions(-)
drivers/iio/adc/ad7298.c +0 -6
@@ -142,12 +142,6 @@ static int ad7298_update_scan_mode(struct iio_dev *indio_dev,return 0 ; } -/* -* ad7298_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -*/ static irqreturn_t ad7298_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;
drivers/iio/adc/ad7887.c +0 -6
@@ -109,12 +109,6 @@ static int ad7887_ring_postdisable(struct iio_dev *indio_dev)return spi_sync (st->spi, &st->msg[AD7887_CH0 ]); } -/* -* ad7887_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -**/ static irqreturn_t ad7887_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;
drivers/iio/adc/ad7923.c +0 -6
@@ -192,12 +192,6 @@ static int ad7923_update_scan_mode(struct iio_dev *indio_dev,return 0 ; } -/* -* ad7923_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -*/ static irqreturn_t ad7923_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;
drivers/iio/adc/ad799x.c +0 -6
@@ -182,12 +182,6 @@ static int ad799x_update_config(struct ad799x_state *st, u16 config)return 0 ; } -/* -* ad799x_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -**/ static irqreturn_t ad799x_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;
Signature · 1 line
2.31.1
Quoted 10 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
The timestamp control has been a function implemented in the core of IIO for a long time, so this comment is incorrect and has clearly been cut and paste into all these drivers.
The remainder of the comment added nothing and was confusing so dropped that as well.
Quoted 82 lines
Signed-off-by Jonathan Cameron <[email protected]>Cc Lars-Peter Clausen <[email protected]>Cc Michael Hennerich <[email protected]>--- drivers/iio/adc/ad7298.c | 6 ------ drivers/iio/adc/ad7887.c | 6 ------ drivers/iio/adc/ad7923.c | 6 ------ drivers/iio/adc/ad799x.c | 6 ------ 4 files changed, 24 deletions(-)drivers/iio/adc/ad7298.c +0
-6@@ -142,12 +142,6 @@ static int ad7298_update_scan_mode(struct iio_dev *indio_dev,return 0 ; } -/* -* ad7298_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -*/ static irqreturn_t ad7298_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;drivers/iio/adc/ad7887.c +0
-6@@ -109,12 +109,6 @@ static int ad7887_ring_postdisable(struct iio_dev *indio_dev)return spi_sync (st->spi, &st->msg[AD7887_CH0 ]); } -/* -* ad7887_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -**/ static irqreturn_t ad7887_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;drivers/iio/adc/ad7923.c +0
-6@@ -192,12 +192,6 @@ static int ad7923_update_scan_mode(struct iio_dev *indio_dev,return 0 ; } -/* -* ad7923_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -*/ static irqreturn_t ad7923_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;drivers/iio/adc/ad799x.c +0
-7@@ -182,12 +182,6 @@ static int ad799x_update_config(struct ad799x_state *st, u16 config)return 0 ; } -/* -* ad799x_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -**/ static irqreturn_t ad799x_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p; --2.31.1
Jonathan Cameron
maintainerQuoted 8 lines · On Fri, 2 Apr 2021 10:25:41 +0300 Alexandru Ardelean <[email protected]>…
Quoted 7 lines · Jonathan Cameron
From: Jonathan Cameron <[email protected]>
The timestamp control has been a function implemented in the core of IIO for a long time, so this comment is incorrect and has clearly been cut and paste into all these drivers.
Quoted 5 lines
Quoted 3 lines
The remainder of the comment added nothing and was confusing so dropped that as well.
Reviewed-by Alexandru Ardelean <[email protected]>
Applied to the togreg branch of iio.git and push out testing for all the normal reasons.
Thanks,
Jonathan
Quoted 83 lines
Quoted 83 lines
Signed-off-by Jonathan Cameron <[email protected]>Cc Lars-Peter Clausen <[email protected]>Cc Michael Hennerich <[email protected]>--- drivers/iio/adc/ad7298.c | 6 ------ drivers/iio/adc/ad7887.c | 6 ------ drivers/iio/adc/ad7923.c | 6 ------ drivers/iio/adc/ad799x.c | 6 ------ 4 files changed, 24 deletions(-)drivers/iio/adc/ad7298.c +0
-6@@ -142,12 +142,6 @@ static int ad7298_update_scan_mode(struct iio_dev *indio_dev,return 0 ; } -/* -* ad7298_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -*/ static irqreturn_t ad7298_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;drivers/iio/adc/ad7887.c +0
-6@@ -109,12 +109,6 @@ static int ad7887_ring_postdisable(struct iio_dev *indio_dev)return spi_sync (st->spi, &st->msg[AD7887_CH0 ]); } -/* -* ad7887_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -**/ static irqreturn_t ad7887_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;drivers/iio/adc/ad7923.c +0
-6@@ -192,12 +192,6 @@ static int ad7923_update_scan_mode(struct iio_dev *indio_dev,return 0 ; } -/* -* ad7923_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -*/ static irqreturn_t ad7923_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p;drivers/iio/adc/ad799x.c +0
-7@@ -182,12 +182,6 @@ static int ad799x_update_config(struct ad799x_state *st, u16 config)return 0 ; } -/* -* ad799x_trigger_handler() bh of trigger launched polling to ring buffer -* -* Currently there is no option in this driver to disable the saving of -* timestamps within the ring. -**/ static irqreturn_t ad799x_trigger_handler (int irq,void *p) {struct iio_poll_func *pf = p; --2.31.1